From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-410337-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 30867 invoked by alias); 16 Oct 2015 10:45:01 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 30845 invoked by uid 89); 16 Oct 2015 10:45:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM autolearn=ham version=3.3.2
X-HELO: mail-ob0-f176.google.com
Received: from Unknown (HELO mail-ob0-f176.google.com) (209.85.214.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 16 Oct 2015 10:43:00 +0000
Received: by obbda8 with SMTP id da8so87433107obb.1        for <gcc-patches@gcc.gnu.org>; Fri, 16 Oct 2015 03:42:52 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.182.96.197 with SMTP id du5mr9467395obb.18.1444992171923; Fri, 16 Oct 2015 03:42:51 -0700 (PDT)
Received: by 10.76.175.132 with HTTP; Fri, 16 Oct 2015 03:42:51 -0700 (PDT)
In-Reply-To: <CAMe9rOomKn4zmoyLwZuUBV-no50BqATXbbDpd6jdxmbw6d98tg@mail.gmail.com>
References: <CAE0nxxhacnNEGpHmZn5tFLGWZ9AJ+iBFwVBAmUJ+8EHxvpGn+w@mail.gmail.com>	<CAFULd4Z09y8Ge8puTwjj_+Dft+MyH=iwyKXULKjNeReNY4OnDA@mail.gmail.com>	<CAFULd4YQLh_TukBXfxcSTEv1mPcqT0PLAJxRf8tckaYB_X3bow@mail.gmail.com>	<CAMe9rOp0SQD2PJxg7td9xU_-houMvW3xk0dR5Gy8AAULBf8HPQ@mail.gmail.com>	<CAFULd4Z9EEygOUUpvRGiWXa9o+_aibwPx-d9E34R0-uCVQB+Ww@mail.gmail.com>	<CAMe9rOqDSAtk9mQxfT-9-rfZrJKz_++dV5h9JkGgCT4tf3MpQg@mail.gmail.com>	<CAFULd4bsyYLEL+GJoiL61J_UMkGcdMXftkFny_b3WDNpuPfTHQ@mail.gmail.com>	<CAFULd4Yemf+qaCac84qkC0kx_VR-G_ppS+WrxPrMdQ-X+iWU1Q@mail.gmail.com>	<CAFULd4Zq5ZpFVp+EutX6_ryMGO5HONutvcbbAks=1E=bzFPgzQ@mail.gmail.com>	<CAMe9rOomKn4zmoyLwZuUBV-no50BqATXbbDpd6jdxmbw6d98tg@mail.gmail.com>
Date: Fri, 16 Oct 2015 10:45:00 -0000
Message-ID: <CAMe9rOpa5saULGcrcXQ4hvTZznYtN5AdKweEd=x9NrTeM9v+TQ@mail.gmail.com>
Subject: Re: [PATCH] Fix pr67963
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: Yulia Koval <vaalfreja@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-10/txt/msg01558.txt.bz2

On Fri, Oct 16, 2015 at 3:31 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Oct 16, 2015 at 2:35 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>> On Fri, Oct 16, 2015 at 8:43 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>> On Thu, Oct 15, 2015 at 9:30 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>>
>>>>>>> Do we support -O2 -march=lakemont with
>>>>>>>
>>>>>>> __attribute__((target("arch=silvermont")))
>>>>>>
>>>>>> Hm, no.
>>>>>>
>>>>>
>>>>> Do we issue an error or silently ignore
>>>>> __attribute__((target("arch=silvermont")))?
>>>>> If we don't support it, should we support
>>>>>
>>>>> -O2 -march=silvermont
>>>>>
>>>>> __attribute__((target("arch=lakemont")))
>>>>
>>>> Actually, we have to re-initialize:
>>>>
>>>>   opts->x_target_flags
>>>>     |= (TARGET_DEFAULT | TARGET_SUBTARGET_DEFAULT) & ~opts_set->x_target_flags;
>>>>
>>>> just before TARGET_SUBTARGET{32,64}_DEFAULT processing, and it will work.
>>>
>>> No, this won't work. The value of MASK_NO_FANCY_MATH depend on
>>> MASK_80387setting, and once fancy math bit is set, it couldn't be
>>> cleared for march != lakemont.
>>>
>>> It looks just like we want to error out when lakemont is enabled with -m80387.
>>
>> Like in the attached patch, that also slightly improves existing error
>> reporting.
>>
>
> We should use a bit instead of checking PROCESSOR_LAKEMONT
> so that we don't need to check another PROCESSOR_XXX for
> a new IA MCU processor.
>

Another related bug:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67985

We may be able to fix both in a patch.

-- 
H.J.