* patch fixing a test for PR55151
@ 2012-11-07 22:21 Vladimir Makarov
2012-11-07 22:27 ` H.J. Lu
0 siblings, 1 reply; 5+ messages in thread
From: Vladimir Makarov @ 2012-11-07 22:21 UTC (permalink / raw)
To: GCC Patches
The following patch adds omitted target for the test. The test was
supposed to run on x86-64 only. On 32-bit x86, it should fail. Reload
fails on this test on x86 too although with an error message. I am
going to add a generation of a message too.
Committed as rev. 193311.
2012-11-07 Vladimir Makarov <vmakarov@redhat.com>
PR rtl-optimization/55151
* gcc.dg/pr55151.c: Compile it only for x86_64.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patch fixing a test for PR55151
2012-11-07 22:21 patch fixing a test for PR55151 Vladimir Makarov
@ 2012-11-07 22:27 ` H.J. Lu
2012-11-07 22:45 ` Vladimir Makarov
0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2012-11-07 22:27 UTC (permalink / raw)
To: Vladimir Makarov; +Cc: GCC Patches
On Wed, Nov 7, 2012 at 2:21 PM, Vladimir Makarov <vmakarov@redhat.com> wrote:
> The following patch adds omitted target for the test. The test was
> supposed to run on x86-64 only. On 32-bit x86, it should fail. Reload
> fails on this test on x86 too although with an error message. I am going to
> add a generation of a message too.
>
> Committed as rev. 193311.
>
> 2012-11-07 Vladimir Makarov <vmakarov@redhat.com>
>
> PR rtl-optimization/55151
> * gcc.dg/pr55151.c: Compile it only for x86_64.
>
Checking x86_64-*-* target is incorrect since i686 GCC can support
64-bit. You should check !ia32 target:
/* { dg-do compile { target { ! { ia32 } } } } */
--
H.J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patch fixing a test for PR55151
2012-11-07 22:27 ` H.J. Lu
@ 2012-11-07 22:45 ` Vladimir Makarov
2012-11-08 16:59 ` Hans-Peter Nilsson
0 siblings, 1 reply; 5+ messages in thread
From: Vladimir Makarov @ 2012-11-07 22:45 UTC (permalink / raw)
To: H.J. Lu; +Cc: GCC Patches
On 12-11-07 5:27 PM, H.J. Lu wrote:
> On Wed, Nov 7, 2012 at 2:21 PM, Vladimir Makarov <vmakarov@redhat.com> wrote:
>> The following patch adds omitted target for the test. The test was
>> supposed to run on x86-64 only. On 32-bit x86, it should fail. Reload
>> fails on this test on x86 too although with an error message. I am going to
>> add a generation of a message too.
>>
>> Committed as rev. 193311.
>>
>> 2012-11-07 Vladimir Makarov <vmakarov@redhat.com>
>>
>> PR rtl-optimization/55151
>> * gcc.dg/pr55151.c: Compile it only for x86_64.
>>
> Checking x86_64-*-* target is incorrect since i686 GCC can support
> 64-bit. You should check !ia32 target:
>
> /* { dg-do compile { target { ! { ia32 } } } } */
>
>
Thanks, H.J. I've just fixed it.
Index: testsuite/ChangeLog
===================================================================
--- testsuite/ChangeLog (revision 193316)
+++ testsuite/ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2012-11-07 Vladimir Makarov <vmakarov@redhat.com>
+
+ PR rtl-optimization/55151
+ * gcc.dg/pr55151.c: Use ia32 instead of x86_64.
+
2012-11-05 Uros Bizjak <ubizjak@gmail.com>
* gcc.dg/tree-ssa/cunroll-1.c: Scan cunrolli dump.
Index: testsuite/gcc.dg/pr55151.c
===================================================================
--- testsuite/gcc.dg/pr55151.c (revision 193316)
+++ testsuite/gcc.dg/pr55151.c (working copy)
@@ -1,5 +1,5 @@
/* PR rtl-optimization/55151 */
-/* { dg-do compile { target x86_64-*-* } } */
+/* { dg-do compile { target { ! { ia32 } } } } */
/* { dg-options "-fPIC" } */
int a, b, c, d, e, f, g, h, i, j, k, l;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patch fixing a test for PR55151
2012-11-07 22:45 ` Vladimir Makarov
@ 2012-11-08 16:59 ` Hans-Peter Nilsson
2012-11-09 14:31 ` Vladimir Makarov
0 siblings, 1 reply; 5+ messages in thread
From: Hans-Peter Nilsson @ 2012-11-08 16:59 UTC (permalink / raw)
To: Vladimir Makarov; +Cc: H.J. Lu, GCC Patches
On Wed, 7 Nov 2012, Vladimir Makarov wrote:
> On 12-11-07 5:27 PM, H.J. Lu wrote:
> > You should check !ia32 target:
> >
> > /* { dg-do compile { target { ! { ia32 } } } } */
> >
> >
> Thanks, H.J. I've just fixed it.
>
> Index: testsuite/ChangeLog
> ===================================================================
> --- testsuite/ChangeLog (revision 193316)
> +++ testsuite/ChangeLog (working copy)
> @@ -1,3 +1,8 @@
> +2012-11-07 Vladimir Makarov <vmakarov@redhat.com>
> +
> + PR rtl-optimization/55151
> + * gcc.dg/pr55151.c: Use ia32 instead of x86_64.
> +
Lots of constraints there that might not be suitable for all
machines. Unless it's expected to pass (almost) everywhere, it
should move to gcc.target/i386.
If it *is* expected to pass everywhere,
at least add /* { dg-require-effective-target fpic } */
or similar (can be done in the target expression).
brgds, H-P
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patch fixing a test for PR55151
2012-11-08 16:59 ` Hans-Peter Nilsson
@ 2012-11-09 14:31 ` Vladimir Makarov
0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Makarov @ 2012-11-09 14:31 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: H.J. Lu, GCC Patches
On 12-11-08 11:59 AM, Hans-Peter Nilsson wrote:
> On Wed, 7 Nov 2012, Vladimir Makarov wrote:
>> On 12-11-07 5:27 PM, H.J. Lu wrote:
>>> You should check !ia32 target:
>>>
>>> /* { dg-do compile { target { ! { ia32 } } } } */
>>>
>>>
>> Thanks, H.J. I've just fixed it.
>>
>> Index: testsuite/ChangeLog
>> ===================================================================
>> --- testsuite/ChangeLog (revision 193316)
>> +++ testsuite/ChangeLog (working copy)
>> @@ -1,3 +1,8 @@
>> +2012-11-07 Vladimir Makarov <vmakarov@redhat.com>
>> +
>> + PR rtl-optimization/55151
>> + * gcc.dg/pr55151.c: Use ia32 instead of x86_64.
>> +
> Lots of constraints there that might not be suitable for all
> machines. Unless it's expected to pass (almost) everywhere, it
> should move to gcc.target/i386.
>
I am agree it is better not to run it on any target. I've moved it to
gcc.target/i386.
Thanks for pointing this out.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-11-09 14:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-07 22:21 patch fixing a test for PR55151 Vladimir Makarov
2012-11-07 22:27 ` H.J. Lu
2012-11-07 22:45 ` Vladimir Makarov
2012-11-08 16:59 ` Hans-Peter Nilsson
2012-11-09 14:31 ` Vladimir Makarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).