Re: [PATCH 2/2] Add some more test cases for fentry and pg

["H.J. Lu" <hjl.tools@gmail.com>]

On Tue, Sep 16, 2014 at 8:36 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Sep 15, 2014 at 8:59 AM, Andi Kleen <ak@linux.intel.com> wrote:
>> On Mon, Sep 15, 2014 at 11:29:50AM +0200, Richard Biener wrote:
>>> On Fri, Sep 12, 2014 at 4:32 PM, Andi Kleen <andi@firstfloor.org> wrote:
>>> > From: Andi Kleen <ak@linux.intel.com>
>>> >
>>> > Test fentry and no_instrument_function overriding.
>>> >
>>> > No test cases for the LTO test for now, as the LTO
>>> > harness doesn't seem to support different flags for the final
>>> > link.
>>>
>>> Sure it does - via dg-extra-ld-options (you have to negate compile-time
>>> opts to "remove" them).
>>
>> Ok. I'll add test cases for that too then.
>>
>>>
>>> Are you sure the tests are target independent enough?  That is,
>>> 'mcount' is really 'mcount' on all targets?
>>
>> I'm not. I'll make them x86 only.
>>
>> Thanks,
>>
>> -Andi
>
> Tested on Linux/x86-64.  I checked in this to fix:
>
> https://gcc.gnu.org/ml/gcc-regression/2014-09/msg00084.html
>
> --
> H.J.
> ---
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 215300)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,7 @@
> +2014-09-16  H.J. Lu  <hongjiu.lu@intel.com>
> +
> + * gcc.dg/pg.c: Fix a typo.
> +
>  2014-09-16  Richard Biener  <rguenther@suse.de>
>
>   PR testsuite/63258
> Index: gcc.dg/pg.c
> ===================================================================
> --- gcc.dg/pg.c (revision 215300)
> +++ gcc.dg/pg.c (working copy)
> @@ -1,6 +1,6 @@
>  /* Test -fprofile override */
>  /* { dg-do compile } */
> -/* { dg-options "-fprofile" { target { { i686-*-* x86_64-*-* } } } } */
> +/* { dg-options "-fprofile" { target i?86-*-* x86_64-*-* } } */
>  /* { dg-final { scan-assembler-not "mcount" } } */
>  /* Origin: Andi Kleen */
>  extern void foobar(const char *);

Here is another one:

Index: ChangeLog
===================================================================
--- ChangeLog (revision 215303)
+++ ChangeLog (working copy)
@@ -1,5 +1,9 @@
 2014-09-16  H.J. Lu  <hongjiu.lu@intel.com>

+ * gcc.dg/pg-override.c: Fix a typo.
+
+2014-09-16  H.J. Lu  <hongjiu.lu@intel.com>
+
  * gcc.dg/pg.c: Fix a typo.

 2014-09-16  Richard Biener  <rguenther@suse.de>
Index: gcc.dg/pg-override.c
===================================================================
--- gcc.dg/pg-override.c (revision 215303)
+++ gcc.dg/pg-override.c (working copy)
@@ -1,6 +1,6 @@
 /* Test -fprofile override */
 /* { dg-do compile } */
-/* { dg-options "-fprofile" { target { { i686-*-* x86_64-*-* } } } } */
+/* { dg-options "-fprofile" { target i?86-*-* x86_64-*-* } } */
 /* { dg-final { scan-assembler-not "mcount" } } */
 /* Origin: Andi Kleen */
 extern void foobar(const char *);



-- 
H.J.