On Fri, Sep 17, 2021 at 10:32 AM Qing Zhao via Gcc-patches wrote: > > > > > On Sep 17, 2021, at 11:59 AM, Jakub Jelinek wrote: > > > > On Fri, Sep 17, 2021 at 04:55:22PM +0000, Qing Zhao wrote: > >> This is the patch to fix gcc.target/i386/auto-init-* tests. > >> > >> I have tested the change at X86_64-linux with > >> > >> make check-gcc RUNTESTFLAGS='--target_board=unix\{-m64,-m64/-march=skylake-avx512,-m64/-fstack-protector-all,-m64/-fstack-clash-protection,-m32/-mno-sse,-m32/-mtune=bonnell,-m32/-march=bonnell,-m32/-fstack-protector-all/-fstack-clash-protection\} i386.exp=auto-init*’ > >> > >> make check-gcc RUNTESTFLAGS='--target_board=unix\{-m64,-m64/-march=skylake-avx512/-fPIC,-m64/-fstack-protector-all/-fPIC,-m64/-fstack-clash-protection/-fPIC,-m32/-mno-sse/-fPIC,-m32/-mtune=bonnell/-fPIC,-m32/-march=bonnell/-fPIC,-m32/-fstack-protector-all/-fstack-clash-protection/-fPIC\} i386.exp=auto-init*’ > >> > >> Everything works fine. > >> > >> Okay for commit? > > > > LGTM. > > Thank you. > > I will commit the change soon. > > For the aarch64 tests, do you have a suggestion on what the option combination I should test? > Here is the followup patch to clean up these tests: 1. Replace ia32 with { ! lp64 } to enable ILP32 tests for -mx32. 2. Replace lp64 with { ! ia32 } to enable x86-64 ISA tests for -mx32. 3. For auto-init-3.c, add -msse and -mfpmath=387 for ia32. Any comments? -- H.J.