From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-361668-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 32330 invoked by alias); 12 Feb 2014 16:13:19 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 32190 invoked by uid 89); 12 Feb 2014 16:13:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-oa0-f50.google.com
Received: from mail-oa0-f50.google.com (HELO mail-oa0-f50.google.com) (209.85.219.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 12 Feb 2014 16:13:11 +0000
Received: by mail-oa0-f50.google.com with SMTP id n16so11295164oag.9        for <gcc-patches@gcc.gnu.org>; Wed, 12 Feb 2014 08:13:09 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.183.3.102 with SMTP id bv6mr37841954obd.18.1392221589255; Wed, 12 Feb 2014 08:13:09 -0800 (PST)
Received: by 10.76.3.114 with HTTP; Wed, 12 Feb 2014 08:13:09 -0800 (PST)
In-Reply-To: <CAFULd4Yy8BQ+ZX1D4y8XfNMWQxxocHQ156sE7UkEprA2H4=Vng@mail.gmail.com>
References: <20140211192802.GA26305@intel.com>	<yddeh39e8u4.fsf@CeBiTec.Uni-Bielefeld.DE>	<CAMe9rOqq2qZ8RYjCTXJ0tsbZ976EAJ0D_4+DGX-Z3FpkoqDzKg@mail.gmail.com>	<ydda9dxe6lv.fsf@CeBiTec.Uni-Bielefeld.DE>	<CAMe9rOq3p5iDiVX+49R3wM2CPYnybbYYPPfZ_GRnB-EQ+MFfkw@mail.gmail.com>	<CAFULd4Yy8BQ+ZX1D4y8XfNMWQxxocHQ156sE7UkEprA2H4=Vng@mail.gmail.com>
Date: Wed, 12 Feb 2014 16:13:00 -0000
Message-ID: <CAMe9rOpgSC2SfHhQK1wqUNWGmj6xitAAmCU2OTgPO0z3LnpjMg@mail.gmail.com>
Subject: Re: PATCH: PR target/60151: HAVE_AS_GOTOFF_IN_DATA is mis-detected on x86-64
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>, GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
X-SW-Source: 2014-02/txt/msg00797.txt.bz2

On Wed, Feb 12, 2014 at 12:20 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Tue, Feb 11, 2014 at 9:41 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>
>>>>>> HAVE_AS_GOTOFF_IN_DATA defines a 32-bit assembler feature, we need to
>>>>>> pass --32 to assembler. Otherwise, we get the wrong result on x86-64.
>>>>>> We already pass --32 to assembler on x86.  It should be OK to do it
>>>>>> in configure.  OK for trunk?
>>>>>
>>>>> This would break Solaris/x86 with as configurations, where this test
>>>>> currently passes, but would fail since as doesn't understand --32.
>>>>>
>>>>
>>>> How about passing --32 to as only for Linux?  OK to install?
>>>
>>> I'd rather do it for gas instead, which can be used on non-Linux
>>> systems, too.
>>>
>>
>> Sure.  Here is the new patch.  OK to install?
>
> Attached is slightly changed patch that follows established
> configure.ac code formatting. Please check if this version works for
> you.
>
> The patch is OK for mainline and release branches.
>

I checked it into trunk and will backport it later.

Thanks.

-- 
H.J.