From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id BAB773858D39 for ; Tue, 1 Mar 2022 22:49:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BAB773858D39 Received: by mail-ot1-x333.google.com with SMTP id g6-20020a9d6486000000b005acf9a0b644so57287otl.12 for ; Tue, 01 Mar 2022 14:49:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3KNUT1XJv1VhXjZLfTI3xxo8lmb5FgDM7dUNBUPcwPc=; b=ZUFH1/nL1eZ5RTwtrIFZVdQQxvhZi2QFE8eEPcsc4bTHc5TR4LL0NkJsUcKSnleTyz irMPkS8G19hTq6foowQC5kxRi9N0LEquoyjwIruQS4IaLGK3rg9u7lciW8eH18s0avdd KGaWs4Tc0scxHq0sOw7BIFs0jcUgQ0L9ufRz3TAJUKVcJ6K4SeoNy6AS0YUN1uvVFzJi bSGq/r6++uAA4BYUA3CX2AuMaRGLLg2xw4b/zCuEGllHOJKOySrk0zmCNm+Yja6Pu0BL G9QPaJ8pJaaNbIftU4POlMJa8ercHaCswk3E7V44RwwpQVbIwRIwxzjygro6VfzX927G gMXA== X-Gm-Message-State: AOAM532xfJk9eaxjN6byOPfwcexfo8ify1wlMfsoiYw9HdmznWRgaFK2 sIfkplBGj0HwrR5KOKZi06i5vdtimfTWg0R7YL8= X-Google-Smtp-Source: ABdhPJyOUQufV5AI/R7NGst77Sl7f9jTqwfDabeBq7u9hsRtJQapJGcoTZ1bQ2ptJb5d4YMOscP8NxiYFaAq8t4hE5U= X-Received: by 2002:a9d:69d8:0:b0:5ad:599:893d with SMTP id v24-20020a9d69d8000000b005ad0599893dmr13873161oto.249.1646174940023; Tue, 01 Mar 2022 14:49:00 -0800 (PST) MIME-Version: 1.0 References: <20220301020312.8827-1-hongtao.liu@intel.com> In-Reply-To: From: "H.J. Lu" Date: Tue, 1 Mar 2022 14:48:24 -0800 Message-ID: Subject: Re: [PATCH] [i386] Replace ix86_gen_scratch_sse_rtx with gen_reg_rtx. To: Hongtao Liu Cc: liuhongt , GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3026.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 22:49:02 -0000 On Tue, Mar 1, 2022 at 7:06 AM H.J. Lu wrote: > > On Mon, Feb 28, 2022 at 9:36 PM Hongtao Liu wrote: > > > > On Tue, Mar 1, 2022 at 10:39 AM H.J. Lu via Gcc-patches > > wrote: > > > > > > On Mon, Feb 28, 2022 at 6:26 PM H.J. Lu wrote: > > > > > > > > On Mon, Feb 28, 2022 at 6:03 PM liuhongt wrote: > > > > > > > > > > .. in ix86_expand_vector_move and > > > > > ix86_convert_const_wide_int_to_broadcast(called by the former). > > > > > > > > > > ix86_expand_vector_move is called by emit_move_insn which is used by > > > > > many pre_reload passes, ix86_gen_scratch_sse_rtx will break data flow > > > > > when there's explict usage of xmm7/xmm15/xmm31. > > > > > > > > > > Bootstrapped and regtested on x86_64-linux-gnu{-m32,} > > > > > for both w/and w/o --with-cpu=native --with-arch=native. > > > > > > > > > > Ok for trunk? > > > > > > > > > > gcc/ChangeLog: > > > > > > > > > > PR target/104704 > > > > > * config/i386/i386-expand.cc > > > > > (ix86_convert_const_wide_int_to_broadcast): Replace > > > > > ix86_gen_scratch_sse_rtx with gen_reg_rtx. > > > > > (ix86_expand_vector_move): Ditto. > > > > > * config/i386/sse.md (*vec_dupv4si): Add alternative $r and > > > > > corresponding splitter after it. > > > > > > > > > > gcc/testsuite/ChangeLog: > > > > > > > > > > * gcc.target/i386/incoming-11.c: Revert r12-2665-g7f4c3943f795fd. > > > > > * gcc.target/i386/pr100865-11b.c: Expect vmovdqa or vmovda64. > > > > > * gcc.target/i386/pr100865-12b.c: Ditto. > > > > > * gcc.target/i386/pr100865-8b.c: Ditto. > > > > > * gcc.target/i386/pr100865-9b.c: Ditto. > > > > > * gcc.target/i386/pr82941-1.c: Expect vzeroupper for ! ia32. > > > > > * gcc.target/i386/pr82942-1.c: Ditto. > > > > > * gcc.target/i386/pr82990-1.c: Ditto. > > > > > * gcc.target/i386/pr82990-3.c: Ditto. > > > > > * gcc.target/i386/pr82990-5.c: Ditto. > > > > > --- > > > > > gcc/config/i386/i386-expand.cc | 6 +-- > > > > > gcc/config/i386/sse.md | 41 +++++++++++++++----- > > > > > gcc/testsuite/gcc.target/i386/incoming-11.c | 2 +- > > > > > gcc/testsuite/gcc.target/i386/pr100865-11b.c | 2 +- > > > > > gcc/testsuite/gcc.target/i386/pr100865-12b.c | 2 +- > > > > > gcc/testsuite/gcc.target/i386/pr100865-8b.c | 2 +- > > > > > gcc/testsuite/gcc.target/i386/pr100865-9b.c | 2 +- > > > > > gcc/testsuite/gcc.target/i386/pr82941-1.c | 3 +- > > > > > gcc/testsuite/gcc.target/i386/pr82942-1.c | 3 +- > > > > > gcc/testsuite/gcc.target/i386/pr82990-1.c | 3 +- > > > > > gcc/testsuite/gcc.target/i386/pr82990-3.c | 3 +- > > > > > gcc/testsuite/gcc.target/i386/pr82990-5.c | 3 +- > > > > > 12 files changed, 45 insertions(+), 27 deletions(-) > > > > > > > > > > diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc > > > > > index faa0191c6dd..75a28cdd89d 100644 > > > > > --- a/gcc/config/i386/i386-expand.cc > > > > > +++ b/gcc/config/i386/i386-expand.cc > > > > > @@ -257,7 +257,7 @@ ix86_convert_const_wide_int_to_broadcast (machine_mode mode, rtx op) > > > > > machine_mode vector_mode; > > > > > if (!mode_for_vector (broadcast_mode, nunits).exists (&vector_mode)) > > > > > gcc_unreachable (); > > > > > - rtx target = ix86_gen_scratch_sse_rtx (vector_mode); > > > > > + rtx target = gen_reg_rtx (vector_mode); > > > > > > > > I think ix86_gen_scratch_sse_rtx should check > > > > currently_expanding_gimple_stmt == NULL > > > > to return gen_reg_rtx (vector_mode) instead. > > > > > > Like this: > > > > > > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > > > index b2bf90576d5..6c0e4929914 100644 > > > --- a/gcc/config/i386/i386.cc > > > +++ b/gcc/config/i386/i386.cc > > > @@ -23786,7 +23786,7 @@ ix86_optab_supported_p (int op, machine_mode > > > mode1, machine_mode, > > > rtx > > > ix86_gen_scratch_sse_rtx (machine_mode mode) > > > { > > > - if (TARGET_SSE && !lra_in_progress) > > > + if (TARGET_SSE && currently_expanding_gimple_stmt) > > > { > > > unsigned int regno; > > > if (TARGET_64BIT) > > > (END) > > Looks like it relies on PR104721. > > I have checked the fix for PR104721. > The proposed patch doesn't fix the testcase in: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104704 I am testing: https://gitlab.com/x86-gcc/gcc/-/merge_requests/28 -- H.J.