public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mikhail Maltsev <maltsevm@gmail.com>
Cc: Mike Stump <mikestump@comcast.net>, gcc-patches <gcc-patches@gnu.org>
Subject: Re: [PATCH] Fix partial template specialization syntax in wide-int.h
Date: Mon, 19 Oct 2015 19:41:00 -0000	[thread overview]
Message-ID: <CAMe9rOpo188Y-W-iE2GCwV4LKeCAA_aLi32he2gqvGusACssYA@mail.gmail.com> (raw)
In-Reply-To: <55ACA017.7000703@gmail.com>

On Mon, Jul 20, 2015 at 12:15 AM, Mikhail Maltsev <maltsevm@gmail.com> wrote:
> On 07/17/2015 07:46 PM, Mike Stump wrote:
>> On Jul 17, 2015, at 2:28 AM, Mikhail Maltsev <maltsevm@gmail.com> wrote:
>>> The following code (reduced from wide-int.h) is rejected by Intel C++
>>> Compiler (EDG-based):
>>
>> So, could you test this with the top of the tree compiler and file a bug
>> report against g++ for it, if it seems to not work right.  If that bug report
>> is rejected, then I’d say file a bug report against clang and EDG.
>
> In addition to usual bootstrap+regtest, I also checked that build succeeds with
> GCC 4.3.6 (IIRC, this is now the minimal required version) as well as with
> recent GCC snapshot used as stage 0. Committed as r225993.
> I also filed this bugreport: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66941
>
>>> I think that the warning is correct, and "template <>" should not be used
>>> here. The attached patch should fix this issue. Bootstrapped and regtested
>>> on x86_64-linux. OK for trunk?
>>
>> Ok.  Does this need to go into the gcc-5 release branch as well?  If so, ok
>> there too.  Thanks.
> I think there is no need for it.

It is also need for gcc-5. I am backporting it now.


-- 
H.J.

  reply	other threads:[~2015-10-19 19:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17  9:30 Mikhail Maltsev
2015-07-17 17:38 ` Mike Stump
2015-07-20  7:51   ` Mikhail Maltsev
2015-10-19 19:41     ` H.J. Lu [this message]
2015-10-19 19:48       ` H.J. Lu
2015-10-21 17:01         ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOpo188Y-W-iE2GCwV4LKeCAA_aLi32he2gqvGusACssYA@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=gcc-patches@gnu.org \
    --cc=maltsevm@gmail.com \
    --cc=mikestump@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).