public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Michael Matz <matz@suse.de>, Richard Biener <rguenther@suse.de>,
		GCC Patches <gcc-patches@gcc.gnu.org>,
	Jakub Jelinek <jakub@redhat.com>
Subject: Re: My patch for GCC 5 directory names
Date: Tue, 12 May 2015 16:13:00 -0000	[thread overview]
Message-ID: <CAMe9rOps_A-rw7muRUe0d=i0w-8pCsSvoG7hs8G83uXRUJ1O5w@mail.gmail.com> (raw)
In-Reply-To: <34590F66-7C07-4ED1-B74B-A751224E851F@gmail.com>

On Tue, May 12, 2015 at 9:09 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On May 12, 2015 5:58:07 PM GMT+02:00, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>>On Tue, May 12, 2015 at 8:28 AM, Michael Matz <matz@suse.de> wrote:
>>> Hi,
>>>
>>> On Tue, 12 May 2015, H.J. Lu wrote:
>>>
>>>> >> So we have
>>>> >>
>>>> >> experimental
>>>> >> release
>>>> >> post-release
>>>> >>
>>>> >> Why not just rename prerelease to post-release? That is a
>>one-line
>>>> >> change.
>>>> >
>>>> > Why print anything at all?  5.1.1 is after 5.1.0 in obvious ways.
>>>> >
>>>>
>>>> How can you tell GCC 5.1.1 on May 1, 2015 from GCC 5.1.1
>>>> on May 12, 2015?
>>>
>>> Via the svn revision.  But as the subject says, this patch is not so
>>much
>>
>>So? Doesn't post-release display the svn revision.for gcc -v, which
>>gcc -v doesn't display today? Something like this
>>
>>diff --git a/gcc/DEV-PHASE b/gcc/DEV-PHASE
>>index e69de29..ee176f8 100644
>>--- a/gcc/DEV-PHASE
>>+++ b/gcc/DEV-PHASE
>>@@ -0,0 +1 @@
>>+post-release
>
> Printing post-release doesn't add any information.  I believe Jakub fixed the missing svn revision printing already.
>

What is the real benefit of your patch?


-- 
H.J.

  reply	other threads:[~2015-05-12 16:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 13:49 Richard Biener
2015-05-12 13:54 ` H.J. Lu
2015-05-12 13:59   ` Richard Biener
2015-05-12 14:00     ` H.J. Lu
2015-05-12 14:03       ` Richard Biener
2015-05-12 14:50         ` H.J. Lu
2015-05-12 15:32           ` Michael Matz
2015-05-12 15:58             ` H.J. Lu
2015-05-12 16:11               ` Richard Biener
2015-05-12 16:13                 ` H.J. Lu [this message]
2015-05-12 16:34                   ` Richard Biener
2015-05-12 16:37                     ` H.J. Lu
2015-05-13  8:44                       ` Richard Biener
2015-05-13 10:16 ` Matthias Klose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOps_A-rw7muRUe0d=i0w-8pCsSvoG7hs8G83uXRUJ1O5w@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=matz@suse.de \
    --cc=rguenther@suse.de \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).