From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9728 invoked by alias); 2 Dec 2014 19:39:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9718 invoked by uid 89); 2 Dec 2014 19:39:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f51.google.com Received: from mail-oi0-f51.google.com (HELO mail-oi0-f51.google.com) (209.85.218.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 02 Dec 2014 19:39:32 +0000 Received: by mail-oi0-f51.google.com with SMTP id e131so9639664oig.10 for ; Tue, 02 Dec 2014 11:39:30 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.202.57.68 with SMTP id g65mr644965oia.74.1417549170457; Tue, 02 Dec 2014 11:39:30 -0800 (PST) Received: by 10.76.185.7 with HTTP; Tue, 2 Dec 2014 11:39:30 -0800 (PST) In-Reply-To: References: Date: Tue, 02 Dec 2014 19:39:00 -0000 Message-ID: Subject: Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations From: "H.J. Lu" To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" , Sriraman Tallam , Jakub Jelinek Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00196.txt.bz2 On Tue, Dec 2, 2014 at 11:19 AM, Uros Bizjak wrote: > Hello! > >> Ping. >>> Ping. >>>> Ping. >>>>> Ping. > > It would probably help reviewers if you pointed to actual path > submission [1], which unfortunately contains the explanation in the > patch itself [2], which further explains that this functionality is > currently only supported with gold, patched with [3]. > > [1] https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00645.html > [2] https://gcc.gnu.org/ml/gcc-patches/2014-09/txt2CHtu81P1O.txt > [3] https://sourceware.org/ml/binutils/2014-05/msg00092.html > > After a bit of the above detective work, I think that new gcc option > is not necessary. The configure should detect if new functionality is > supported in the linker, and auto-configure gcc to use it when > appropriate. > > I have also added a couple of linker experts in the CC. I don't think i386_binds_local_p is correct. What does it return for hidden external variable? I think it should be bool local = default_binds_local_p (exp); if (!local) local = ... return local; H.J.