From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by sourceware.org (Postfix) with ESMTPS id 93E9F3842400 for ; Fri, 10 Jul 2020 11:29:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 93E9F3842400 Received: by mail-il1-x144.google.com with SMTP id e18so4731100ilr.7 for ; Fri, 10 Jul 2020 04:29:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3DSF6j1oGltV343tehNq8j6/2L9joMiRrYjwudIZyCo=; b=QWRDkEtCQbvc6xozH4dLndgTNxGbF9ShDcHcaVIp8G/CQA4Zm9UW5M6XYyhnQKT4OZ gzbmXeDcSCVaND0lKMULomUJ64tM5Q1syCXt9LcmdBCbzdF5ZW20GeNohM4acEN/RKm3 dXmih6oF07dBD+LweBNUq51WuVu7by6I3oY5gjFAKFdlZXijeWoKIoT02Zl6QFru1s5r cy6WMEk/dQAt9nmPjmYlA93D/2QI/qX7vWyWg14gh7ptEC+8YpsM1Y9Nsauwrox5BC8+ bALQk/x8Holj2kBpZi6IpsVRJsEz8bCgFNCls/1xPJ7agY/7EXbIDqWPUb3V0ROL4cUn AhtQ== X-Gm-Message-State: AOAM530SeKm3f7VF1XEkkTilG81HiSSq9QjtYV+iw75/gUG63/omhU6k 9IL75RLyvTDKeMC+fEy5aVkcfgN469s1djzLzPU= X-Google-Smtp-Source: ABdhPJzDT8PmwUYfThd86MaWhld4j8tg6sp2/Kl1YwIjdXVG5Zl/8J4fZH71ObRmWMllfSQ8IFqx5Fv5tDuhH/SgAMc= X-Received: by 2002:a92:bf0c:: with SMTP id z12mr49723003ilh.151.1594380543103; Fri, 10 Jul 2020 04:29:03 -0700 (PDT) MIME-Version: 1.0 References: <20200628141906.418009-1-hjl.tools@gmail.com> <20200707155637.q77bz4zc5rzu3kvv@kyukhin> <20200709120449.qkx4o5yhhsd5ujpr@kyukhin> <20200710111854.GL2363@tucnak> In-Reply-To: <20200710111854.GL2363@tucnak> From: "H.J. Lu" Date: Fri, 10 Jul 2020 04:28:27 -0700 Message-ID: Subject: Re: [PATCH] x86: Check TARGET_AVX512VL when enabling FMA To: Jakub Jelinek Cc: Kirill Yukhin , GCC Patches Content-Type: multipart/mixed; boundary="000000000000e8c47005aa14a5ca" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 11:29:04 -0000 --000000000000e8c47005aa14a5ca Content-Type: text/plain; charset="UTF-8" On Fri, Jul 10, 2020 at 4:19 AM Jakub Jelinek wrote: > > On Thu, Jul 09, 2020 at 03:02:35PM -0700, H.J. Lu via Gcc-patches wrote: > --- a/gcc/config/i386/i386-expand.c > +++ b/gcc/config/i386/i386-expand.c > @@ -15540,7 +15540,11 @@ void ix86_emit_swsqrtsf (rtx res, rtx a, machine_mode mode, bool recip) > /* e0 = x0 * a */ > emit_insn (gen_rtx_SET (e0, gen_rtx_MULT (mode, x0, a))); > > - if (TARGET_FMA || TARGET_AVX512F) > + unsigned vector_size = GET_MODE_SIZE (mode); > + if (TARGET_FMA > + || (TARGET_AVX512F && vector_size == 64) > + || (TARGET_AVX512VL && (vector_size == 32 || vector_size == 16))) > + > emit_insn (gen_rtx_SET (e2, > > Why the empty line in there? > Ok for trunk with that fixed. > > gen_rtx_FMA (mode, e0, x0, mthree))); > else This is the patch I am checking in. Thanks. -- H.J. --000000000000e8c47005aa14a5ca Content-Type: text/x-patch; charset="US-ASCII"; name="0001-x86-Check-TARGET_AVX512VL-when-enabling-FMA.patch" Content-Disposition: attachment; filename="0001-x86-Check-TARGET_AVX512VL-when-enabling-FMA.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kcg4z2ih0 RnJvbSAyYmNkMjFiOTE0MmNkZjc1ZmMxNjZhNzMyMDY1MThiODc1NGY1YjZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFRodSwgOSBKdWwgMjAyMCAxNDo1Njo0OCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHg4NjogQ2hl Y2sgVEFSR0VUX0FWWDUxMlZMIHdoZW4gZW5hYmxpbmcgRk1BCgpDaGVjayBUQVJHRVRfQVZYNTEy Vkwgd2hlbiBlbmFibGluZyBGTUEgdG8gYXZvaWQKCmdjYy50YXJnZXQvaTM4Ni9hdng1MTJlci12 cnNxcnQyOHBzLTMuYzoyNToxOiBlcnJvcjogdW5yZWNvZ25pemFibGUgaW5zbjoKKGluc24gMjkg MjggMzAgNiAoc2V0IChyZWc6VjhTRiAxMDgpCiAgICAgICAgKGZtYTpWOFNGIChyZWc6VjhTRiAx MDYpCiAgICAgICAgICAgIChyZWc6VjhTRiAxMDUpCiAgICAgICAgICAgIChyZWc6VjhTRiAxMTAp KSkKCndoZW4gVEFSR0VUX0FWWDUxMlZMIGlzbid0IGVuYWJsZWQuCgoJUFIgdGFyZ2V0Lzk2MTQ0 CgkqIGNvbmZpZy9pMzg2L2kzODYtZXhwYW5kLmMgKGl4ODZfZW1pdF9zd3NxcnRzZik6IENoZWNr CglUQVJHRVRfQVZYNTEyVkwgd2hlbiBlbmFibGluZyBGTUEuCi0tLQogZ2NjL2NvbmZpZy9pMzg2 L2kzODYtZXhwYW5kLmMgfCA1ICsrKystCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9pMzg2L2kzODYtZXhwYW5k LmMgYi9nY2MvY29uZmlnL2kzODYvaTM4Ni1leHBhbmQuYwppbmRleCA0OTcxOGI3YTQxYy4uZTE5 NDIxNDgwNGIgMTAwNjQ0Ci0tLSBhL2djYy9jb25maWcvaTM4Ni9pMzg2LWV4cGFuZC5jCisrKyBi L2djYy9jb25maWcvaTM4Ni9pMzg2LWV4cGFuZC5jCkBAIC0xNTU0MCw3ICsxNTU0MCwxMCBAQCB2 b2lkIGl4ODZfZW1pdF9zd3NxcnRzZiAocnR4IHJlcywgcnR4IGEsIG1hY2hpbmVfbW9kZSBtb2Rl LCBib29sIHJlY2lwKQogICAvKiBlMCA9IHgwICogYSAqLwogICBlbWl0X2luc24gKGdlbl9ydHhf U0VUIChlMCwgZ2VuX3J0eF9NVUxUIChtb2RlLCB4MCwgYSkpKTsKIAotICBpZiAoVEFSR0VUX0ZN QSB8fCBUQVJHRVRfQVZYNTEyRikKKyAgdW5zaWduZWQgdmVjdG9yX3NpemUgPSBHRVRfTU9ERV9T SVpFIChtb2RlKTsKKyAgaWYgKFRBUkdFVF9GTUEKKyAgICAgIHx8IChUQVJHRVRfQVZYNTEyRiAm JiB2ZWN0b3Jfc2l6ZSA9PSA2NCkKKyAgICAgIHx8IChUQVJHRVRfQVZYNTEyVkwgJiYgKHZlY3Rv cl9zaXplID09IDMyIHx8IHZlY3Rvcl9zaXplID09IDE2KSkpCiAgICAgZW1pdF9pbnNuIChnZW5f cnR4X1NFVCAoZTIsCiAJCQkgICAgZ2VuX3J0eF9GTUEgKG1vZGUsIGUwLCB4MCwgbXRocmVlKSkp OwogICBlbHNlCi0tIAoyLjI2LjIKCg== --000000000000e8c47005aa14a5ca--