public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Richard Biener <rguenther@suse.de>
Cc: Jakub Jelinek <jakub@redhat.com>,
	Ilya Enkovich <enkovich.gnu@gmail.com>,
		GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix a -fcheck-pointer-bounds -mmpx ICE (PR target/65523)
Date: Thu, 23 Apr 2015 18:12:00 -0000	[thread overview]
Message-ID: <CAMe9rOq-4VWmOkh59OZqiryG2s8p6LHEE2=K+Eg8W0MPEfgMfw@mail.gmail.com> (raw)
In-Reply-To: <2ADA2E1B-9037-4444-8D8F-B9BAB3AE63A5@suse.de>

On Mon, Mar 23, 2015 at 1:01 PM, Richard Biener <rguenther@suse.de> wrote:
> On March 23, 2015 8:54:54 PM GMT+01:00, Jakub Jelinek <jakub@redhat.com> wrote:
>>Hi!
>>
>>On the following testcase we ICE, because we don't verify we have the
>>ERF_RETURNS_ARG argument, on non-verified builtins that is possible.
>>Other uses of ERF_RETURNS_ARG seem to verify it.
>>Also, there was an unneeded extra gimple_call_return_flags call,
>>the condition has already checked that ERF_RETURNS_ARG flag is set.
>>
>>Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> OK.
>
> Thanks,
> Richard.
>
>>2015-03-23  Jakub Jelinek  <jakub@redhat.com>
>>
>>       PR target/65523
>>       * tree-chkp.c (chkp_build_returned_bound): Ignore
>>       ERF_RETURNS_ARG calls if they have fewer than needed arguments.
>>
>>       * gcc.target/i386/pr65523.c: New test.
>>

MPX doesn't support x32.  I checked in this patch to skip it
for x32.

-- 
H.J.
---
Index: ChangeLog
===================================================================
--- ChangeLog (revision 222381)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2015-04-23  H.J. Lu  <hongjiu.lu@intel.com>
+
+ * gcc.target/i386/pr65523.c: Skip x32.
+
 2015-04-23  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

  * gcc.target/arm/neon/pr51534.c: Update vcg* scan-assembly patterns
Index: gcc.target/i386/pr65523.c
===================================================================
--- gcc.target/i386/pr65523.c (revision 222381)
+++ gcc.target/i386/pr65523.c (working copy)
@@ -1,5 +1,5 @@
 /* PR target/65523 */
-/* { dg-do compile } */
+/* { dg-do compile { target { ! x32 } } } */
 /* { dg-options "-fcheck-pointer-bounds -mmpx" } */

 void *memmove ();

      reply	other threads:[~2015-04-23 18:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 19:55 Jakub Jelinek
2015-03-23 20:01 ` Richard Biener
2015-04-23 18:12   ` H.J. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOq-4VWmOkh59OZqiryG2s8p6LHEE2=K+Eg8W0MPEfgMfw@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=enkovich.gnu@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).