From: "H.J. Lu" <hjl.tools@gmail.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: XFAIL a couple of gnat.dg testcases on MIPS
Date: Wed, 13 Nov 2013 23:25:00 -0000 [thread overview]
Message-ID: <CAMe9rOq0=pt4WDm9tuqtJp9OOekCOSXp7oJ-WkyZGzN6RduzNA@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOr1GYunCpp+iZPEvrUE=ZwhHCL=jKnfPei4P8MAVZ8bSQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Wed, Nov 13, 2013 at 12:27 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Oct 21, 2012 at 1:26 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> They are reported as failing with the n32 ABI, but the failures are spurious.
>>
>> Tested on mips64el-linux-gnu, applied on the mainline and 4.7 branch.
>>
>>
>> 2012-10-21 Eric Botcazou <ebotcazou@adacore.com>
>>
>> * gnat.dg/specs/atomic1.ads: XFAIL on MIPS.
>> * gnat.dg/specs/addr1.ads: Likewise.
>>
>
> They are also failing on x32, which similar to n32:
>
> FAIL: gnat.dg/specs/addr1.ads (test for bogus messages, line 24)
> FAIL: gnat.dg/specs/atomic1.ads (test for errors, line 9)
> FAIL: gnat.dg/specs/atomic1.ads (test for errors, line 13)
>
Here is a patch. OK to install?
Thanks.
--
H.J.
[-- Attachment #2: 0001-XAIL-addr1.ads-and-atomic1.ads-on-x32.patch --]
[-- Type: text/x-patch, Size: 1552 bytes --]
2013-11-13 H.J. Lu <hongjiu.lu@intel.com>
* gnat.dg/specs/addr1.ads: XFAIL on x32.
* gnat.dg/specs/atomic1.ads: Likewise.
diff --git a/gcc/testsuite/gnat.dg/specs/addr1.ads b/gcc/testsuite/gnat.dg/specs/addr1.ads
index bcb833b..b357115 100644
--- a/gcc/testsuite/gnat.dg/specs/addr1.ads
+++ b/gcc/testsuite/gnat.dg/specs/addr1.ads
@@ -21,7 +21,7 @@ package Addr1 is
for Obj1'Address use A'Address; -- { dg-bogus "(alignment|erroneous)" }
Obj2: Rec2;
- for Obj2'Address use A'Address; -- { dg-bogus "(alignment|erroneous)" "" { xfail mips*-*-* } }
+ for Obj2'Address use A'Address; -- { dg-bogus "(alignment|erroneous)" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* } && x32 } } }
Obj3: Rec1;
for Obj3'Address use A(1)'Address; -- { dg-bogus "(alignment|erroneous)" }
diff --git a/gcc/testsuite/gnat.dg/specs/atomic1.ads b/gcc/testsuite/gnat.dg/specs/atomic1.ads
index 02e98b6..2994f2a 100644
--- a/gcc/testsuite/gnat.dg/specs/atomic1.ads
+++ b/gcc/testsuite/gnat.dg/specs/atomic1.ads
@@ -6,11 +6,11 @@ package Atomic1 is
type UA is access all Arr;
U : UA;
- pragma Atomic (U); -- { dg-error "atomic access" "" { xfail mips*-*-* } }
+ pragma Atomic (U); -- { dg-error "atomic access" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* } && x32 } } }
type R is record
U : UA;
- pragma Atomic (U); -- { dg-error "atomic access" "" { xfail mips*-*-* } }
+ pragma Atomic (U); -- { dg-error "atomic access" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* } && x32 } } }
end record;
end Atomic1;
--
1.8.3.1
next prev parent reply other threads:[~2013-11-13 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-21 21:07 Eric Botcazou
2013-11-13 22:43 ` H.J. Lu
2013-11-13 23:25 ` H.J. Lu [this message]
2013-11-14 14:10 ` Eric Botcazou
2013-11-15 3:55 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOq0=pt4WDm9tuqtJp9OOekCOSXp7oJ-WkyZGzN6RduzNA@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).