From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com
 [IPv6:2607:f8b0:4864:20::431])
 by sourceware.org (Postfix) with ESMTPS id 73E133858036
 for <gcc-patches@gcc.gnu.org>; Sat, 26 Mar 2022 01:22:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 73E133858036
Received: by mail-pf1-x431.google.com with SMTP id s11so7918828pfu.13
 for <gcc-patches@gcc.gnu.org>; Fri, 25 Mar 2022 18:22:37 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=kq2iQZvK1KYa8cBGpv0xeNpV2aZ+5EYU6cep49ghK08=;
 b=Ovba+IW5Fi3ue+ZM1EKSRs1fMurwX2ikqJ5nfzKXIZNbmIEM0832WDxLgj89qenL+2
 7QZxSb8ASzMa+LMbDrHZq+bi5Xy3ibs/DiTGMoR7uBx7386VLoz/gOofZDYe19SxGxL5
 +bowbWlIJTs+nNJHj0rl7n+8DExI8jsbrME2PKRQr6ApXzKUKtDHTShsDASk+SCsfi7O
 jrOcE5VUMAyI3VoVwZTa43GH/anAIRB5tNsd0iA6igzKGAwsrX1xw6SS9Ey2hunb7ThP
 2F+nHNuLdkXo2vqT6Sx4kex1X4bpE8oOFhDJIWR+/Vs5a3ubgS3rXVJPfP5UHYo58iuB
 h4jg==
X-Gm-Message-State: AOAM533Ffev635+l0+UrE2ZxQBa04W/XiGYGAc8Dy1PbgZO2hr0+TJ06
 7NDD8YJyyQ5NzLK3jxfcQwdlAuaEaDmGVmfGEFY=
X-Google-Smtp-Source: ABdhPJxajo63I4Y2eXZ7viImFCEnkYlunepsXoC1oxOEVf3bhfh/qd3CQW8wDXys6cPbJC5/5efgoJyO2FTE529rPys=
X-Received: by 2002:a63:3e47:0:b0:382:366:64ea with SMTP id
 l68-20020a633e47000000b00382036664eamr1754204pga.210.1648257756419; Fri, 25
 Mar 2022 18:22:36 -0700 (PDT)
MIME-Version: 1.0
References: <20220325205014.32895-1-hjl.tools@gmail.com>
 <CA+OydWmhz+rEXjRjDPVTko6_wr2rHwLHoy362ZmiTqJDJzVS7Q@mail.gmail.com>
In-Reply-To: <CA+OydWmhz+rEXjRjDPVTko6_wr2rHwLHoy362ZmiTqJDJzVS7Q@mail.gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Fri, 25 Mar 2022 18:22:00 -0700
Message-ID: <CAMe9rOq=Fi1D6hp3LxL6hx+fjSD3vavoQrtovVfjcHOqBd3BcA@mail.gmail.com>
Subject: Re: [PATCH] x86: Use x constraint on KL patterns
To: Hongyu Wang <wwwhhhyyy333@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, liuhongt <hongtao.liu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00, BODY_8BITS,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM,
 GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Mar 2022 01:22:39 -0000

On Fri, Mar 25, 2022 at 6:08 PM Hongyu Wang <wwwhhhyyy333@gmail.com> wrote:
>
> Is it possible to create a test case that gas would throw an error for
> invalid operands?

You can use -ffix-xmmN to disable XMM0-15.

> H.J. Lu via Gcc-patches <gcc-patches@gcc.gnu.org> =E4=BA=8E2022=E5=B9=B43=
=E6=9C=8826=E6=97=A5=E5=91=A8=E5=85=AD 04:50=E5=86=99=E9=81=93=EF=BC=9A
> >
> > Since KL instructions have no AVX512 version, replace the "v" register
> > constraint with the "x" register constraint.
> >
> >         PR target/105058
> >         * config/i386/sse.md (loadiwkey): Replace "v" with "x".
> >         (aes<aesklvariant>u8): Likewise.
> > ---
> >  gcc/config/i386/sse.md | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
> > index 29802d00ce6..33bd2c4768a 100644
> > --- a/gcc/config/i386/sse.md
> > +++ b/gcc/config/i386/sse.md
> > @@ -28364,8 +28364,8 @@ (define_insn "avx512f_dpbf16ps_<mode>_mask"
> >
> >  ;; KEYLOCKER
> >  (define_insn "loadiwkey"
> > -  [(unspec_volatile:V2DI [(match_operand:V2DI 0 "register_operand" "v"=
)
> > -                         (match_operand:V2DI 1 "register_operand" "v")
> > +  [(unspec_volatile:V2DI [(match_operand:V2DI 0 "register_operand" "x"=
)
> > +                         (match_operand:V2DI 1 "register_operand" "x")
> >                           (match_operand:V2DI 2 "register_operand" "Yz"=
)
> >                           (match_operand:SI   3 "register_operand" "a")=
]
> >                          UNSPECV_LOADIWKEY)
> > @@ -28498,7 +28498,7 @@ (define_int_attr aesklvariant
> >     (UNSPECV_AESENC256KLU8 "enc256kl")])
> >
> >  (define_insn "aes<aesklvariant>u8"
> > -  [(set (match_operand:V2DI 0 "register_operand" "=3Dv")
> > +  [(set (match_operand:V2DI 0 "register_operand" "=3Dx")
> >         (unspec_volatile:V2DI [(match_operand:V2DI 1 "register_operand"=
 "0")
> >                                (match_operand:BLK   2 "memory_operand" =
"m")]
> >                               AESDECENCKL))
> > --
> > 2.35.1
> >



--=20
H.J.