From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jack Howarth <howarth.at.gcc@gmail.com>
Cc: Ian Lance Taylor <ian@airs.com>, Jakub Jelinek <jakub@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Uros Bizjak <ubizjak@gmail.com>,
Iain Sandoe <iain@codesourcery.com>,
Mike Stump <mikestump@comcast.net>
Subject: Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE
Date: Tue, 31 Mar 2015 17:00:00 -0000 [thread overview]
Message-ID: <CAMe9rOqAjsLAr+iVspN5XBdnaVtW_AJuMyOb3K6mVRKKh-sQXg@mail.gmail.com> (raw)
In-Reply-To: <CAJMcOU8xHsE6ZyVSHy90AUgkSpY8FfG53xT+jGO=TALo27ViSA@mail.gmail.com>
On Tue, Mar 31, 2015 at 9:39 AM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
> On Tue, Mar 31, 2015 at 12:14 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Mar 31, 2015 at 9:09 AM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
>>> H.J.,
>>> Did you attach the correct version of the patch? I don't see
>>> anything conditional on linux.
>>> Jack
>>
>> My patch will build and install libgcc_nonshared.a for all targets. If you
>> don't link against it, nothing is changed. On Linux, it is used via the
>> init_spec change.
>
> Isn't...
>
> diff --git a/gcc/gcc.c b/gcc/gcc.c
> index d956c36..3fbd549 100644
> --- a/gcc/gcc.c
> +++ b/gcc/gcc.c
> @@ -1566,6 +1566,7 @@ init_spec (void)
> if (in_sep && *p == '-' && strncmp (p, "-lgcc", 5) == 0)
> {
> init_gcc_specs (&obstack,
> + "-lgcc_nonshared "
> "-lgcc_s"
> #ifdef USE_LIBUNWIND_EXCEPTIONS
> " -lunwind"
> @@ -1591,6 +1592,7 @@ init_spec (void)
> /* Ug. We don't know shared library extensions. Hope that
> systems that use this form don't do shared libraries. */
> init_gcc_specs (&obstack,
> + "libgcc_nonshared.a%s "
> "-lgcc_s",
> "libgcc.a%s",
> "libgcc_eh.a%s"
>
> problematic for Solaris? I am unfamiliar with the Solaris spec
> handling but sol2.h doesn't seem to have any instances of -lgcc which
> might imply they use the stock compiler invocation which will now have
> a non-existent libgcc_nonshared static library.
libgcc_nonshared.a is built and installed for all targets.
> Also, are you leaving the cpu symbols in libgcc.a on non-linux
> targets? If not, the linkage failure reported in
> https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01668.html will occur,
> no?
My current patch doesn't change what are in libgcc.a. It
adds libgcc_nonshared.a for all targets, which contains
the same cpuinfo.o as in libgcc.a or a dummy .o if libgcc.a
doesn't have cpuinfo.o.
--
H.J.
next prev parent reply other threads:[~2015-03-31 17:00 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 2:25 H.J. Lu
2015-03-30 2:34 ` H.J. Lu
2015-03-30 2:40 ` H.J. Lu
2015-03-30 22:26 ` H.J. Lu
2015-03-31 0:54 ` Jack Howarth
2015-03-31 2:08 ` H.J. Lu
2015-03-31 2:42 ` H.J. Lu
2015-03-31 3:14 ` Jack Howarth
2015-03-31 3:09 ` Jack Howarth
2015-03-31 4:04 ` H.J. Lu
2015-03-31 5:39 ` Jakub Jelinek
2015-03-31 6:20 ` Rainer Orth
2015-03-31 10:39 ` H.J. Lu
2015-03-31 14:25 ` Jack Howarth
2015-03-31 15:58 ` H.J. Lu
2015-03-31 16:10 ` Jack Howarth
2015-03-31 16:15 ` H.J. Lu
2015-03-31 16:39 ` Jack Howarth
2015-03-31 17:00 ` H.J. Lu [this message]
2015-03-31 18:33 ` Jack Howarth
2015-04-14 15:07 ` H.J. Lu
2015-04-16 16:29 ` Mike Stump
2015-04-17 8:05 ` Uros Bizjak
2015-04-17 10:36 ` H.J. Lu
2015-04-17 11:04 ` Uros Bizjak
2015-04-17 11:12 ` Uros Bizjak
2015-04-17 11:38 ` Jakub Jelinek
2015-04-17 11:48 ` H.J. Lu
2015-04-17 12:00 ` Jakub Jelinek
2015-04-17 12:36 ` H.J. Lu
2015-04-17 12:40 ` Jakub Jelinek
2015-05-08 23:00 ` Rich Felker
2015-05-08 23:59 ` H.J. Lu
2015-05-09 14:31 ` Szabolcs Nagy
2015-05-09 17:41 ` H.J. Lu
2015-05-09 18:57 ` Szabolcs Nagy
2015-05-11 10:20 ` Szabolcs Nagy
2015-05-11 10:32 ` Jakub Jelinek
2015-05-11 12:39 ` Szabolcs Nagy
2015-05-11 13:05 ` Jakub Jelinek
2015-05-11 15:30 ` Szabolcs Nagy
2015-05-11 14:12 ` Rich Felker
2015-05-09 19:36 ` Rich Felker
2015-05-09 19:54 ` Jakub Jelinek
2015-07-22 21:14 ` Sriraman Tallam
2015-04-17 12:23 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOqAjsLAr+iVspN5XBdnaVtW_AJuMyOb3K6mVRKKh-sQXg@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=howarth.at.gcc@gmail.com \
--cc=iain@codesourcery.com \
--cc=ian@airs.com \
--cc=jakub@redhat.com \
--cc=mikestump@comcast.net \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).