From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20122 invoked by alias); 25 Jun 2015 11:37:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20112 invoked by uid 89); 25 Jun 2015 11:37:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f47.google.com Received: from mail-oi0-f47.google.com (HELO mail-oi0-f47.google.com) (209.85.218.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 25 Jun 2015 11:37:31 +0000 Received: by oiax193 with SMTP id x193so50264074oia.2 for ; Thu, 25 Jun 2015 04:37:29 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.225.65 with SMTP id y62mr36530913oig.78.1435232249159; Thu, 25 Jun 2015 04:37:29 -0700 (PDT) Received: by 10.76.160.68 with HTTP; Thu, 25 Jun 2015 04:37:29 -0700 (PDT) Date: Thu, 25 Jun 2015 11:40:00 -0000 Message-ID: Subject: [PATCH] Use PIE_SPEC/NO_PIE_SPEC for crtend.o/crtendS.o From: "H.J. Lu" To: Rainer Orth Cc: Joseph Myers , Magnus Granberg , GCC Patches Content-Type: multipart/mixed; boundary=001a113d469461ffd70519560c77 X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01782.txt.bz2 --001a113d469461ffd70519560c77 Content-Type: text/plain; charset=UTF-8 Content-length: 1703 On Wed, Jun 10, 2015 at 6:20 AM, Rainer Orth wrote: > "H.J. Lu" writes: > >> On Tue, May 19, 2015 at 8:33 AM, Joseph Myers wrote: >>> On Tue, 19 May 2015, H.J. Lu wrote: >>> >>>> > I think the whole thing should be posted as one patch, with both the >>>> > target-independent changes and the target-specific changes for all >>>> > targets. >>>> > >>>> >>>> That is what makes me concerned. I have some simple target-specified >>>> patches which weren't reviewed for years. What will happen if no one >>> >>> For any unreviewed patch, keep pinging weekly. >>> >>>> reviews some simple target-specified changes due to >>>> >>>> 1. Reviewers don't have access to those targets. >>>> 2. Target maintainers aren't review them. >>>> 3. There are no clear maintainers for those targets. >>> >>> I've already said in >>> that, given >>> target maintainers CC:ed, I might be inclined to approve the patch on the >>> basis of allowing them a week to test their target changes. >>> >> >> Here is the complete patch. Tested on Linux/x86-64. It is also >> available on hjl/pie/master branch in git mirror. > > I just noticed that with --enable-default-pie, while crtbeginS.o is > linked into the executable, crtend.o is used, while with an explicit > -pie, crtendS.o is taken. Shouldn't GNU_USER_TARGET_ENDFILE_SPEC have > the same treatment as GNU_USER_TARGET_STARTFILE_SPEC already did? > > * config/gnu-user.h (GNU_USER_TARGET_STARTFILE_SPEC): Use > PIE_SPEC and NO_PIE_SPEC if HAVE_LD_PIE is defined. > Here is a patch. OK for trunk? Thanks. -- H.J. --001a113d469461ffd70519560c77 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Use-PIE_SPEC-NO_PIE_SPEC-for-crtend.o-crtendS.o.patch" Content-Disposition: attachment; filename="0001-Use-PIE_SPEC-NO_PIE_SPEC-for-crtend.o-crtendS.o.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ibc4758e0 Content-length: 1989 RnJvbSA1MGJlYmY1MzExOTNjMThlZmIwOTgyYWMxMTk2OTRhYTlmNjUwZTQ0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhq bC50b29sc0BnbWFpbC5jb20+CkRhdGU6IFRodSwgMjUgSnVuIDIwMTUgMDM6 MDQ6NTYgLTA3MDAKU3ViamVjdDogW1BBVENIIDEvMl0gVXNlIFBJRV9TUEVD L05PX1BJRV9TUEVDIGZvciBjcnRlbmQuby9jcnRlbmRTLm8KCldlIG5lZWQg dG8gbGluayB3aXRoIGNydGVuZC5vIGFuZCBjcnRlbmRTLm8gcHJvcGVybHkg Zm9yIEdDQyBjb25maWd1cmVkCnRvIGdlbmVyYXRlIFBJRSBieSBkZWZhdWx0 LgoKCSogY29uZmlnL2dudS11c2VyLmggKEdOVV9VU0VSX1RBUkdFVF9FTkRG SUxFX1NQRUMpOiBVc2UKCVBJRV9TUEVDIGFuZCBOT19QSUVfU1BFQyBpZiBI QVZFX0xEX1BJRSBpcyBkZWZpbmVkLgotLS0KIGdjYy9jb25maWcvZ251LXVz ZXIuaCB8IDkgKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRp b25zKCspCgpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9nbnUtdXNlci5oIGIv Z2NjL2NvbmZpZy9nbnUtdXNlci5oCmluZGV4IDJmY2I1NWQuLjViMzU3NmIg MTAwNjQ0Ci0tLSBhL2djYy9jb25maWcvZ251LXVzZXIuaAorKysgYi9nY2Mv Y29uZmlnL2dudS11c2VyLmgKQEAgLTY3LDExICs2NywyMCBAQCBzZWUgdGhl IGZpbGVzIENPUFlJTkczIGFuZCBDT1BZSU5HLlJVTlRJTUUgcmVzcGVjdGl2 ZWx5LiAgSWYgbm90LCBzZWUKICAgIG9iamVjdCBjb25zdHJ1Y3RlZCBiZWZv cmUgZW50ZXJpbmcgYG1haW4nLCBmb2xsb3dlZCBieSBhIG5vcm1hbAogICAg R05VIHVzZXJzcGFjZSAiZmluYWxpemVyIiBmaWxlLCBgY3J0bi5vJy4gICov CiAKKyNpZiBkZWZpbmVkIEhBVkVfTERfUElFCisjZGVmaW5lIEdOVV9VU0VS X1RBUkdFVF9FTkRGSUxFX1NQRUMgXAorICAiJXtmdnRhYmxlLXZlcmlmeT1u b25lOiVzOyBcCisgICAgIGZ2dGFibGUtdmVyaWZ5PXByZWluaXQ6dnR2X2Vu ZF9wcmVpbml0Lm8lczsgXAorICAgICBmdnRhYmxlLXZlcmlmeT1zdGQ6dnR2 X2VuZC5vJXN9IFwKKyAgICV7c2hhcmVkOmNydGVuZFMubyVzOzogJXsiIFBJ RV9TUEVDICI6Y3J0ZW5kUy5vJXN9IFwKKyAgICV7IiBOT19QSUVfU1BFQyAi OmNydGVuZC5vJXN9fSBjcnRuLm8lcyIKKyNlbHNlCiAjZGVmaW5lIEdOVV9V U0VSX1RBUkdFVF9FTkRGSUxFX1NQRUMgXAogICAiJXtmdnRhYmxlLXZlcmlm eT1ub25lOiVzOyBcCiAgICAgIGZ2dGFibGUtdmVyaWZ5PXByZWluaXQ6dnR2 X2VuZF9wcmVpbml0Lm8lczsgXAogICAgICBmdnRhYmxlLXZlcmlmeT1zdGQ6 dnR2X2VuZC5vJXN9IFwKICAgICV7c2hhcmVkfHBpZTpjcnRlbmRTLm8lczs6 Y3J0ZW5kLm8lc30gY3J0bi5vJXMiCisjZW5kaWYKICN1bmRlZiAgRU5ERklM RV9TUEVDCiAjZGVmaW5lIEVOREZJTEVfU1BFQyBHTlVfVVNFUl9UQVJHRVRf RU5ERklMRV9TUEVDCiAKLS0gCjIuMS4wCgo= --001a113d469461ffd70519560c77--