From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id B8F7439A0846 for ; Fri, 16 Jul 2021 02:21:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8F7439A0846 Received: by mail-pg1-x531.google.com with SMTP id y4so8504856pgl.10 for ; Thu, 15 Jul 2021 19:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WYUiA1zMUugNm+MgrbyWvs3uRh7w7e7GXihq1m2/diY=; b=XNZnCEi7L6XSXIkmok8wYE3i+HkjXdfua9MhxRFpDDXO4hTJOj7qbhOewTSO27HBpl Z/nDZFqCxaYzl68bCUMRfDiBKvCDIycows276BMG8PG7k5mldkYgGMq0mk6IMYevQAU3 YtXNtO29OLIRUxQSSOw8LH1SnENmKJw9auawpP71WkJ+XkuSGpfvybhkdh3q2yfQxn3a Awpza+RqAmH5rNfZJSk/XwXTtxpikpZSnZZMycOLHMh2LWDmcsa7DH8Fx4GF9ljDimID oSAxtf9ajZaGPQdAu4YYBFT7lDBTOomeiyLdkCDG5ExRwAuuygnmgwUWj5vzqUu4r1PL pb4A== X-Gm-Message-State: AOAM533fSDMiy+2cQkIqjTZXvJeF2edx/Woyn0iCk2lnVvbcLN1TTPGs MHdqpayarhfEMGChC7AUpqRFxfPIKK2OSm56QVs= X-Google-Smtp-Source: ABdhPJxrRjyf4Ac6EqnzXRYPrqnmfq34gLn7vm2XBEwg/K5Oj5ybORP1+vH9BXOhiX8YEk1WzpIt7Z2yK/ws24KLGI0= X-Received: by 2002:a63:5b02:: with SMTP id p2mr7486056pgb.161.1626402095742; Thu, 15 Jul 2021 19:21:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "H.J. Lu" Date: Thu, 15 Jul 2021 19:20:59 -0700 Message-ID: Subject: Re: [PATCH 1/4][committed] testsuite: Fix testisms in scalar tests PR101457 To: Tamar Christina Cc: GCC Patches , Richard Sandiford , nd Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_LOTSOFHASH, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2021 02:21:38 -0000 On Thu, Jul 15, 2021 at 9:40 AM Tamar Christina via Gcc-patches wrote: > > Hi All, > > These testcases accidentally contain the wrong signs for the expected values > for the scalar code. The vector code however is correct. > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > Committed as a trivial fix. > > Thanks, > Tamar > > gcc/testsuite/ChangeLog: > > PR middle-end/101457 > * gcc.dg/vect/vect-reduc-dot-17.c: Fix signs of scalar code. > * gcc.dg/vect/vect-reduc-dot-18.c: Likewise. > * gcc.dg/vect/vect-reduc-dot-22.c: Likewise. > * gcc.dg/vect/vect-reduc-dot-9.c: Likewise. > > --- inline copy of patch -- > diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-17.c b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-17.c > index aa269c4d657f65e07e36df7f3fd0098cf3aaf4d0..38f86fe458adcc7ebbbae22f5cc1e720928f2d48 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-17.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-17.c > @@ -35,8 +35,9 @@ main (void) > { > check_vect (); > > - SIGNEDNESS_3 char a[N], b[N]; > - int expected = 0x12345; > + SIGNEDNESS_3 char a[N]; > + SIGNEDNESS_4 char b[N]; > + SIGNEDNESS_1 int expected = 0x12345; > for (int i = 0; i < N; ++i) > { > a[i] = BASE + i * 5; > diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-18.c b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-18.c > index 2b1cc0411c3256ccd876d8b4da18ce4881dc0af9..2e86ebe3c6c6a0da9ac242868592f30028ed2155 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-18.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-18.c > @@ -35,8 +35,9 @@ main (void) > { > check_vect (); > > - SIGNEDNESS_3 char a[N], b[N]; > - int expected = 0x12345; > + SIGNEDNESS_3 char a[N]; > + SIGNEDNESS_4 char b[N]; > + SIGNEDNESS_1 int expected = 0x12345; > for (int i = 0; i < N; ++i) > { > a[i] = BASE + i * 5; > diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-22.c b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-22.c > index febeb19784c6aaca72dc0871af0d32cc91fa6ea2..0bde43a6cb855ce5edd9015ebf34ca226353d77e 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-22.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-22.c > @@ -37,7 +37,7 @@ main (void) > > SIGNEDNESS_3 char a[N]; > SIGNEDNESS_4 short b[N]; > - int expected = 0x12345; > + SIGNEDNESS_1 long expected = 0x12345; Does it work with long == int? I still got FAIL: gcc.dg/vect/vect-reduc-dot-22.c -flto -ffat-lto-objects scan-tree-dump-not vect "vect_recog_dot_prod_pattern: detected" FAIL: gcc.dg/vect/vect-reduc-dot-22.c scan-tree-dump-not vect "vect_recog_dot_prod_pattern: detected" with -m32 on Linux/x86-64. > for (int i = 0; i < N; ++i) > { > a[i] = BASE + i * 5; > diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-9.c b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-9.c > index cbbeedec3bfd0810a8ce8036e6670585d9334924..d1049c96bf1febfc8933622e292b44cc8dd129cc 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-9.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-9.c > @@ -35,8 +35,9 @@ main (void) > { > check_vect (); > > - SIGNEDNESS_3 char a[N], b[N]; > - int expected = 0x12345; > + SIGNEDNESS_3 char a[N]; > + SIGNEDNESS_4 char b[N]; > + SIGNEDNESS_1 int expected = 0x12345; > for (int i = 0; i < N; ++i) > { > a[i] = BASE + i * 5; > > > -- -- H.J.