Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86

["H.J. Lu" <hjl.tools@gmail.com>]

On Tue, Oct 27, 2015 at 4:20 AM, Bernd Schmidt <bschmidt@redhat.com> wrote:
> On 10/19/2015 09:55 PM, H.J. Lu wrote:
>>
>>          * calls.c (prepare_call_address): Don't handle -fno-plt here.
>
>
> Is any other target using -fno-plt? If not, and if that's really just a

aarch64 is the only target which checks -fno-plt from commit log below.
I CCed the code author.  aarch64 may suffer from the same issue.

> revert I'll approve it on the condition that the x86 maintainers are happy
> with the rest of the changes.

Uros, can you take a look?

> Your patch is word-wrapped.

Sorry for that.  Here is the link for the patch:

https://gcc.gnu.org/git/?p=gcc.git;a=patch;h=a116a4af073bb99c3117dae38f02d528815bc431

Thanks.

-- 
H.J.
---
Author: jiwang <jiwang@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu Aug 6 16:02:16 2015 +0000

    [AArch64] Tighten direct call pattern for sibcall to repair -fno-plt

    2015-08-06  Jiong Wang  <jiong.wang@arm.com>

    gcc/
      * config/aarch64/constraints.md (Usf): Add the test of
      aarch64_is_noplt_call_p.

    gcc/testsuite/
      * gcc.target/aarch64/noplt_3.c: New testcase.



    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@226682
138bc75d-0d04-0410-961f-82ee72b054a4

commit 2bcb7473b37f9aa76e530f0a2007893489f61586
Author: jiwang <jiwang@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu Aug 6 15:57:36 2015 +0000

    [AArch64] Tighten direct call pattern to repair -fno-plt

    2015-08-06  Jiong Wang  <jiong.wang@arm.com>

    gcc/
      * config/aarch64/aarch64-protos.h (aarch64_is_noplt_call_p): New
declaration.
      * config/aarch64/aarch64.c (aarch64_is_noplt_call_p): New function.
      * config/aarch64/aarch64.md (call_value_symbol): Check noplt scenarios.
      (call_symbol): Likewise.

    gcc/testsuite/
      * gcc.target/aarch64/noplt_1.c: New testcase.
      * gcc.target/aarch64/noplt_2.c: Likewise.



    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@226681
138bc75d-0d04-0410-961f-82ee72b054a4