From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22255 invoked by alias); 27 Oct 2015 11:37:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22245 invoked by uid 89); 27 Oct 2015 11:37:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f175.google.com Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 27 Oct 2015 11:37:25 +0000 Received: by obbza9 with SMTP id za9so49820440obb.1 for ; Tue, 27 Oct 2015 04:37:23 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.165.72 with SMTP id yw8mr27414674oeb.45.1445945843777; Tue, 27 Oct 2015 04:37:23 -0700 (PDT) Received: by 10.76.72.3 with HTTP; Tue, 27 Oct 2015 04:37:23 -0700 (PDT) In-Reply-To: <562F5E11.1090503@redhat.com> References: <562F5E11.1090503@redhat.com> Date: Tue, 27 Oct 2015 11:38:00 -0000 Message-ID: Subject: Re: PING: [PATCH] PR target/67215: -fno-plt needs improvements for x86 From: "H.J. Lu" To: Bernd Schmidt , Uros Bizjak Cc: GCC Patches , Richard Henderson , Richard Biener , Jakub Jelinek , Jiong Wang Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02866.txt.bz2 On Tue, Oct 27, 2015 at 4:20 AM, Bernd Schmidt wrote: > On 10/19/2015 09:55 PM, H.J. Lu wrote: >> >> * calls.c (prepare_call_address): Don't handle -fno-plt here. > > > Is any other target using -fno-plt? If not, and if that's really just a aarch64 is the only target which checks -fno-plt from commit log below. I CCed the code author. aarch64 may suffer from the same issue. > revert I'll approve it on the condition that the x86 maintainers are happy > with the rest of the changes. Uros, can you take a look? > Your patch is word-wrapped. Sorry for that. Here is the link for the patch: https://gcc.gnu.org/git/?p=gcc.git;a=patch;h=a116a4af073bb99c3117dae38f02d528815bc431 Thanks. -- H.J. --- Author: jiwang Date: Thu Aug 6 16:02:16 2015 +0000 [AArch64] Tighten direct call pattern for sibcall to repair -fno-plt 2015-08-06 Jiong Wang gcc/ * config/aarch64/constraints.md (Usf): Add the test of aarch64_is_noplt_call_p. gcc/testsuite/ * gcc.target/aarch64/noplt_3.c: New testcase. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@226682 138bc75d-0d04-0410-961f-82ee72b054a4 commit 2bcb7473b37f9aa76e530f0a2007893489f61586 Author: jiwang Date: Thu Aug 6 15:57:36 2015 +0000 [AArch64] Tighten direct call pattern to repair -fno-plt 2015-08-06 Jiong Wang gcc/ * config/aarch64/aarch64-protos.h (aarch64_is_noplt_call_p): New declaration. * config/aarch64/aarch64.c (aarch64_is_noplt_call_p): New function. * config/aarch64/aarch64.md (call_value_symbol): Check noplt scenarios. (call_symbol): Likewise. gcc/testsuite/ * gcc.target/aarch64/noplt_1.c: New testcase. * gcc.target/aarch64/noplt_2.c: Likewise. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@226681 138bc75d-0d04-0410-961f-82ee72b054a4