Re: [PATCH] i386: Move Intel intrinsics head files to <immintrin.h>

["H.J. Lu" <hjl.tools@gmail.com>]

On Sun, Jan 20, 2019 at 10:12 AM Uros Bizjak <ubizjak@gmail.com> wrote:
>
> On Sun, Jan 20, 2019 at 7:09 PM Uros Bizjak <ubizjak@gmail.com> wrote:
> >
> > On Sun, Jan 20, 2019 at 4:11 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Sun, Jan 20, 2019 at 4:03 AM Uros Bizjak <ubizjak@gmail.com> wrote:
> > > >
> > > > On 1/19/19, H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > > According to Intel Intrinsics Guide:
> > > > >
> > > > > https://software.intel.com/sites/landingpage/IntrinsicsGuide/
> > > > >
> > > > > Intel intrinsics should be available by including <immintrin.h>.  This
> > > > > patch moves remaining Intel intrinsics head files from <x86intrin.h> to
> > > > > <immintrin.h>.
> > > >
> > > > I can't find the quoted requirement in the provided link.
> > >
> > > That is an interactive website.  If you type in "_xgetbv" and click on it,
> > > you will get
> > >
> > > Synopsis
> > >
> > > unsigned __int64 _xgetbv (unsigned int a)
> > > #include <immintrin.h>
> > > Instruction: xgetbv
> > > CPUID Flags: XSAVE
> > >
> > > Description
> > >
> > > Copy up to 64-bits from the value of the extended control register
> > > (XCR) specified by a into dst. Currently only XFEATURE_ENABLED_MASK
> > > XCR is supported.
> > >
> > > Operation
> > >
> > > dst[63:0] := XCR[a]
> >
> > Ah, thanks for the hint. LGTM, but still needs RM approval.
>
> I wonder, what is/was the purpose of x86intrin.h, considering that
> everything can be included from immintrin.h?

Some intrinsics aren't covered by Intel Intrinsics Guide, like AMD
specific ones.

-- 
H.J.