From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56399 invoked by alias); 3 Sep 2015 11:31:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 56386 invoked by uid 89); 3 Sep 2015 11:31:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 03 Sep 2015 11:31:07 +0000 Received: by obbbh8 with SMTP id bh8so29611211obb.0 for ; Thu, 03 Sep 2015 04:31:05 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.20.141 with SMTP id n13mr26865057obe.26.1441279865605; Thu, 03 Sep 2015 04:31:05 -0700 (PDT) Received: by 10.76.170.36 with HTTP; Thu, 3 Sep 2015 04:31:05 -0700 (PDT) In-Reply-To: References: <14DA89C6-4F95-4A90-847A-6B6E6909475A@comcast.net> Date: Thu, 03 Sep 2015 11:36:00 -0000 Message-ID: Subject: Re: [testsuite] Clean up effective_target cache From: "H.J. Lu" To: Christophe Lyon Cc: Mike Stump , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00247.txt.bz2 On Wed, Sep 2, 2015 at 7:02 AM, Christophe Lyon wrote: > On 1 September 2015 at 16:04, Christophe Lyon > wrote: >> On 25 August 2015 at 17:31, Mike Stump wrote: >>> On Aug 25, 2015, at 1:14 AM, Christophe Lyon wrote: >>>> Some subsets of the tests override ALWAYS_CXXFLAGS or >>>> TEST_ALWAYS_FLAGS and perform effective_target support tests using >>>> these modified flags. >>> >>>> This patch adds a new function 'clear_effective_target_cache', which >>>> is called at the end of every .exp file which overrides >>>> ALWAYS_CXXFLAGS or TEST_ALWAYS_FLAGS. >>> >>> So, a simple English directive somewhere that says, if one changes ALWA= YS_CXXFLAGS or TEST_ALWAYS_FLAGS then they should do a clear_effective_targ= et_cache at the end as the target cache can make decisions based upon the f= lags, and those decisions need to be redone when the flags change would be = nice. >>> >>> I do wonder, do we need to reexamine when setting the flags? I=E2=80= =99m thinking of a sequence like: non-thumb default, is_thumb, set flags (t= humb), is_thumb. Anyway, safe to punt this until someone discovers it or i= s reasonable sure it happens. >>> >>> Anyway, all looks good. Ok. >>> >> Here is what I have committed (r227372). > > Hmmm, in fact this was r227401. > It caused: ERROR: can't unset "et_cache(arm_neon_ok,value)": no such element in array ERROR: can't unset "et_cache(arm_neon_ok,value)": no such element in array ERROR: can't unset "et_cache(arm_neon_ok,value)": no such element in array ERROR: can't unset "et_cache(dfp,value)": no such element in array ERROR: can't unset "et_cache(fsanitize_address,value)": no such element in = array ERROR: can't unset "et_cache(ia32,value)": no such element in array ERROR: can't unset "et_cache(ia32,value)": no such element in array ERROR: can't unset "et_cache(ia32,value)": no such element in array ERROR: can't unset "et_cache(ia32,value)": no such element in array ERROR: can't unset "et_cache(ia32,value)": no such element in array ERROR: can't unset "et_cache(ilp32,value)": no such element in array ERROR: can't unset "et_cache(ilp32,value)": no such element in array ERROR: can't unset "et_cache(ilp32,value)": no such element in array ERROR: can't unset "et_cache(ilp32,value)": no such element in array ERROR: can't unset "et_cache(label_values,value)": no such element in array ERROR: can't unset "et_cache(lp64,value)": no such element in array ERROR: can't unset "et_cache(lp64,value)": no such element in array ERROR: can't unset "et_cache(lp64,value)": no such element in array ERROR: can't unset "et_cache(ptr32plus,value)": no such element in array ERROR: can't unset "et_cache(ptr32plus,value)": no such element in array ... on Linux/x86-64: https://gcc.gnu.org/ml/gcc-testresults/2015-09/msg00167.html --=20 H.J.