From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25465 invoked by alias); 16 Sep 2014 15:37:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 25407 invoked by uid 89); 16 Sep 2014 15:37:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f48.google.com Received: from mail-oa0-f48.google.com (HELO mail-oa0-f48.google.com) (209.85.219.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 16 Sep 2014 15:37:01 +0000 Received: by mail-oa0-f48.google.com with SMTP id g18so23593oah.7 for ; Tue, 16 Sep 2014 08:37:00 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.126.49 with SMTP id mv17mr24542308obb.26.1410881819876; Tue, 16 Sep 2014 08:36:59 -0700 (PDT) Received: by 10.76.72.4 with HTTP; Tue, 16 Sep 2014 08:36:59 -0700 (PDT) In-Reply-To: <20140915155958.GS5387@tassilo.jf.intel.com> References: <1410532377-13147-1-git-send-email-andi@firstfloor.org> <1410532377-13147-2-git-send-email-andi@firstfloor.org> <20140915155958.GS5387@tassilo.jf.intel.com> Date: Tue, 16 Sep 2014 15:37:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] Add some more test cases for fentry and pg From: "H.J. Lu" To: Andi Kleen Cc: Richard Biener , Andi Kleen , GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg01297.txt.bz2 On Mon, Sep 15, 2014 at 8:59 AM, Andi Kleen wrote: > On Mon, Sep 15, 2014 at 11:29:50AM +0200, Richard Biener wrote: >> On Fri, Sep 12, 2014 at 4:32 PM, Andi Kleen wrote: >> > From: Andi Kleen >> > >> > Test fentry and no_instrument_function overriding. >> > >> > No test cases for the LTO test for now, as the LTO >> > harness doesn't seem to support different flags for the final >> > link. >> >> Sure it does - via dg-extra-ld-options (you have to negate compile-time >> opts to "remove" them). > > Ok. I'll add test cases for that too then. > >> >> Are you sure the tests are target independent enough? That is, >> 'mcount' is really 'mcount' on all targets? > > I'm not. I'll make them x86 only. > > Thanks, > > -Andi Tested on Linux/x86-64. I checked in this to fix: https://gcc.gnu.org/ml/gcc-regression/2014-09/msg00084.html -- H.J. --- Index: ChangeLog =================================================================== --- ChangeLog (revision 215300) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-09-16 H.J. Lu + + * gcc.dg/pg.c: Fix a typo. + 2014-09-16 Richard Biener PR testsuite/63258 Index: gcc.dg/pg.c =================================================================== --- gcc.dg/pg.c (revision 215300) +++ gcc.dg/pg.c (working copy) @@ -1,6 +1,6 @@ /* Test -fprofile override */ /* { dg-do compile } */ -/* { dg-options "-fprofile" { target { { i686-*-* x86_64-*-* } } } } */ +/* { dg-options "-fprofile" { target i?86-*-* x86_64-*-* } } */ /* { dg-final { scan-assembler-not "mcount" } } */ /* Origin: Andi Kleen */ extern void foobar(const char *);