From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: Richard Biener <rguenther@suse.de>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Calculate TYPE_CANONICAL only for types that can be accessed in memory
Date: Sun, 24 May 2015 14:47:00 -0000 [thread overview]
Message-ID: <CAMe9rOqZ_cVd85JGjSezd+Bbk=pFq+y0xE6e6i9WMFpdmDt7nA@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOr+eLbPbJmy35cvm+pBJCEVw8MpfW5do0WydNN-Qrf-WA@mail.gmail.com>
On Sun, May 24, 2015 at 5:49 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, May 22, 2015 at 5:00 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>>> Now we have it spelled out 4 times ... makes sense to create a new
>>> macro for it? (though I cannot think of a good name...
>>> UNACCESSIBLE_TYPE_P ()?)
>>
>> Yep, actually I already made that version of patch yesterday but then got
>> hooked by beers. This is better version (also with more sensible comments).
>> I will commit it at afternoon if you have no further comments.
>>
>>
>> * lto.c (hash_canonical_type): Be sure we hash only types that
>> need alias set.
>> (gimple_register_canonical_type_1): Do not produce canonical
>> types for types that do not need alias sets.
>> * tree.c (gimple_canonical_types_compatible_p): Sanity check that
>> we do not try to compute canonical type for type that does not need
>> alias set.
>> (verify_type): Drop FIXME for METHOD_TYPE, update FIXME for
>> FUNCITON_TYPE.
>> * tree.h (type_with_alias_set_p): New.
>
> This caused:
>
> https://gcc.gnu.org/ml/gcc-cvs/2015-05/msg00948.html
I meant:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66273
--
H.J.
next prev parent reply other threads:[~2015-05-24 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 18:26 Jan Hubicka
2015-05-22 8:28 ` Richard Biener
2015-05-22 12:21 ` Jan Hubicka
2015-05-24 13:33 ` H.J. Lu
2015-05-24 14:47 ` H.J. Lu [this message]
2015-05-22 12:30 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqZ_cVd85JGjSezd+Bbk=pFq+y0xE6e6i9WMFpdmDt7nA@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).