From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by sourceware.org (Postfix) with ESMTPS id 067B43858D37 for ; Mon, 26 Sep 2022 19:52:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 067B43858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf2e.google.com with SMTP id i15so4988029qvp.5 for ; Mon, 26 Sep 2022 12:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=xausyWn7uIqBbOxbPYwH2r+bCZNTY+HCSe52neoVkNA=; b=Qf7/xuJ5CVUjT2gSyvVydXtSwE3K7WrVYFdWUaduSBAKJssk8OgskxExyjfQsDYvtn lIfT01751X2tns6rSxzrQxYWn/rmE3MCf5RzNBFIolHVSAiDewqi0qQJwBya6gWlEv/5 22c81z6bI9UA8vpQ6OPI6r3rt8TQG4PZlR0Zl/JhzzcmLSZPvy+l5iDpp2VNEBqUt6n7 okrhBB0mTlGd5I+6/nN0OEy10BElsYfhygok+hVCf27/JMSTkAW89L78Zd+bFkXQWbiW ZwM50SiFhaqv8bdC0lxjo0jQj+IWRJJAemcNow4+oi1PGiBHPdeOBZahZPgadfQlmu66 m6Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=xausyWn7uIqBbOxbPYwH2r+bCZNTY+HCSe52neoVkNA=; b=FbKO7mKsGvq/HOPyXrVNA5BWxSuO7uVmzFv1OcsOtF9uCQ6LaZsQGjYl72GmvPe+Yc G7mVn56LntYt96ZsMqDCBIFsIn6dIlPIH8S/t793CP9+/vU0y8hFMcTbffzgX0LWBzxH rWvs8ttkAWSqyFxDhU2r+e1o+j6R+56K8D60wuQX0nwHjST6CU1BWQQQ4jBYV2lrOu1N HpGXKbx7lugP8Z4grN3pJg7UKhmZZ526DoipGzlvSvXHazEhLziWQ5zBpR8PsMRyYIk1 m7kNO0wTr9vvnz6+vVKrZHL2uupHgicplyXt4eQrgNrLR7eL91Yf8BtGk76pdzX9DsED YMKg== X-Gm-Message-State: ACrzQf23Wwyg2Ptdt1gcx0L9FsaVQZhF1wM8NaQXfLvn1cCgRFvxZFUd SdIgxQV0S1kSV80IpD7/YAYmgEgPKcNQotnhjJw= X-Google-Smtp-Source: AMsMyM4NFI6w+1vbfUcV7gBSZFq+8Fdy3nNym+Q/O4ducznwwfFOv9EQBFbFRTQOslXiOEIJ5CyQSGmAvdpwIEQpvF0= X-Received: by 2002:a05:6214:d0e:b0:4ad:5e35:329a with SMTP id 14-20020a0562140d0e00b004ad5e35329amr18475989qvh.28.1664221964353; Mon, 26 Sep 2022 12:52:44 -0700 (PDT) MIME-Version: 1.0 References: <20220902143639.2464892-1-hjl.tools@gmail.com> <93fb0c92-c6a4-450b-2d0a-eddd30543fae@gmail.com> In-Reply-To: <93fb0c92-c6a4-450b-2d0a-eddd30543fae@gmail.com> From: "H.J. Lu" Date: Mon, 26 Sep 2022 12:52:08 -0700 Message-ID: Subject: Re: [PATCH] Ignore debug insns with CONCAT and CONCATN for insn scheduling To: Jeff Law Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Sep 24, 2022 at 1:37 PM Jeff Law wrote: > > > On 9/21/22 16:11, H.J. Lu wrote: > > On Wed, Sep 7, 2022 at 10:03 AM Jeff Law via Gcc-patches > > wrote: > >> > >> > >> On 9/2/2022 8:36 AM, H.J. Lu via Gcc-patches wrote: > >>> CONCAT and CONCATN never appear in the insn chain. They are only used > >>> in debug insn. Ignore debug insns with CONCAT and CONCATN for insn > >>> scheduling to avoid different insn orders with and without debug insn. > >>> > >>> gcc/ > >>> > >>> PR rtl-optimization/106746 > >>> * sched-deps.cc (sched_analyze_2): Ignore debug insns with CONCAT > >>> and CONCATN. > >> Shouldn't we be ignoring everything in a debug insn? I don't see why > >> CONCAT/CONCATN are special here. > > Debug insns are processed by insn scheduling. I think it is to improve debug > > experiences. It is just that there are no matching usages of CONCAT/CONCATN > > in non-debug insns. > > But from a dependency standpoint ISTM all debug insn can be ignored. I > still don't see why concat/concatn should be special here. > I tried to ignore everything in a debug insn. It caused many regressions in the GCC testsuite. -- H.J.