From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7249 invoked by alias); 26 May 2012 00:07:39 -0000 Received: (qmail 7233 invoked by uid 22791); 26 May 2012 00:07:38 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-qc0-f175.google.com (HELO mail-qc0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 May 2012 00:07:25 +0000 Received: by qcso7 with SMTP id o7so901708qcs.20 for ; Fri, 25 May 2012 17:07:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.182.194 with SMTP id cd2mr748746qab.83.1337990844527; Fri, 25 May 2012 17:07:24 -0700 (PDT) Received: by 10.229.169.130 with HTTP; Fri, 25 May 2012 17:07:24 -0700 (PDT) In-Reply-To: References: <20120307004630.A503DB21B6@azwildcat.mtv.corp.google.com> Date: Sat, 26 May 2012 00:07:00 -0000 Message-ID: Subject: Re: User directed Function Multiversioning via Function Overloading (issue5752064) From: "H.J. Lu" To: Sriraman Tallam Cc: Richard Guenther , Jan Hubicka , Uros Bizjak , reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org, David Li Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-05/txt/msg01785.txt.bz2 On Mon, May 14, 2012 at 11:28 AM, Sriraman Tallam wro= te: > Hi H.J, > > =A0 Attaching new patch with 2 test cases, mv2.C checks ISAs only and > mv1.C checks ISAs and arches mixed. Right now, checking only arches is > not needed as they are mutually exclusive, any order should be fine. > > Patch also available for review here: =A0http://codereview.appspot.com/57= 52064 Sorry for the delay. It looks OK except for the function order in tescases. I think you should rearrange them so that they are not in the same order as the priority. Thanks. H.J. > Thanks, > -Sri. > > On Sat, May 12, 2012 at 6:37 AM, H.J. Lu wrote: >> On Fri, May 11, 2012 at 7:04 PM, Sriraman Tallam w= rote: >>> Hi H.J., >>> >>> =A0 I have updated the patch to improve the dispatching method like we >>> discussed. Each feature gets a priority now, and the dispatching is >>> done in priority order. Please see i386.c for the changes. >>> >>> Patch also available for review here: =A0http://codereview.appspot.com/= 5752064 >>> >> >> I think you need 3 tests: >> >> 1. =A0Only with ISA. >> 2. =A0Only with arch >> 3. =A0Mixed with ISA and arch >> >> since test mixed ISA and arch may hide issues with ISA only or arch only. >> >> --