From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Iyer, Balaji V" <balaji.v.iyer@intel.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
Date: Tue, 06 Sep 2011 14:57:00 -0000 [thread overview]
Message-ID: <CAMe9rOqi=9y4bQkMk99-JR5F3UxN+Mn0W3dc=5Cvz0aJG6mwtg@mail.gmail.com> (raw)
In-Reply-To: <2950715866004049A240A2F9BB410E7315F23D3550@azsmsx502.amr.corp.intel.com>
You should just say "* g++.dg/cilk-plus/cilk_plus.exp: Likewise" since
the change is the same as above.
H.J.
On Tue, Sep 6, 2011 at 7:45 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> I fixed all the changed you have requested. Here is an updated patch.
>
> Thanks,
>
> Balaji V. Iyer.
>
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 10:41 AM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
>
> On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
>
> Please remove the extra blank line in ChangLog. ChangeLog should simply say what you did, not why.
>
> H.J.
> ----
>> Sorry for the mistake.
>>
>> Thanks,
>>
>> Balaji V. Iyer.
>>
>>
>> -----Original Message-----
>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>> Sent: Tuesday, September 06, 2011 10:22 AM
>> To: Iyer, Balaji V
>> Cc: gcc-patches@gcc.gnu.org
>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to
>> testsuite script
>>
>> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>> Hello Everyone,
>>> This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>>
>>> Thanking You,
>>>
>>
>> ChangeLog entries are missing.
>>
>> --
>> H.J.
>>
>
>
>
> --
> H.J.
>
--
H.J.
next prev parent reply other threads:[~2011-09-06 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 4:52 Iyer, Balaji V
2011-09-06 14:22 ` H.J. Lu
2011-09-06 14:31 ` Iyer, Balaji V
2011-09-06 14:41 ` H.J. Lu
2011-09-06 14:46 ` Iyer, Balaji V
2011-09-06 14:57 ` H.J. Lu [this message]
2011-09-06 15:03 ` Iyer, Balaji V
2011-09-06 16:42 ` H.J. Lu
[not found] ` <CAMe9rOogjm25uoBNUAmZUVYO57ccGEJu-hbp9WX+07Jv40aQiA@mail.gmail.com>
2011-09-06 17:35 ` Iyer, Balaji V
2011-09-06 17:39 ` H.J. Lu
2011-09-06 17:46 ` Iyer, Balaji V
2011-09-06 18:09 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqi=9y4bQkMk99-JR5F3UxN+Mn0W3dc=5Cvz0aJG6mwtg@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=balaji.v.iyer@intel.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).