From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25386 invoked by alias); 21 Jul 2011 22:02:36 -0000 Received: (qmail 25369 invoked by uid 22791); 21 Jul 2011 22:02:34 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qy0-f175.google.com (HELO mail-qy0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Jul 2011 22:02:16 +0000 Received: by qyk30 with SMTP id 30so3676953qyk.20 for ; Thu, 21 Jul 2011 15:02:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.118.69 with SMTP id u5mr707058qcq.122.1311285735768; Thu, 21 Jul 2011 15:02:15 -0700 (PDT) Received: by 10.229.98.193 with HTTP; Thu, 21 Jul 2011 15:02:15 -0700 (PDT) In-Reply-To: <4E1DBBC9.4030305@redhat.com> References: <20110709212846.GA3563@intel.com> <4E1A1D43.3010106@redhat.com> <4E1A4864.2030702@redhat.com> <4E1DB962.6010808@redhat.com> <4E1DBBC9.4030305@redhat.com> Date: Thu, 21 Jul 2011 22:30:00 -0000 Message-ID: Subject: Re: PATCH [3/n] X32: Promote pointers to Pmode From: "H.J. Lu" To: Richard Henderson Cc: Uros Bizjak , gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary=000e0cd5c3467ac33504a89b80c4 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg01890.txt.bz2 --000e0cd5c3467ac33504a89b80c4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 782 On Wed, Jul 13, 2011 at 8:37 AM, Richard Henderson wrote: > On 07/13/2011 08:35 AM, H.J. Lu wrote: >> On Wed, Jul 13, 2011 at 8:27 AM, Richard Henderson wrot= e: >>> On 07/13/2011 07:02 AM, H.J. Lu wrote: >>>> Hi Richard, >>>> >>>> Is my patch OK? >>> >>> No, I don't think it is. >>> >> >> What is your suggestion? > > Promote the return value. =A0If that means it doesn't match function_valu= e, > then I suggest that function_value is wrong. > > > r~ > This is the patch I am testing. I will check it in if it works. Thanks. --=20 H.J. --- 2011-07-21 H.J. Lu * config/i386/i386.c (function_value_64): Always return pointers in Pmode. (ix86_promote_function_mode): New. (TARGET_PROMOTE_FUNCTION_MODE): Likewise. --000e0cd5c3467ac33504a89b80c4 Content-Type: text/x-diff; charset=US-ASCII; name="gcc-x32-abi-3.patch" Content-Disposition: attachment; filename="gcc-x32-abi-3.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gqe9nedb0 Content-length: 2440 MjAxMS0wNy0yMSAgSC5KLiBMdSAgPGhvbmdqaXUubHVAaW50ZWwuY29tPgoK CSogY29uZmlnL2kzODYvaTM4Ni5jIChmdW5jdGlvbl92YWx1ZV82NCk6IEFs d2F5cyByZXR1cm4gcG9pbnRlcnMKCWluIFBtb2RlLgoJKGl4ODZfcHJvbW90 ZV9mdW5jdGlvbl9tb2RlKTogTmV3LgoJKFRBUkdFVF9QUk9NT1RFX0ZVTkNU SU9OX01PREUpOiBMaWtld2lzZS4KCmRpZmYgLS1naXQgYS9nY2MvY29uZmln L2kzODYvaTM4Ni5jIGIvZ2NjL2NvbmZpZy9pMzg2L2kzODYuYwppbmRleCBk YTZjODg4Li4zMmFmMzAzIDEwMDY0NAotLS0gYS9nY2MvY29uZmlnL2kzODYv aTM4Ni5jCisrKyBiL2djYy9jb25maWcvaTM4Ni9pMzg2LmMKQEAgLTcwNzgs NiArNzA3OCwxMSBAQCBmdW5jdGlvbl92YWx1ZV82NCAoZW51bSBtYWNoaW5l X21vZGUgb3JpZ19tb2RlLCBlbnVtIG1hY2hpbmVfbW9kZSBtb2RlLAogCSAg cmV0dXJuIGdlbl9ydHhfUkVHIChtb2RlLCBBWF9SRUcpOwogCX0KICAgICB9 CisgIGVsc2UgaWYgKFBPSU5URVJfVFlQRV9QICh2YWx0eXBlKSkKKyAgICB7 CisgICAgICAvKiBQb2ludGVycyBhcmUgYWx3YXlzIHJldHVybmVkIGluIFBt b2RlLiAqLworICAgICAgbW9kZSA9IFBtb2RlOworICAgIH0KIAogICByZXQg PSBjb25zdHJ1Y3RfY29udGFpbmVyIChtb2RlLCBvcmlnX21vZGUsIHZhbHR5 cGUsIDEsCiAJCQkgICAgIFg4Nl82NF9SRUdQQVJNX01BWCwgWDg2XzY0X1NT RV9SRUdQQVJNX01BWCwKQEAgLTcxNDcsNiArNzE1MiwyMiBAQCBpeDg2X2Z1 bmN0aW9uX3ZhbHVlIChjb25zdF90cmVlIHZhbHR5cGUsIGNvbnN0X3RyZWUg Zm50eXBlX29yX2RlY2wsCiAgIHJldHVybiBpeDg2X2Z1bmN0aW9uX3ZhbHVl XzEgKHZhbHR5cGUsIGZudHlwZV9vcl9kZWNsLCBvcmlnX21vZGUsIG1vZGUp OwogfQogCisvKiBQb2ludGVyIGZ1bmN0aW9uIGFyZ3VtZW50cyBhbmQgcmV0 dXJuIHZhbHVlcyBhcmUgcHJvbW90ZWQgdG8gUG1vZGUuICAqLworCitzdGF0 aWMgZW51bSBtYWNoaW5lX21vZGUKK2l4ODZfcHJvbW90ZV9mdW5jdGlvbl9t b2RlIChjb25zdF90cmVlIHR5cGUsIGVudW0gbWFjaGluZV9tb2RlIG1vZGUs CisJCQkgICAgaW50ICpwdW5zaWduZWRwLCBjb25zdF90cmVlIGZudHlwZSwK KwkJCSAgICBpbnQgZm9yX3JldHVybikKK3sKKyAgaWYgKHR5cGUgIT0gTlVM TF9UUkVFICYmIFBPSU5URVJfVFlQRV9QICh0eXBlKSkKKyAgICB7CisgICAg ICAqcHVuc2lnbmVkcCA9IFBPSU5URVJTX0VYVEVORF9VTlNJR05FRDsKKyAg ICAgIHJldHVybiBQbW9kZTsKKyAgICB9CisgIHJldHVybiBkZWZhdWx0X3By b21vdGVfZnVuY3Rpb25fbW9kZSAodHlwZSwgbW9kZSwgcHVuc2lnbmVkcCwg Zm50eXBlLAorCQkJCQlmb3JfcmV0dXJuKTsKK30KKwogcnR4CiBpeDg2X2xp YmNhbGxfdmFsdWUgKGVudW0gbWFjaGluZV9tb2RlIG1vZGUpCiB7CkBAIC0z NDk3MCw2ICszNTA1NSw5IEBAIGl4ODZfYXV0b3ZlY3Rvcml6ZV92ZWN0b3Jf c2l6ZXMgKHZvaWQpCiAjdW5kZWYgVEFSR0VUX0ZVTkNUSU9OX1ZBTFVFX1JF R05PX1AKICNkZWZpbmUgVEFSR0VUX0ZVTkNUSU9OX1ZBTFVFX1JFR05PX1Ag aXg4Nl9mdW5jdGlvbl92YWx1ZV9yZWdub19wCiAKKyN1bmRlZiBUQVJHRVRf UFJPTU9URV9GVU5DVElPTl9NT0RFCisjZGVmaW5lIFRBUkdFVF9QUk9NT1RF X0ZVTkNUSU9OX01PREUgaXg4Nl9wcm9tb3RlX2Z1bmN0aW9uX21vZGUKKwog I3VuZGVmIFRBUkdFVF9TRUNPTkRBUllfUkVMT0FECiAjZGVmaW5lIFRBUkdF VF9TRUNPTkRBUllfUkVMT0FEIGl4ODZfc2Vjb25kYXJ5X3JlbG9hZAogCg== --000e0cd5c3467ac33504a89b80c4--