public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Eric Gallager <egall@gwmail.gwu.edu>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] x86: Document -fcf-protection requires i686 or newer
Date: Mon, 1 Nov 2021 04:21:34 -0700	[thread overview]
Message-ID: <CAMe9rOqrpFptZE_CEKdn7sY+ps3_LV3G5mV+DC8=SoBy5PpFcw@mail.gmail.com> (raw)
In-Reply-To: <CAMfHzOtPmEkP_FHdXQ9xGo3+nCGYhpTCfJ01ZSVMyUDLZG0-aw@mail.gmail.com>

On Fri, Oct 29, 2021 at 3:04 PM Eric Gallager <egall@gwmail.gwu.edu> wrote:
>
> On Thu, Oct 21, 2021 at 12:49 PM H.J. Lu via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> >         PR target/98667
> >         * doc/invoke.texi: Document -fcf-protection requires i686 or
> >         new.
> > ---
> >  gcc/doc/invoke.texi | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> > index c66a25fcd69..71992b8c597 100644
> > --- a/gcc/doc/invoke.texi
> > +++ b/gcc/doc/invoke.texi
> > @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation
> >  (@pxref{Function Attributes}).
> >
> >  Currently the x86 GNU/Linux target provides an implementation based
> > -on Intel Control-flow Enforcement Technology (CET).
> > +on Intel Control-flow Enforcement Technology (CET) which works for
> > +i686 processor or newer.
>
> I think "processor" should be pluralized to "processors"? Also,
> possibly a missing comma after "(CET)"?
>

Can you submit a patch?

Thanks.

-- 
H.J.

      reply	other threads:[~2021-11-01 11:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 16:47 H.J. Lu
2021-10-21 19:04 ` Uros Bizjak
2021-10-21 19:08   ` H.J. Lu
2021-10-29 22:03 ` Eric Gallager
2021-11-01 11:21   ` H.J. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMe9rOqrpFptZE_CEKdn7sY+ps3_LV3G5mV+DC8=SoBy5PpFcw@mail.gmail.com' \
    --to=hjl.tools@gmail.com \
    --cc=egall@gwmail.gwu.edu \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).