From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com
 [IPv6:2607:f8b0:4864:20::535])
 by sourceware.org (Postfix) with ESMTPS id 19E2C3858426
 for <gcc-patches@gcc.gnu.org>; Mon,  1 Nov 2021 11:22:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19E2C3858426
Received: by mail-pg1-x535.google.com with SMTP id b4so9842156pgh.10
 for <gcc-patches@gcc.gnu.org>; Mon, 01 Nov 2021 04:22:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=UX66RkrOFwactv1UtpXJIQVrv+npphSm/mBnOU6LywQ=;
 b=Ra/+3crRrmulU6vKqKg1V/J33fLOxQj9MQcwZBvTilYEcY5zLSA2a5ylk8JCi0zgU1
 It/uHZtS1P5Y4dD+d7pxckNWD5xgZY9fLx5EVgKp6JQ5LRkNbSRtYeESYSO0s3Ie80WC
 EsVZWPhzqd0f3urpcWMzPgmmz3w3LBRtXTSOcog2essBbuvj6dx7HpNxmYlPmJNzy9Ju
 a1IpC6zjZ8SB0tpWBchZssrr6ZIGS63ZyNkL4+sSgw+tQFlG7O/1lk2heEDNBn3pvx2C
 LgGpnoO3YfykjY2LU89k2POug8aw8LvsHjUXcebyDz859rz4Xj5/rdbtCOHChN1rhaB1
 0T8Q==
X-Gm-Message-State: AOAM531oUVFHZuRF1p8qO58+xreb0ijAiUSCYq4HvOOKYiaNEBeD+NGM
 jvwRXwnehiKGsygt31ntLNp4OA2JPRz21Kn6E/cmg4Du
X-Google-Smtp-Source: ABdhPJwT9NByanECOS3tSzRWFOBf0wsTmcwoOJtRMFedoXfOAT6uR+i2elfHCaRctWEZI5yQ80V0RqPqise195bv4L4=
X-Received: by 2002:a05:6a00:b4c:b0:481:2a:f374 with SMTP id
 p12-20020a056a000b4c00b00481002af374mr8087059pfo.60.1635765729981; Mon, 01
 Nov 2021 04:22:09 -0700 (PDT)
MIME-Version: 1.0
References: <20211021164722.500302-1-hjl.tools@gmail.com>
 <CAMfHzOtPmEkP_FHdXQ9xGo3+nCGYhpTCfJ01ZSVMyUDLZG0-aw@mail.gmail.com>
In-Reply-To: <CAMfHzOtPmEkP_FHdXQ9xGo3+nCGYhpTCfJ01ZSVMyUDLZG0-aw@mail.gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 1 Nov 2021 04:21:34 -0700
Message-ID: <CAMe9rOqrpFptZE_CEKdn7sY+ps3_LV3G5mV+DC8=SoBy5PpFcw@mail.gmail.com>
Subject: Re: [PATCH] x86: Document -fcf-protection requires i686 or newer
To: Eric Gallager <egall@gwmail.gwu.edu>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Nov 2021 11:22:12 -0000

On Fri, Oct 29, 2021 at 3:04 PM Eric Gallager <egall@gwmail.gwu.edu> wrote:
>
> On Thu, Oct 21, 2021 at 12:49 PM H.J. Lu via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> >         PR target/98667
> >         * doc/invoke.texi: Document -fcf-protection requires i686 or
> >         new.
> > ---
> >  gcc/doc/invoke.texi | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> > index c66a25fcd69..71992b8c597 100644
> > --- a/gcc/doc/invoke.texi
> > +++ b/gcc/doc/invoke.texi
> > @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation
> >  (@pxref{Function Attributes}).
> >
> >  Currently the x86 GNU/Linux target provides an implementation based
> > -on Intel Control-flow Enforcement Technology (CET).
> > +on Intel Control-flow Enforcement Technology (CET) which works for
> > +i686 processor or newer.
>
> I think "processor" should be pluralized to "processors"? Also,
> possibly a missing comma after "(CET)"?
>

Can you submit a patch?

Thanks.

-- 
H.J.