From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id B005C3858408; Mon, 6 Sep 2021 01:30:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B005C3858408 Received: by mail-pj1-x1035.google.com with SMTP id pi15-20020a17090b1e4f00b00197449fc059so708336pjb.0; Sun, 05 Sep 2021 18:30:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=put5+HXosFrTP+cqKLEfetI4D6a5Lr1km1dOBdo77HA=; b=ZuM5UrO0ruxL42te6a2hmqvC3cccv7iLBecNggnHQtAnC5csRPXCymxU9KZVmFbLQh mAFJKIQxMJtJRLYqjWmj8bjo8im8ZLnq1ZzK5dtHNWEZr+ZpeXvrIoJXWeW8wF3XtxtT /om33lIV85emVbfxOoZni6Q6F1rJIZWQkHovC9mg0g7xpBWByRZFX2iFDXkmc5O8E5U3 lzxZVEkNk1K2t+2bDQMj5j2Ans2GPAmH4/L6kZPA1KKYvd0/Z2tss8Gc5UQUdgU4hZr7 5aBlx4zMsXLbcWV5s5XeJ0BImr2bYGfkjmDCQ1ZUPj4Tqx87goduxOIz9lJI8kfeU03Z ZxSQ== X-Gm-Message-State: AOAM5333H+/PJtZWjdHGK7wg20xyIb/dvkpW0ZPO6ERT+eaina0zurSv lmicpSieUd4B15HrhK68TkkdtfVa+tHGUyVhheo= X-Google-Smtp-Source: ABdhPJwqORXZcnhNtveuhBQX2T0haSnytRnbbE7S0kE+iEfsxiQa+WtqBYzAUGGpgiwVrG5JSk1fU8r4x91jOM8bWWw= X-Received: by 2002:a17:902:82c1:b0:135:b97d:8e84 with SMTP id u1-20020a17090282c100b00135b97d8e84mr8663189plz.85.1630891804678; Sun, 05 Sep 2021 18:30:04 -0700 (PDT) MIME-Version: 1.0 References: <25e1007e-f23c-d7b6-b2cc-7490e69d2f9f@codesourcery.com> In-Reply-To: <25e1007e-f23c-d7b6-b2cc-7490e69d2f9f@codesourcery.com> From: "H.J. Lu" Date: Sun, 5 Sep 2021 18:29:28 -0700 Message-ID: Subject: Re: [PATCH, Fortran] Skip gfortran.dg/PR100914.f90 on targets that don't provide quadmath.h To: Sandra Loosemore Cc: "fortran@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" , Christophe Lyon , Sunil K Pandey Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3024.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Sep 2021 01:30:07 -0000 On Sun, Sep 5, 2021 at 11:02 AM Sandra Loosemore wrote: > > On 9/5/21 7:31 AM, H.J. Lu wrote: > > On Sat, Sep 4, 2021 at 7:31 PM Sandra Loosemore wrote: > >> > >> The testcase gfortran.dg/PR100914.f90 that I recently checked in > >> (originally written by Jos=C3=A9 Rui Faustino de Sousa) depends on the > >> header file to obtain a typedef for __complex128. It > >> appears not to be possible to define an equivalent type in a portable > >> way in the testcase itself (see > >> https://gcc.gnu.org/onlinedocs/gcc-11.2.0/gcc/Floating-Types.html) so > >> this patch skips the test entirely on targets where quadmath.h is not > >> available. > >> > >> The target-supports.exp change was cut-and-pasted from similar code in > >> that file, but I haven't figured out how to test this change in a buil= d > >> that doesn't provide quadmath.h (e.g., my aarch64-linux-gnu toolchain > >> build attempt croaked with an unrelated compilation error in glibc). > >> Perhaps someone who previously encountered the FAILs on this testcase > >> can confirm that it's skipped with this change? > > > > Since libqaudmath provides , I prefer either of 2 patches > > enclosed here. > > Of these two, the first one looks better to me, and seems to work OK in > my x86 build. But, I'm not sure it is the right thing for ARM/Aarch64 > targets, which apparently have _Float128 support without the __float128 > type or libquadmath. It's pretty clear quadmath.h depends on having > __float128. The only used by GCC is the one in libquadmath. I will check in my first patch tomorrow if there are no objections. > See Christophe's mail here: > > https://gcc.gnu.org/pipermail/fortran/2021-September/056467.html > > As I said in my last mail, I ran into some problems getting an aarch64 > toolchain built so I haven't been able to do any testing or experiments > on that target myself yet. :-( > > -Sandra --=20 H.J.