From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118048 invoked by alias); 24 May 2015 12:49:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118034 invoked by uid 89); 24 May 2015 12:49:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_40,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f181.google.com Received: from mail-ob0-f181.google.com (HELO mail-ob0-f181.google.com) (209.85.214.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 24 May 2015 12:49:36 +0000 Received: by obfe9 with SMTP id e9so39602015obf.1 for ; Sun, 24 May 2015 05:49:34 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.178.33 with SMTP id cv1mr12332701oec.11.1432471774239; Sun, 24 May 2015 05:49:34 -0700 (PDT) Received: by 10.76.160.68 with HTTP; Sun, 24 May 2015 05:49:34 -0700 (PDT) In-Reply-To: <20150522120032.GB75713@kam.mff.cuni.cz> References: <20150521181437.GB8821@kam.mff.cuni.cz> <20150522120032.GB75713@kam.mff.cuni.cz> Date: Sun, 24 May 2015 13:33:00 -0000 Message-ID: Subject: Re: Calculate TYPE_CANONICAL only for types that can be accessed in memory From: "H.J. Lu" To: Jan Hubicka Cc: Richard Biener , GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg02215.txt.bz2 On Fri, May 22, 2015 at 5:00 AM, Jan Hubicka wrote: >> Now we have it spelled out 4 times ... makes sense to create a new >> macro for it? (though I cannot think of a good name... >> UNACCESSIBLE_TYPE_P ()?) > > Yep, actually I already made that version of patch yesterday but then got > hooked by beers. This is better version (also with more sensible comments). > I will commit it at afternoon if you have no further comments. > > > * lto.c (hash_canonical_type): Be sure we hash only types that > need alias set. > (gimple_register_canonical_type_1): Do not produce canonical > types for types that do not need alias sets. > * tree.c (gimple_canonical_types_compatible_p): Sanity check that > we do not try to compute canonical type for type that does not need > alias set. > (verify_type): Drop FIXME for METHOD_TYPE, update FIXME for > FUNCITON_TYPE. > * tree.h (type_with_alias_set_p): New. This caused: https://gcc.gnu.org/ml/gcc-cvs/2015-05/msg00948.html H.J.