From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by sourceware.org (Postfix) with ESMTPS id 22902384640C for ; Wed, 3 Apr 2024 12:42:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 22902384640C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 22902384640C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712148142; cv=none; b=J7MUf4AvuwueGLHk7gq5ytVADXCXLDpuj9OvUkQhD10sE8OHkuM6fdzMIEG5oNyDNaglY/hpIrYnInCvqf19Lwi8MiCN3Cp6KQKiJMcOkToIkvHqIrbyB9Kj2lxaDHNzOdsTqH6PoaDd6NcD/JKJaHui2Kmi7FYgOsqqnBSjuoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712148142; c=relaxed/simple; bh=R3oYZHHGnNK3l0VH8MeNmUhUuDSowZYkvkeqRMCY13M=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=FqoP0vpwmPRiAeOnaxdlWN1x23brN8XrEmdVP6w1Z8DGeCCT0I46165OEoOkDJ66GI/P1MVz11H24IQ7626xG6wXieqh4vQ0KZcCJOdniSW4aML6QOvFcp7Ro/i+sBMY32dl5bhAaJ/z0zGXRFBufqeVhu8lAGkjCAFYi1B801w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-60a104601dcso64848757b3.2 for ; Wed, 03 Apr 2024 05:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712148138; x=1712752938; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hxLhNTnmO632gdnhziVQCyk/bT0o85shfMppuu6tlgU=; b=fGSkTYXzFh/Xf9E45igNbcLq8/r2P73YBCJ/1FC/bbXPceAUK5CexRvIsfYQapVH50 4qzudBje9sfhFOg9L2Qs4pLMeZXK+uJJvXntoqyPb9IKLzd6B5ZPR1RijeanPpU2LZmG /SmzIQ9LnsyM6p4rWjr5nbBMiR399QU2Y/CsaOa5hmvCyAeKJ9mdgI9o6GRP/yHSgSVo xfY5rV0OfVE4diEZWcDJnMIIEXHtl83zLw0AT2rKN/yY0YN3zmMa8DIWYxWTl8sDuPU8 LjiDiqNEnJCkTpGO44+nGLTl27M10P35nQJEdZPu7Cg0iVkuuznbgBKzwYfADk6f4LFK U/Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712148138; x=1712752938; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hxLhNTnmO632gdnhziVQCyk/bT0o85shfMppuu6tlgU=; b=QHdxbu58m28bTt9s4q8vu/2Dq/L0MN/jZHDWgSuPNsn3TvkDu0AbN0WK1iMLoX8rz7 Fkd4jXNrriR34qVvgToJ/IWeq2SLV2sAuFSNgBrbvQGaWfagASJ8SDqLaREBZibOvTsb jfeYNMBYrPQjSoNXjR9ttFT4ibMjS8q0ZSFsUXFR+rzsrsZQCwKxPjRxS8mrVT/LiGUB XcelQC0+dOMF1tSVImqtkNCsxanuOVCcJJMsQBvJR5kaFttahUunOKun2GRWu2y9jMRx ZC2vACL+Gyou9uAGkwMXgWEXrZscD0RRg6e1XeKA4uRsroKCBmImCGY/zQCZYSYc2+bE lbmQ== X-Gm-Message-State: AOJu0YywjzDpsLrhYCzFDhW4XxKywgSyOD3DLIZD3yqsesfzrOqvv8Jt 84MDbaPm0iZOXKwxnpqYc5Nz2zEj//JRTRwg62aeSyPHIUtnrypKMiX3FpIOhohn95/vyGS9mzr 5AbKRn2xmNYyHlfNrVy8rLPkGUVgzQ8ZfYEc= X-Google-Smtp-Source: AGHT+IH79dYyK9bk7ZCD9dK9UdAI4z+j158t6QwnYmb7/ZUou34k5I0RUCC0OX669MG9JLoht/1cRS1/MnUR2B+qKfc= X-Received: by 2002:a25:7184:0:b0:dc7:497e:cddf with SMTP id m126-20020a257184000000b00dc7497ecddfmr12318593ybc.33.1712148138156; Wed, 03 Apr 2024 05:42:18 -0700 (PDT) MIME-Version: 1.0 References: <20240305214521.326316-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 3 Apr 2024 05:41:41 -0700 Message-ID: Subject: Re: PING: [PATCH v2] tree-profile: Don't instrument an IFUNC resolver nor its callees To: Jan Hubicka Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3013.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 2, 2024 at 10:03=E2=80=AFAM Jan Hubicka wrote: > > > > I am bit worried about commonly used functions getting "infected" by > > > being called once from ifunc resolver. I think we only use thread lo= cal > > > storage for indirect call profiling, so we may just disable indirect > > > call profiling for these functions. > > > > Will change it. > > > > > Also the patch will be noop with -flto -flto-partition=3Dmax, so prob= ably > > > we need to compute this flag at WPA time and stream to partitions. > > > > > > > Why is it a nop with -flto -flto-partition=3Dmax? I got > > > > (gdb) bt > > #0 symtab_node::check_ifunc_callee_symtab_nodes () > > at /export/gnu/import/git/gitlab/x86-gcc/gcc/symtab.cc:1440 > > #1 0x0000000000e487d3 in symbol_table::compile (this=3D0x7fffea006000) > > at /export/gnu/import/git/gitlab/x86-gcc/gcc/cgraphunit.cc:2320 > > #2 0x0000000000d23ecf in lto_main () > > at /export/gnu/import/git/gitlab/x86-gcc/gcc/lto/lto.cc:687 > > #3 0x00000000015254d2 in compile_file () > > at /export/gnu/import/git/gitlab/x86-gcc/gcc/toplev.cc:449 > > #4 0x00000000015284a4 in do_compile () > > at /export/gnu/import/git/gitlab/x86-gcc/gcc/toplev.cc:2154 > > #5 0x0000000001528864 in toplev::main (this=3D0x7fffffffd84a, argc=3D1= 6, > > argv=3D0x42261f0) at /export/gnu/import/git/gitlab/x86-gcc/gcc/topl= ev.cc:2310 > > #6 0x00000000030a3fe2 in main (argc=3D16, argv=3D0x7fffffffd958) > > at /export/gnu/import/git/gitlab/x86-gcc/gcc/main.cc:39 > > > > Do you have a testcase to show that it is a nop? > Aha, sorry. I tought this is run during late optimization, but it is > done early, so LTo partitioning does not mix things up. So current > patch modified to disable only instrumentation that needs TLS should be > fine. > Done. Here is the v3 patch: https://gcc.gnu.org/pipermail/gcc-patches/2024-April/648733.html --=20 H.J.