public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: i386: Fix gcc.target/i386/pieces-memset-1.c etc. on Solaris [PR102836]
@ 2021-10-25 13:46 Rainer Orth
  2021-10-25 13:48 ` H.J. Lu
  0 siblings, 1 reply; 2+ messages in thread
From: Rainer Orth @ 2021-10-25 13:46 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

Several of the gcc.target/i386/pieces-memset-*.c tests FAIL on 32-bit
Solaris/x86:

FAIL: gcc.target/i386/pieces-memset-1.c scan-assembler-not %[re]bp
FAIL: gcc.target/i386/pieces-memset-4.c scan-assembler-not %[re]bp
FAIL: gcc.target/i386/pieces-memset-41.c scan-assembler-not %[re]bp
FAIL: gcc.target/i386/pieces-memset-7.c scan-assembler-not %[re]bp
FAIL: gcc.target/i386/pieces-memset-8.c scan-assembler-not %[re]bp
FAIL: gcc.target/i386/pr90773-1.c scan-assembler-times movq[\\\\t ]+7\\\\(%[^,]+\\\\), 1
FAIL: gcc.target/i386/pr90773-1.c scan-assembler-times movq[\\\\t ]+\\\\(%[^,]+\\\\), 1

Fixed by compiling with -mno-stackrealign.  Tested no
i386-pc-solaris2.11 and x86_64-pc-linux-gnu.

Ok for master?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2021-10-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	gcc/testsuite:
	PR testsuite/102836
	* gcc.target/i386/pieces-memset-1.c: Add -mno-stackrealign to
	dg-options.
	* gcc.target/i386/pieces-memset-4.c: Likewise.
	* gcc.target/i386/pieces-memset-7.c: Likewise.
	* gcc.target/i386/pieces-memset-8.c: Likewise.
	* gcc.target/i386/pieces-memset-41.c: Likewise.
	* gcc.target/i386/pr90773-1.c: Likewise.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: testsuite-i386-pieces-memset-sra.patch --]
[-- Type: text/x-patch, Size: 2645 bytes --]

# HG changeset patch
# Parent  36b044e6c2ffe7fb4c59b9e83604e747575dbb35
testsuite: i386: Fix gcc.target/i386/pieces-memset-1.c etc. on Solaris [PR102836]

diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-1.c b/gcc/testsuite/gcc.target/i386/pieces-memset-1.c
--- a/gcc/testsuite/gcc.target/i386/pieces-memset-1.c
+++ b/gcc/testsuite/gcc.target/i386/pieces-memset-1.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -mno-avx -msse2 -mtune=generic" } */
+/* { dg-options "-O2 -mno-avx -msse2 -mtune=generic -mno-stackrealign" } */
 
 extern char *dst;
 
diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-4.c b/gcc/testsuite/gcc.target/i386/pieces-memset-4.c
--- a/gcc/testsuite/gcc.target/i386/pieces-memset-4.c
+++ b/gcc/testsuite/gcc.target/i386/pieces-memset-4.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -mno-avx -msse2 -mtune=generic" } */
+/* { dg-options "-O2 -mno-avx -msse2 -mtune=generic -mno-stackrealign" } */
 
 extern char *dst;
 
diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-41.c b/gcc/testsuite/gcc.target/i386/pieces-memset-41.c
--- a/gcc/testsuite/gcc.target/i386/pieces-memset-41.c
+++ b/gcc/testsuite/gcc.target/i386/pieces-memset-41.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -mno-avx2 -mavx -mtune=sandybridge" } */
+/* { dg-options "-O2 -mno-avx2 -mavx -mtune=sandybridge -mno-stackrealign" } */
 
 extern char *dst;
 
diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-7.c b/gcc/testsuite/gcc.target/i386/pieces-memset-7.c
--- a/gcc/testsuite/gcc.target/i386/pieces-memset-7.c
+++ b/gcc/testsuite/gcc.target/i386/pieces-memset-7.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -mno-avx -msse2 -mtune=generic" } */
+/* { dg-options "-O2 -mno-avx -msse2 -mtune=generic -mno-stackrealign" } */
 
 extern char *dst;
 
diff --git a/gcc/testsuite/gcc.target/i386/pieces-memset-8.c b/gcc/testsuite/gcc.target/i386/pieces-memset-8.c
--- a/gcc/testsuite/gcc.target/i386/pieces-memset-8.c
+++ b/gcc/testsuite/gcc.target/i386/pieces-memset-8.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -mno-avx2 -mavx -mtune=generic" } */
+/* { dg-options "-O2 -mno-avx2 -mavx -mtune=generic -mno-stackrealign" } */
 
 extern char *dst;
 
diff --git a/gcc/testsuite/gcc.target/i386/pr90773-1.c b/gcc/testsuite/gcc.target/i386/pr90773-1.c
--- a/gcc/testsuite/gcc.target/i386/pr90773-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr90773-1.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { dg-options "-O2 -msse2 -mtune=generic" } */
+/* { dg-options "-O2 -msse2 -mtune=generic -mno-stackrealign" } */
 
 extern char *dst, *src;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] testsuite: i386: Fix gcc.target/i386/pieces-memset-1.c etc. on Solaris [PR102836]
  2021-10-25 13:46 [PATCH] testsuite: i386: Fix gcc.target/i386/pieces-memset-1.c etc. on Solaris [PR102836] Rainer Orth
@ 2021-10-25 13:48 ` H.J. Lu
  0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2021-10-25 13:48 UTC (permalink / raw)
  To: Rainer Orth; +Cc: GCC Patches

On Mon, Oct 25, 2021 at 6:46 AM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
> Several of the gcc.target/i386/pieces-memset-*.c tests FAIL on 32-bit
> Solaris/x86:
>
> FAIL: gcc.target/i386/pieces-memset-1.c scan-assembler-not %[re]bp
> FAIL: gcc.target/i386/pieces-memset-4.c scan-assembler-not %[re]bp
> FAIL: gcc.target/i386/pieces-memset-41.c scan-assembler-not %[re]bp
> FAIL: gcc.target/i386/pieces-memset-7.c scan-assembler-not %[re]bp
> FAIL: gcc.target/i386/pieces-memset-8.c scan-assembler-not %[re]bp
> FAIL: gcc.target/i386/pr90773-1.c scan-assembler-times movq[\\\\t ]+7\\\\(%[^,]+\\\\), 1
> FAIL: gcc.target/i386/pr90773-1.c scan-assembler-times movq[\\\\t ]+\\\\(%[^,]+\\\\), 1
>
> Fixed by compiling with -mno-stackrealign.  Tested no
> i386-pc-solaris2.11 and x86_64-pc-linux-gnu.
>
> Ok for master?
>
>         Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2021-10-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>         gcc/testsuite:
>         PR testsuite/102836
>         * gcc.target/i386/pieces-memset-1.c: Add -mno-stackrealign to
>         dg-options.
>         * gcc.target/i386/pieces-memset-4.c: Likewise.
>         * gcc.target/i386/pieces-memset-7.c: Likewise.
>         * gcc.target/i386/pieces-memset-8.c: Likewise.
>         * gcc.target/i386/pieces-memset-41.c: Likewise.
>         * gcc.target/i386/pr90773-1.c: Likewise.
>

LGTM.

Thanks.

-- 
H.J.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-25 13:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 13:46 [PATCH] testsuite: i386: Fix gcc.target/i386/pieces-memset-1.c etc. on Solaris [PR102836] Rainer Orth
2021-10-25 13:48 ` H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).