From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by sourceware.org (Postfix) with ESMTPS id B46843858427 for ; Fri, 26 Aug 2022 16:51:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B46843858427 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x72b.google.com with SMTP id m5so1563479qkk.1 for ; Fri, 26 Aug 2022 09:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=ba9A5p6INz5yBSt4Ezjy7yKoHnVSUCDPrC7nfYUF73w=; b=p166WJdGXo874+GBynhWbUd0KfYsD2q1D8hfUBTJdGPhKObfZuEmljMe1QHro2UiSw l+Tc50iwWG7eop5xcJFn8q3sz+yJzznWVRmwP3nI35trZBpg0mqqmfAMf4IIFSZVOu8m P0pbtzuvuOo7nIzrNFU3eZ5pIdFBGMTSIJxA9a5ax22vNdL4EUNxzpI0sjsot7GdjvoB n5KcGKyyMbXXpKRvSStHqoX9DpW88iI03hTRZgu2Vxt8O8FTETiSE+eBtZCu9d1beIX0 IyaV+IUUBZ1bXzsllURzZb1NkyOu4jTZVq8sbRwqTbKK4ZbTJEXBATFk2o7UUuUNdmYu Z39g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=ba9A5p6INz5yBSt4Ezjy7yKoHnVSUCDPrC7nfYUF73w=; b=cWEHb86S6lHVZx60yUqHNLUUN/2duw0McltiC4RlzETXoB/g5HJ99ZBAfarJVO9kr6 qSvawLwlwdTvGYPUa/Z5IXnjLMTdVnjGrBdfhA8yGOLAYmxbS1BpsPmJCPTPSUQjqG+0 87VTFn90FDMN8mqSgj8REWeBeTe6dwLOvwXkNipZU3NnmFKWWCetfur9Lx2ziB6JW7vW KxwBmSEl6V59nLR5dgQW23hMi5iIo7ed2zL1+ZjgTpZI6wJ4NFRLerAZZg3Q4IMolEi/ cfBbuEzvwppuKZ2NB/CB3ndFV9GG47uQuFFfmbg/0JB1adGdpC+3qIHhNqq3TKmWzltk 1E8w== X-Gm-Message-State: ACgBeo2wVY4QkDEU+LTh1F0s/6JuO/VKOc17i+bSAU+nv9bkdEMVGg2/ jAeFcNZI8vzDrNpEyDnN7tf9l5kqMQXpgTVFKOKFQ7b/ X-Google-Smtp-Source: AA6agR5IbVhDu0RBOoG+e4HAsOzq3XMBllXq5TW0gCCwcGk/z5Owqd1vr5KGProl1aMI1qRKMRMSHaU/ccg1RGy9ZwY= X-Received: by 2002:a05:620a:254d:b0:6ab:84b8:25eb with SMTP id s13-20020a05620a254d00b006ab84b825ebmr438354qko.383.1661532699987; Fri, 26 Aug 2022 09:51:39 -0700 (PDT) MIME-Version: 1.0 References: <20220822170244.670691-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Fri, 26 Aug 2022 09:51:04 -0700 Message-ID: Subject: Re: [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics To: Hongtao Liu Cc: GCC Patches , Uros Bizjak Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3024.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 22, 2022 at 7:05 PM Hongtao Liu wrote: > > On Tue, Aug 23, 2022 at 1:02 AM H.J. Lu wrote: > > > > On 64-bit Windows, long is 32 bits and can't be used as stride in memory > > operand when base is a pointer which is 64 bits. Cast stride to > > __PTRDIFF_TYPE__, instead of long. > Ok. > > > > PR target/106714 > > * config/i386/amxtileintrin.h (_tile_loadd_internal): Cast to > > __PTRDIFF_TYPE__. > > (_tile_stream_loadd_internal): Likewise. > > (_tile_stored_internal): Likewise. > > --- > > gcc/config/i386/amxtileintrin.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/gcc/config/i386/amxtileintrin.h b/gcc/config/i386/amxtileintrin.h > > index 7b5a39eba72..06f18aa9bfb 100644 > > --- a/gcc/config/i386/amxtileintrin.h > > +++ b/gcc/config/i386/amxtileintrin.h > > @@ -62,7 +62,7 @@ _tile_release (void) > > #define _tile_loadd_internal(dst,base,stride) \ > > __asm__ volatile \ > > ("{tileloadd\t(%0,%1,1), %%tmm"#dst"|tileloadd\t%%tmm"#dst", [%0+%1*1]}" \ > > - :: "r" ((const void*) (base)), "r" ((long) (stride))) > > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride))) > > > > #define _tile_stream_loadd(dst,base,stride) \ > > _tile_stream_loadd_internal (dst, base, stride) > > @@ -70,7 +70,7 @@ _tile_release (void) > > #define _tile_stream_loadd_internal(dst,base,stride) \ > > __asm__ volatile \ > > ("{tileloaddt1\t(%0,%1,1), %%tmm"#dst"|tileloaddt1\t%%tmm"#dst", [%0+%1*1]}" \ > > - :: "r" ((const void*) (base)), "r" ((long) (stride))) > > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride))) > > > > #define _tile_stored(dst,base,stride) \ > > _tile_stored_internal (dst, base, stride) > > @@ -78,7 +78,7 @@ _tile_release (void) > > #define _tile_stored_internal(src,base,stride) \ > > __asm__ volatile \ > > ("{tilestored\t%%tmm"#src", (%0,%1,1)|tilestored\t[%0+%1*1], %%tmm"#src"}" \ > > - :: "r" ((void*) (base)), "r" ((long) (stride)) \ > > + :: "r" ((void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)) \ > > : "memory") > > > > #define _tile_zero(dst) \ > > -- > > 2.37.2 > > > > > -- > BR, > Hongtao OK to backport it to GCC 12 branch? -- H.J.