From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-390826-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 23557 invoked by alias); 29 Jan 2015 18:28:32 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 22154 invoked by uid 89); 29 Jan 2015 18:28:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mail-oi0-f52.google.com
Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 29 Jan 2015 18:28:20 +0000
Received: by mail-oi0-f52.google.com with SMTP id h136so29624767oig.11;        Thu, 29 Jan 2015 10:28:18 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.182.233.202 with SMTP id ty10mr1339874obc.12.1422556098221; Thu, 29 Jan 2015 10:28:18 -0800 (PST)
Received: by 10.76.134.102 with HTTP; Thu, 29 Jan 2015 10:28:17 -0800 (PST)
In-Reply-To: <20150129182641.GP1746@tucnak.redhat.com>
References: <CAKOQZ8w9_5OJEfnWJ-rgBgVzOzQcEj984MQcp=R1w=0JLUU8mw@mail.gmail.com>	<54B77230.6070704@rub.de>	<CAKOQZ8wCM4+0guCsqzeFZjgUu-Y81NX9RbGhV-i7xz8_OVuMyQ@mail.gmail.com>	<54B83638.7080509@rub.de>	<54C8C89C.1000104@rub.de>	<CABtf2+R2kY+tv7Wk+rtnU6s55RbMmSgejqeWn11rqb7PHA-COA@mail.gmail.com>	<54CA737A.5060102@ubuntu.com>	<54CA767F.9040102@ubuntu.com>	<CAMe9rOohc7imtMstqRBJCnbUsms9DNDgYO=GcYmjao9b0c9Szg@mail.gmail.com>	<54CA78F1.1020204@ubuntu.com>	<20150129182641.GP1746@tucnak.redhat.com>
Date: Thu, 29 Jan 2015 19:55:00 -0000
Message-ID: <CAMe9rOrAGT7pq9v-NfJbfEKmPOk7Jv01yAHdpTfwWbM4cxu6ug@mail.gmail.com>
Subject: Re: [Ping] Port of VTV for Cygwin and MinGW
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Matthias Klose <doko@ubuntu.com>, Caroline Tice <cmtice@google.com>, 	Patrick Wollgast <patrick.wollgast@rub.de>, Kai Tietz <ktietz70@googlemail.com>, 	Benjamin De Kosnik <bkoz@gnu.org>, "jwakely@redhat.com >> Jonathan Wakely" <jwakely@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>, 	"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg02648.txt.bz2

On Thu, Jan 29, 2015 at 10:26 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Jan 29, 2015 at 07:16:17PM +0100, Matthias Klose wrote:
>> On 01/29/2015 07:12 PM, H.J. Lu wrote:
>> > On Thu, Jan 29, 2015 at 10:05 AM, Matthias Klose <doko@ubuntu.com> wrote:
>> >> that fixes the build failure. ok to commit?
>> >>
>> >> 2015-01-29  Matthias Klose  <doko@ubuntu.com>
>> >>
>> >>         * acinclude.m4 (GLIBCXX_ENABLE_VTABLE_VERIFY): Define VTV_CYGMIN
>> >>         unconditionally.
>> >>         * configure: Regenerate.
>> >>
>> >
>> >  This is wrong.  You are checking vtv_cygmin before it is defined.
>>
>> my bad, somebody should obviously build both variants ... now testing this variant.
>
> Even with this patch vtv_cygmin is uninitialized.  It will be likely empty
> string, unless somebody has vtv_cygmin in the environment, but it is better
> to initialize it, see the patch I've posted.
>
>> --- acinclude.m4        (revision 220257)
>> +++ acinclude.m4        (working copy)
>> @@ -2320,8 +2320,6 @@
>>    AC_MSG_CHECKING([for vtable verify support])
>>    AC_MSG_RESULT([$enable_vtable_verify])
>>
>> -  AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
>> -
>>    if test $enable_vtable_verify = yes; then
>>      case ${target_os} in
>>        cygwin*|mingw32*)
>> @@ -2341,6 +2339,8 @@
>>      VTV_CXXLINKFLAGS=
>>    fi
>>
>> +  AM_CONDITIONAL(VTV_CYGMIN, test $vtv_cygmin = yes)
>> +
>

Or we can just do

AM_CONDITIONAL(VTV_CYGMIN, test x$vtv_cygmin = xyes)


-- 
H.J.