From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 3EDD7385DC10 for ; Mon, 14 Mar 2022 14:32:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3EDD7385DC10 Received: by mail-pj1-x1031.google.com with SMTP id kx6-20020a17090b228600b001bf859159bfso17677651pjb.1 for ; Mon, 14 Mar 2022 07:32:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OokF4YMP+rARDyIw0MXKAYEkU+egCo2hg+4OX5o4PwA=; b=Y1N5A/wLwWssmutC4O36lvWJWXAMaZveR7g1fdUfBZA8tlaKgXvy0/gtHnvGaHOiZB 6+V/11Q58LqcHkesPuIuda2Fy58UCudBElAvH9xshNGTjhg0NixU2GtNh/r7XQhwe+Nh mYDLbOXgLYf+2j7asN7YMxfAwCU6o3iayPvClS1nPDOYoMMbnTTlsqUZcxgYioLs6NvU meNXsk1KjFiLcom5ESHz4zinwlYeL89406YVpyRQsx6DlFVR6M30KcsmjFJySJHuxisO PUOo3qCpx+vLtV1zkmujbwk0YubWOOziLuNn/0fIoJxOWlCuhRgEuObDPtDUhgdnl9Hj 1YuA== X-Gm-Message-State: AOAM5324uHSNZg3lQkJ3GD8z7Y5jD6OpAy42w84D9AVVTP3cRjyLhH+5 QNfyI5GNj2SaNNLQQwdR8C34Rjb7MbxDmNAJevtRQgwY2WY= X-Google-Smtp-Source: ABdhPJxq4p0g4RmTaHpIGmLPKRrX19/qI600Mgo9j2emZ/oIiIqgmOrJYUWde/NTjXBTAlK3id/Izv1UJRLMpAGoapY= X-Received: by 2002:a17:90a:74c7:b0:1bf:5532:3ae8 with SMTP id p7-20020a17090a74c700b001bf55323ae8mr35730077pjl.120.1647268376197; Mon, 14 Mar 2022 07:32:56 -0700 (PDT) MIME-Version: 1.0 References: <20220314134901.1252090-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Mon, 14 Mar 2022 07:32:20 -0700 Message-ID: Subject: Re: [PATCH] x86: Ignore OPTION_MASK_ISA_64BIT for -m32 when inlining To: Jakub Jelinek Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3026.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2022 14:32:58 -0000 On Mon, Mar 14, 2022 at 7:03 AM Jakub Jelinek wrote: > > On Mon, Mar 14, 2022 at 06:49:01AM -0700, H.J. Lu via Gcc-patches wrote: > > gcc/ > > > > PR target/104890 > > * config/i386/i386.cc (ix86_can_inline_p): Ignore > > OPTION_MASK_ISA_64BIT for -m32. > > > > gcc/testsuite/ > > > > PR target/104890 > > * gcc.target/i386/pr104890.c: New test. > > --- > > gcc/config/i386/i386.cc | 4 ++++ > > gcc/testsuite/gcc.target/i386/pr104890.c | 11 +++++++++++ > > 2 files changed, 15 insertions(+) > > create mode 100644 gcc/testsuite/gcc.target/i386/pr104890.c > > > > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > > index 23bedea92bd..f2bb4765e5b 100644 > > --- a/gcc/config/i386/i386.cc > > +++ b/gcc/config/i386/i386.cc > > @@ -587,6 +587,10 @@ ix86_can_inline_p (tree caller, tree callee) > > if (TARGET_GENERAL_REGS_ONLY_P (callee_opts->x_ix86_target_flags)) > > always_inline_safe_mask |= MASK_80387; > > > > + /* Ignore OPTION_MASK_ISA_64BIT for -m32. */ > > + if (!TARGET_64BIT) > > + always_inline_safe_mask |= OPTION_MASK_ISA_64BIT; > > This looks wrong. (1 << 1) in alwyas_inline_safe_mask and > *->x_target_flags is MASK_80387, not OPTION_MASK_ISA_64BIT. > > Jakub Here is the v2 patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-March/591716.html -- H.J.