From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com
 [IPv6:2607:f8b0:4864:20::62c])
 by sourceware.org (Postfix) with ESMTPS id 53562384D1B3
 for <gcc-patches@gcc.gnu.org>; Mon, 20 Jun 2022 14:03:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 53562384D1B3
Received: by mail-pl1-x62c.google.com with SMTP id k7so9838431plg.7
 for <gcc-patches@gcc.gnu.org>; Mon, 20 Jun 2022 07:03:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=lAj0aEevFt2S/1MNcPPWxUtdks2Wd0zVrTKW/m029Ck=;
 b=UjIMKjHC2dRuy6qSBZ9EYYHmQdJshteuFMvz6nvQ9QM5BbTDEVHDPg11O3m7ueKsCg
 R7l4CIJ99mf8WSZY9GkHfHVsFu3zN2rTTObBzM7pRcMITNXxOdNfb6Dd7sH0qE2jZiEF
 xDmpgRW+fBwfHRAL+fChNynfMLRWJ6LbtRn9UHefgw0oY8gGK25CQGcbaWqDpg9SM9NE
 MZ1sPZYoCiD3i8OwI5mc6mjnWJhtiN4sTSsZ3nvw+24ZnbImyqsb1Az3YN+efuJlSBq0
 xXl+pe5zpDS3hHENIJ0dmNZYlGaAZYr5pjmZH9Rcsy1fKzntmwgTttPKIkXz6GMjfO6G
 Kmyw==
X-Gm-Message-State: AJIora+7RltTk46kY6f/qGdVbMqhhEL0TetL8BhiOzYFdidcylzIEwEk
 QN/fgZfa87bEHVMcuA0PaoJqrAXZ34zju9ebd39Mu4/a
X-Google-Smtp-Source: AGRyM1tkh5yWVg+wLHExP2jZsjiC1Y9tYACMudKgSKE7kA9AP/jbCXRVVDOobO2BAOi7fvDwTRMwpTH0SOXv5CvwjHg=
X-Received: by 2002:a17:902:a502:b0:15e:c251:b769 with SMTP id
 s2-20020a170902a50200b0015ec251b769mr23678764plq.115.1655733802727; Mon, 20
 Jun 2022 07:03:22 -0700 (PDT)
MIME-Version: 1.0
References: <20220614192548.1929268-1-hjl.tools@gmail.com>
In-Reply-To: <20220614192548.1929268-1-hjl.tools@gmail.com>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 20 Jun 2022 07:02:47 -0700
Message-ID: <CAMe9rOrCE+VFfM0jV0qT0Ma43T4QOQEo+M3BUrFR2R6rFY8zYQ@mail.gmail.com>
Subject: PING^1 [PATCH] i386: Disallow sibcall when calling ifunc functions
 with PIC register
To: GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jun 2022 14:03:30 -0000

On Tue, Jun 14, 2022 at 12:25 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Disallow siball when calling ifunc functions with PIC register so that
> PIC register can be restored.
>
> gcc/
>
>         PR target/105960
>         * config/i386/i386.cc (ix86_function_ok_for_sibcall): Return
>         false if PIC register is used when calling ifunc functions.
>
> gcc/testsuite/
>
>         PR target/105960
>         * gcc.target/i386/pr105960.c: New test.
> ---
>  gcc/config/i386/i386.cc                  |  9 +++++++++
>  gcc/testsuite/gcc.target/i386/pr105960.c | 19 +++++++++++++++++++
>  2 files changed, 28 insertions(+)
>  create mode 100644 gcc/testsuite/gcc.target/i386/pr105960.c
>
> diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
> index 3d189e124e4..1ca7836e11e 100644
> --- a/gcc/config/i386/i386.cc
> +++ b/gcc/config/i386/i386.cc
> @@ -1015,6 +1015,15 @@ ix86_function_ok_for_sibcall (tree decl, tree exp)
>         }
>      }
>
> +  if (decl && ix86_use_pseudo_pic_reg ())
> +    {
> +      /* When PIC register is used, it must be restored after ifunc
> +        function returns.  */
> +       cgraph_node *node = cgraph_node::get (decl);
> +       if (node && node->ifunc_resolver)
> +        return false;
> +    }
> +
>    /* Otherwise okay.  That also includes certain types of indirect calls.  */
>    return true;
>  }
> diff --git a/gcc/testsuite/gcc.target/i386/pr105960.c b/gcc/testsuite/gcc.target/i386/pr105960.c
> new file mode 100644
> index 00000000000..db137a1642d
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr105960.c
> @@ -0,0 +1,19 @@
> +/* { dg-do compile } */
> +/* { dg-require-ifunc "" } */
> +/* { dg-options "-O2 -fpic" } */
> +
> +__attribute__((target_clones("default","fma")))
> +static inline double
> +expfull_ref(double x)
> +{
> +  return __builtin_pow(x, 0.1234);
> +}
> +
> +double
> +exp_ref(double x)
> +{
> +  return expfull_ref(x);
> +}
> +
> +/* { dg-final { scan-assembler "jmp\[ \t\]*expfull_ref@PLT" { target { ! ia32 } } } } */
> +/* { dg-final { scan-assembler "call\[ \t\]*expfull_ref@PLT" { target ia32 } } } */
> --
> 2.36.1
>

PING.

-- 
H.J.