From: "H.J. Lu" <hjl.tools@gmail.com>
To: Aaron Conole <aconole@redhat.com>
Cc: Nathan Sidwell <nathan@acm.org>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>,
Nathan Sidwell <nathan@codesourcery.com>
Subject: Re: [PATCH v2] gcov: Runtime configurable destination output
Date: Fri, 03 Jun 2016 15:00:00 -0000 [thread overview]
Message-ID: <CAMe9rOrJJZzj_QuohGW1UOfO0Lj2Cyp-1-jAdceR=qp1qe37aw@mail.gmail.com> (raw)
In-Reply-To: <f7t1t4s63na.fsf@redhat.com>
On Mon, May 23, 2016 at 11:16 AM, Aaron Conole <aconole@redhat.com> wrote:
> Nathan Sidwell <nathan@acm.org> writes:
>
>> On 05/19/16 14:40, Aaron Conole wrote:
>>> Nathan Sidwell <nathan@acm.org> writes:
>>
>>>>> +FILE *__gcov_error_file = NULL;
>>>>
>>>> Unless I'm missing something, isn't this only accessed from this file?
>>>> (So could be static with a non-underbarred name)
>>>
>>> Ack.
>>
>> I have a vague memory that perhaps the __gcov_error_file is seen from
>> other dynamic objects, and one of them gets to open/close it? I think
>> the closing function needs to reset it to NULL though? (In case it's
>> reactivated before the process exits)
>
> This is being introduced here, so the actual variable won't be seen,
> however you're correct - the APIs could still be called.
>
> I think there does exist a possibility that it can get re-activated
> before the process exits. So, I've changed it to have a proper block
> cope and to reset gcov_error_file to NULL.
>
>>>> And this protection here, makes me wonder what happens if one is
>>>> IN_GCOV_TOOL. Does it pay attention to GCOV_ERROR_FILE? That would
>>>> seem incorrect, and thus the above should be changed so that stderr is
>>>> unconditionally used when IN_GCOV_TOOL?
>>>
>>> You are correct. I will fix it.
>>
>> thanks.
>>
>>>>> +static void
>>>>> +gcov_error_exit(void)
>>>>> +{
>>>>> + if (__gcov_error_file && __gcov_error_file != stderr)
>>>>> + {
>>>>
>>>> Braces are not needed here.
>>
>> Unless of course my speculation about setting it to NULL is right.
>
> It is - I've fixed it, and will post the v3 patch shortly.
>
> Thank you for your help, Nathan!
>
It breaks profiledbootstrap:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71400
--
H.J.
next prev parent reply other threads:[~2016-06-03 15:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 21:52 Aaron Conole
2016-04-15 19:02 ` Aaron Conole
2016-04-27 20:59 ` Aaron Conole
2016-04-28 13:25 ` Nathan Sidwell
2016-04-29 15:08 ` Aaron Conole
2016-05-04 15:22 ` Nathan Sidwell
2016-05-04 15:25 ` Jan Hubicka
2016-05-06 13:18 ` Nathan Sidwell
2016-05-19 18:40 ` Aaron Conole
2016-05-19 19:25 ` Jeff Law
2016-05-19 23:14 ` Nathan Sidwell
2016-05-20 1:11 ` Jeff Law
2016-05-19 23:17 ` Nathan Sidwell
2016-05-23 18:16 ` Aaron Conole
2016-06-03 15:00 ` H.J. Lu [this message]
2016-06-03 15:31 ` Aaron Conole
2016-06-04 12:12 ` Aaron Conole
2016-06-06 15:25 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrJJZzj_QuohGW1UOfO0Lj2Cyp-1-jAdceR=qp1qe37aw@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=aconole@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=nathan@acm.org \
--cc=nathan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).