From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98321 invoked by alias); 16 Oct 2015 10:52:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 98285 invoked by uid 89); 16 Oct 2015 10:52:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM autolearn=ham version=3.3.2 X-HELO: mail-ob0-f176.google.com Received: from Unknown (HELO mail-ob0-f176.google.com) (209.85.214.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 16 Oct 2015 10:50:33 +0000 Received: by obbwb3 with SMTP id wb3so61025333obb.0 for ; Fri, 16 Oct 2015 03:50:25 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.142.40 with SMTP id rt8mr9355495obb.12.1444992625553; Fri, 16 Oct 2015 03:50:25 -0700 (PDT) Received: by 10.76.175.132 with HTTP; Fri, 16 Oct 2015 03:50:25 -0700 (PDT) In-Reply-To: References: <20151016031234.GC45365@kam.mff.cuni.cz> Date: Fri, 16 Oct 2015 10:54:00 -0000 Message-ID: Subject: Re: Drop CONSTRUCTOR comparsion from ipa-icf-gimple From: "H.J. Lu" To: Richard Biener Cc: Jan Hubicka , GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01564.txt.bz2 On Fri, Oct 16, 2015 at 1:46 AM, Richard Biener wrote: > On Fri, Oct 16, 2015 at 5:12 AM, Jan Hubicka wrote: >> Hi, >> as Richard noticed in my port of the code to operand_equal_p, the checking of >> CONSTURCTOR in ipa-icf-gimple is incomplete missing the index checks. >> It is also unnecesary since non-empty ctors does not happen as gimple >> operands. This patch thus removes the unnecesary code. > > Err - they do happen, for vector constructors. Just empty constructors > are not allowed for vector constructors - vector constructors are required > to have elements in proper order and none left out. > > Sorry for misleading you. > >> Bootstrapped/regtested x86_64-linux, comitted. > > this will definitely ICE ... > And it did on x86: https://gcc.gnu.org/ml/gcc-regression/2015-10/msg00166.html FAIL: gcc.dg/pr63914.c (internal compiler error) FAIL: gcc.dg/pr63914.c (test for excess errors) FAIL: gcc.target/i386/avx-1.c (internal compiler error) FAIL: gcc.target/i386/avx-1.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v16sf-1.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v16sf-1.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v16sf-2.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v16sf-2.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v16sf-3.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v16sf-3.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v16si-1.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v16si-1.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v16si-2.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v16si-2.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v16si-3.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v16si-3.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v8df-1.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v8df-1.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v8df-2.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v8df-2.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v8df-3.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v8df-3.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v8di-1.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v8di-1.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v8di-2.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v8di-2.c (test for excess errors) FAIL: gcc.target/i386/avx512f-set-v8di-3.c (internal compiler error) FAIL: gcc.target/i386/avx512f-set-v8di-3.c (test for excess errors) FAIL: gcc.target/i386/sse-13.c (internal compiler error) FAIL: gcc.target/i386/sse-13.c (test for excess errors) FAIL: gcc.target/i386/sse-18.c (internal compiler error) FAIL: gcc.target/i386/sse-18.c (test for excess errors) FAIL: gcc.target/i386/sse-19.c (internal compiler error) FAIL: gcc.target/i386/sse-19.c (test for excess errors) FAIL: gcc.target/i386/sse-23.c (internal compiler error) FAIL: gcc.target/i386/sse-23.c (test for excess errors) FAIL: gcc.target/i386/sse-24.c (internal compiler error) FAIL: gcc.target/i386/sse-24.c (test for excess errors) FAIL: gcc.target/i386/sse-25.c (internal compiler error) FAIL: gcc.target/i386/sse-25.c (test for excess errors) FAIL: gcc.target/i386/vecinit-1.c (internal compiler error) FAIL: gcc.target/i386/vecinit-1.c (test for excess errors) FAIL: gcc.target/i386/vecinit-2.c (internal compiler error) FAIL: gcc.target/i386/vecinit-2.c (test for excess errors) FAIL: gcc.target/i386/vecinit-5.c (internal compiler error) FAIL: gcc.target/i386/vecinit-5.c (test for excess errors) FAIL: gcc.target/i386/vecinit-6.c (internal compiler error) FAIL: gcc.target/i386/vecinit-6.c (test for excess errors) -- H.J.