public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/3] function: Factor out make_*logue_seq
Date: Wed, 18 May 2016 18:20:00 -0000	[thread overview]
Message-ID: <CAMe9rOrQmt-avt-NSnRnQxmnL5g6TfJtPUMnY-MLfp_WuwyYCw@mail.gmail.com> (raw)
In-Reply-To: <20160518181139.GA24289@gate.crashing.org>

On Wed, May 18, 2016 at 11:11 AM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> On Wed, May 18, 2016 at 10:17:32AM -0700, H.J. Lu wrote:
>> On Mon, May 16, 2016 at 6:09 PM, Segher Boessenkool
>> <segher@kernel.crashing.org> wrote:
>> > Make new functions make_split_prologue_seq, make_prologue_seq, and
>> > make_epilogue_seq.
>> >
>> > Tested as in the previous patch; is this okay for trunk?
>> >
>> >
>> > Segher
>> >
>> >
>> > 2016-05-16  Segher Boessenkool  <segher@kernel.crashing.org>
>> >
>> >         * function.c (make_split_prologue_seq, make_prologue_seq,
>> >         make_epilogue_seq): New functions, factored out from...
>> >         (thread_prologue_and_epilogue_insns): Here.
>> >
>>
>> It breaks x86:
>
> Are you sure it is this patch causing it?  As noted, it was tested on x86.
>

I am pretty sure.  How did you test it on x86?  What do you get with

# make check-c++ RUNTESTFLAGS="dg.exp=ctor*.C --target_board='unix{-m32,}'"


-- 
H.J.

  reply	other threads:[~2016-05-18 18:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17  1:09 [PATCH 1/3] function: Do the CLEANUP_EXPENSIVE after shrink-wrapping, not before Segher Boessenkool
2016-05-17  1:09 ` [PATCH 2/3] function: Factor out make_*logue_seq Segher Boessenkool
2016-05-17 20:35   ` Jeff Law
2016-05-18 17:17   ` H.J. Lu
2016-05-18 18:11     ` Segher Boessenkool
2016-05-18 18:20       ` H.J. Lu [this message]
2016-05-18 18:24         ` H.J. Lu
2016-05-18 18:35         ` Segher Boessenkool
2016-05-18 22:13           ` Segher Boessenkool
2016-05-19  7:16             ` Jakub Jelinek
2016-05-19  7:28               ` Segher Boessenkool
2016-05-19  7:41                 ` Jakub Jelinek
2016-05-19 17:20               ` Jeff Law
2016-05-17  1:09 ` [PATCH 3/3] function: Restructure *logue insertion Segher Boessenkool
2016-05-19  8:04   ` Segher Boessenkool
2016-05-19 22:00   ` Jeff Law
2016-05-19 22:20     ` Segher Boessenkool
2016-05-20  9:28       ` Thomas Schwinge
2016-05-20 13:21         ` Thomas Schwinge
2016-05-20 14:47           ` Nathan Sidwell
2016-05-20 15:35             ` Segher Boessenkool
2016-05-20 21:27         ` Segher Boessenkool
2016-05-17  8:06 ` [PATCH 1/3] function: Do the CLEANUP_EXPENSIVE after shrink-wrapping, not before Eric Botcazou
2016-05-17  8:47   ` Segher Boessenkool
2016-05-17  9:08     ` Eric Botcazou
2016-05-17  9:18       ` Segher Boessenkool
2016-05-17 22:23         ` Segher Boessenkool
2016-05-17 22:34           ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOrQmt-avt-NSnRnQxmnL5g6TfJtPUMnY-MLfp_WuwyYCw@mail.gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).