From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id 7C3C23858C52 for ; Wed, 21 Sep 2022 22:12:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7C3C23858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x831.google.com with SMTP id g23so5151320qtu.2 for ; Wed, 21 Sep 2022 15:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=GHqGqYxwQoOdsWO3Yaoz+MH9KRC5YJR/ZDR90jJXk8I=; b=PJXc5RzEAJY22fDb1OFkI8nxdVQsVG4Iyl+azvYC4wjp2/nXttPrYvOrkSiSTeZoYI CSYTPMYkEWIXCLVs10KDRpc2NJvO62CIjK8rMaX9yfVLWpQdyemFNnmNsA0iE47G2PBd RzHseJ7TEhRUCQKYQZe0FWkUMEGi9ecP4XEMeFclOA028Rm8udN/HR7qPxFgUx2h+T4F Ty529WJoNBEO/i2PDE7vPbayoz62OGvRTrzee1Hppaa7W7lpekuoucTmEE9MF9X42UKm hrRjGyQe5nEcHCJJUJ5R/eXmzZ+tLogvX5S9SgGOyVjR+nnxkTm7f+YnkA1Z8EibDnGI VB2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=GHqGqYxwQoOdsWO3Yaoz+MH9KRC5YJR/ZDR90jJXk8I=; b=pfw5yl6l8nBcXLGvxZl/1CI0PKsaW/FtpoAAuBgpMUGBaEggMDbr4SiYMGaSkM/GmO 3tOdNqD71NEVkyisNHzn/Dx3ZqmW6ipuDunJtBx1SVA11UZePXObyjDbrGjU/CT5vzI9 mMN8ZTfHgD7FYjXbcfNwikZcMiH3gBkOlrQ6yxV9G9vC0XPzcLk0r1ZdAR1cHcSQIJZp 5ewMvhY5cvsaECgDKTCisJzOD//jtioCuG1e+fJjDQjccyod8iV7R/79I9Z2akKYyTdP bHqVIOXx8gfDOrTi59BLQK833PFZ8/oN+nN9wKPqlQog0egVsZVb4Z43KRYZmGqD9byP R+4w== X-Gm-Message-State: ACrzQf3E0Kkto9tkvksd1MtEpfwQ/MBOdi4Hi1GPSpEAR0Pw+oxpTCku reCqygSxzHWAnK3jbCP4oDmIO2EvjlhIHrDxFrM= X-Google-Smtp-Source: AMsMyM47+bcQLtHfT6IPFmyIcn4QADT7aZbSPo9Ec/w88c7Ny+x1CREu0s+rE8HYp46fMV26kc1EG6wTJf2wzE8xqD8= X-Received: by 2002:a05:622a:44c:b0:343:7b8e:2cb with SMTP id o12-20020a05622a044c00b003437b8e02cbmr422656qtx.617.1663798328962; Wed, 21 Sep 2022 15:12:08 -0700 (PDT) MIME-Version: 1.0 References: <20220902143639.2464892-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Wed, 21 Sep 2022 15:11:32 -0700 Message-ID: Subject: Re: [PATCH] Ignore debug insns with CONCAT and CONCATN for insn scheduling To: Jeff Law Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3018.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 7, 2022 at 10:03 AM Jeff Law via Gcc-patches wrote: > > > > On 9/2/2022 8:36 AM, H.J. Lu via Gcc-patches wrote: > > CONCAT and CONCATN never appear in the insn chain. They are only used > > in debug insn. Ignore debug insns with CONCAT and CONCATN for insn > > scheduling to avoid different insn orders with and without debug insn. > > > > gcc/ > > > > PR rtl-optimization/106746 > > * sched-deps.cc (sched_analyze_2): Ignore debug insns with CONCAT > > and CONCATN. > Shouldn't we be ignoring everything in a debug insn? I don't see why > CONCAT/CONCATN are special here. Debug insns are processed by insn scheduling. I think it is to improve debug experiences. It is just that there are no matching usages of CONCAT/CONCATN in non-debug insns. -- H.J.