From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28961 invoked by alias); 2 Sep 2014 22:39:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28950 invoked by uid 89); 2 Sep 2014 22:39:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f172.google.com Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 02 Sep 2014 22:39:12 +0000 Received: by mail-ob0-f172.google.com with SMTP id wo20so5456776obc.31 for ; Tue, 02 Sep 2014 15:39:10 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.108.232 with SMTP id hn8mr4749521obb.68.1409697550378; Tue, 02 Sep 2014 15:39:10 -0700 (PDT) Received: by 10.76.72.4 with HTTP; Tue, 2 Sep 2014 15:39:10 -0700 (PDT) In-Reply-To: References: <20140505202703.GR11802@redhat.com> <20140508181934.GD11802@redhat.com> Date: Tue, 02 Sep 2014 22:39:00 -0000 Message-ID: Subject: Re: [C PATCH] Don't reject valid code with _Alignas (PR c/61053) From: "H.J. Lu" To: Marek Polacek Cc: "Joseph S. Myers" , GCC Patches Content-Type: multipart/mixed; boundary=089e0153715abb5a1105021cc9ca X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00189.txt.bz2 --089e0153715abb5a1105021cc9ca Content-Type: text/plain; charset=UTF-8 Content-length: 790 On Tue, Sep 2, 2014 at 3:29 PM, H.J. Lu wrote: > On Thu, May 8, 2014 at 11:19 AM, Marek Polacek wrote: >> On Wed, May 07, 2014 at 11:31:38AM -0700, H.J. Lu wrote: >>> > OK, though I'm not sure if the "lp64" conditions are right in the testcase >>> >>> It should be !ia32 instead of lp64. >> >> Ok, I changed lp64 to ! { ia32 } and committed the patch now. >> >> Marek > > The change is insufficient for x32, which has the same alignments > for floating point types and the integer types with the same size as > x86-64. This patch is needed for x32. OK for trunk and 4.8 branch? > > > -- > H.J. > --- > 2014-09-02 H.J. Lu > > * gcc.dg/pr61053.c: Updated for x32. > Here is the patch as an attachment. -- H.J. --089e0153715abb5a1105021cc9ca Content-Type: text/x-patch; charset=US-ASCII; name="align.patch" Content-Disposition: attachment; filename="align.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hzlti8lq0 Content-length: 3107 MjAxNC0wOS0wMiAgSC5KLiBMdSAgPGhvbmdqaXUubHVAaW50ZWwuY29tPgoK CSogZ2NjLmRnL3ByNjEwNTMuYzogVXBkYXRlZCBmb3IgeDMyLgoKZGlmZiAt LWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3ByNjEwNTMuYyBiL2djYy90 ZXN0c3VpdGUvZ2NjLmRnL3ByNjEwNTMuYwppbmRleCA0ZmQ1MzE5Li41NTU3 Nzg0IDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjYxMDUz LmMKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHI2MTA1My5jCkBAIC0z MSwxNyArMzEsMTcgQEAgX0FsaWduYXMgKGxvbmcgZG91YmxlKSBpbnQgaWxk OwogCiBfQWxpZ25hcyAoY2hhcikgbG9uZyBpbnQgbGljOyAvKiB7IGRnLWVy cm9yICJjYW5ub3QgcmVkdWNlIGFsaWdubWVudCIgfSAqLwogX0FsaWduYXMg KHNob3J0IGludCkgbG9uZyBpbnQgbGlzOyAvKiB7IGRnLWVycm9yICJjYW5u b3QgcmVkdWNlIGFsaWdubWVudCIgfSAqLwotX0FsaWduYXMgKGludCkgbG9u ZyBpbnQgbGlpOyAvKiB7IGRnLWVycm9yICJjYW5ub3QgcmVkdWNlIGFsaWdu bWVudCIgIiIgeyB0YXJnZXQgeyAhIHsgaWEzMiB9IH0gfSB9ICovCitfQWxp Z25hcyAoaW50KSBsb25nIGludCBsaWk7IC8qIHsgZGctZXJyb3IgImNhbm5v dCByZWR1Y2UgYWxpZ25tZW50IiAiIiB7IHRhcmdldCB7ICEgeyBpYTMyIHx8 IHgzMiB9IH0gfSB9ICovCiBfQWxpZ25hcyAobG9uZyBpbnQpIGxvbmcgaW50 IGxpbDsKIF9BbGlnbmFzIChsb25nIGxvbmcgaW50KSBsb25nIGludCBsaWxs OwotX0FsaWduYXMgKGZsb2F0KSBsb25nIGludCBsaWY7IC8qIHsgZGctZXJy b3IgImNhbm5vdCByZWR1Y2UgYWxpZ25tZW50IiAiIiB7IHRhcmdldCB7ICEg eyBpYTMyIH0gfSB9IH0gKi8KK19BbGlnbmFzIChmbG9hdCkgbG9uZyBpbnQg bGlmOyAvKiB7IGRnLWVycm9yICJjYW5ub3QgcmVkdWNlIGFsaWdubWVudCIg IiIgeyB0YXJnZXQgeyAhIHsgaWEzMiB8fCB4MzIgfSB9IH0gfSAqLwogX0Fs aWduYXMgKGRvdWJsZSkgbG9uZyBpbnQgbGlkOwogX0FsaWduYXMgKGxvbmcg ZG91YmxlKSBsb25nIGludCBsaWxkOwogCiBfQWxpZ25hcyAoY2hhcikgbG9u ZyBsb25nIGludCBsbGljOyAvKiB7IGRnLWVycm9yICJjYW5ub3QgcmVkdWNl IGFsaWdubWVudCIgfSAqLwogX0FsaWduYXMgKHNob3J0IGludCkgbG9uZyBs b25nIGludCBsbGlzOyAvKiB7IGRnLWVycm9yICJjYW5ub3QgcmVkdWNlIGFs aWdubWVudCIgfSAqLwogX0FsaWduYXMgKGludCkgbG9uZyBsb25nIGludCBs bGlpOyAvKiB7IGRnLWVycm9yICJjYW5ub3QgcmVkdWNlIGFsaWdubWVudCIg IiIgeyB0YXJnZXQgeyAhIHsgaWEzMiB9IH0gfSB9ICovCi1fQWxpZ25hcyAo bG9uZyBpbnQpIGxvbmcgbG9uZyBpbnQgbGxpbDsKK19BbGlnbmFzIChsb25n IGludCkgbG9uZyBsb25nIGludCBsbGlsOyAvKiB7IGRnLWVycm9yICJjYW5u b3QgcmVkdWNlIGFsaWdubWVudCIgIiIgeyB0YXJnZXQgeyB4MzIgfSB9IH0g Ki8KIF9BbGlnbmFzIChsb25nIGxvbmcgaW50KSBsb25nIGxvbmcgaW50IGxs aWxsOwogX0FsaWduYXMgKGZsb2F0KSBsb25nIGxvbmcgaW50IGxsaWY7IC8q IHsgZGctZXJyb3IgImNhbm5vdCByZWR1Y2UgYWxpZ25tZW50IiAiIiB7IHRh cmdldCB7ICEgeyBpYTMyIH0gfSB9IH0gKi8KIF9BbGlnbmFzIChkb3VibGUp IGxvbmcgbG9uZyBpbnQgbGxpZDsKQEAgLTU5LDcgKzU5LDcgQEAgX0FsaWdu YXMgKGxvbmcgZG91YmxlKSBmbG9hdCBmbGQ7CiBfQWxpZ25hcyAoY2hhcikg ZG91YmxlIGRjOyAvKiB7IGRnLWVycm9yICJjYW5ub3QgcmVkdWNlIGFsaWdu bWVudCIgfSAqLwogX0FsaWduYXMgKHNob3J0IGludCkgZG91YmxlIGRzOyAv KiB7IGRnLWVycm9yICJjYW5ub3QgcmVkdWNlIGFsaWdubWVudCIgfSAqLwog X0FsaWduYXMgKGludCkgZG91YmxlIGRpOyAvKiB7IGRnLWVycm9yICJjYW5u b3QgcmVkdWNlIGFsaWdubWVudCIgIiIgeyB0YXJnZXQgeyAhIHsgaWEzMiB9 IH0gfSB9ICovCi1fQWxpZ25hcyAobG9uZyBpbnQpIGRvdWJsZSBkbDsKK19B bGlnbmFzIChsb25nIGludCkgZG91YmxlIGRsOyAvKiB7IGRnLWVycm9yICJj YW5ub3QgcmVkdWNlIGFsaWdubWVudCIgIiIgeyB0YXJnZXQgeyB4MzIgfSB9 IH0gKi8KIF9BbGlnbmFzIChsb25nIGxvbmcgaW50KSBkb3VibGUgZGxsOwog X0FsaWduYXMgKGZsb2F0KSBkb3VibGUgZGY7IC8qIHsgZGctZXJyb3IgImNh bm5vdCByZWR1Y2UgYWxpZ25tZW50IiAiIiB7IHRhcmdldCB7ICEgeyBpYTMy IH0gfSB9IH0gKi8KIF9BbGlnbmFzIChkb3VibGUpIGRvdWJsZSBkZDsK --089e0153715abb5a1105021cc9ca--