From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-297638-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 26284 invoked by alias); 22 Jul 2011 00:37:01 -0000
Received: (qmail 26273 invoked by uid 22791); 22 Jul 2011 00:37:01 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-fx0-f49.google.com (HELO mail-fx0-f49.google.com) (209.85.161.49)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jul 2011 00:36:47 +0000
Received: by fxd20 with SMTP id 20so3338922fxd.22        for <gcc-patches@gcc.gnu.org>; Thu, 21 Jul 2011 17:36:46 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.204.135.18 with SMTP id l18mr245306bkt.191.1311295005746; Thu, 21 Jul 2011 17:36:45 -0700 (PDT)
Received: by 10.204.41.6 with HTTP; Thu, 21 Jul 2011 17:36:45 -0700 (PDT)
In-Reply-To: <4E28BB66.4010504@redhat.com>
References: <20110709212846.GA3563@intel.com>	<CAFULd4asstEQNQ7k7t_X93OybMu6YDJMsTEiOqMdJ3q1Ky1ECw@mail.gmail.com>	<CAMe9rOqJrnd1mCN17GD8k72PvLH8gSFqpuDgoJa8mF_bBgrfOw@mail.gmail.com>	<4E1A1D43.3010106@redhat.com>	<CAMe9rOqHCCcZr0_zS3xum20=HtP7WcZ1WEdU4ZRhbnLW3LQPGA@mail.gmail.com>	<4E1A4864.2030702@redhat.com>	<CAMe9rOqKiepY_m9Gjkh2s-MEF4-+tJb2kOeP1_SBu7VScvmuLg@mail.gmail.com>	<CAMe9rOrbDCQowYbk53STuzJ_=7DHUncx3sDjOZcf3JOyva3Niw@mail.gmail.com>	<4E1DB962.6010808@redhat.com>	<CAMe9rOriQy4hVmB9o=29KXWw7HjnineFE2S1aY+5cN2sPWdbUA@mail.gmail.com>	<4E1DBBC9.4030305@redhat.com>	<CAMe9rOqn4UjBKfKdoCmETfuddZQP20ws2xjk76s8Eor1_xT_Jg@mail.gmail.com>	<4E28A291.5080700@redhat.com>	<CAMe9rOodOZk8i39C+QuTGywq6KirST-Q-SVQjSzip50=97wC1w@mail.gmail.com>	<4E28BB66.4010504@redhat.com>
Date: Fri, 22 Jul 2011 04:22:00 -0000
Message-ID: <CAMe9rOraHEgf81TfF9snGFUqS-rFqqEbtihiyPtn9BTM7-mA5w@mail.gmail.com>
Subject: Re: PATCH [3/n] X32: Promote pointers to Pmode
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Richard Henderson <rth@redhat.com>
Cc: Uros Bizjak <ubizjak@gmail.com>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-07/txt/msg01907.txt.bz2

On Thu, Jul 21, 2011 at 4:51 PM, Richard Henderson <rth@redhat.com> wrote:
> On 07/21/2011 04:28 PM, H.J. Lu wrote:
>> On Thu, Jul 21, 2011 at 3:05 PM, Richard Henderson <rth@redhat.com> wrot=
e:
>>> On 07/21/2011 03:02 PM, H.J. Lu wrote:
>>>> =A0 =A0 =A0 * config/i386/i386.c (function_value_64): Always return po=
inters
>>>> =A0 =A0 =A0 in Pmode.
>>>> =A0 =A0 =A0 (ix86_promote_function_mode): New.
>>>> =A0 =A0 =A0 (TARGET_PROMOTE_FUNCTION_MODE): Likewise.
>>>
>>> Much better, thanks.
>>>
>>>
>>> r~
>>>
>>
>> Also need this patch. =A0Otherwise, I got
>>
>> FAIL: gcc.target/x86_64/abi/callabi/func-indirect-2a.c (internal compile=
r error)
>> FAIL: gcc.target/x86_64/abi/callabi/func-indirect-2a.c (test for excess =
errors)
>> FAIL: gcc.target/x86_64/abi/callabi/func-indirect-2b.c (internal compile=
r error)
>> FAIL: gcc.target/x86_64/abi/callabi/func-indirect-2b.c (test for excess =
errors)
>>
>> OK for trunk?
>
> Hmm. =A0Should we even be running ms_64 callabi tests across pointer size=
s though?
>

Good question.  I can disable the test.  But compiler will still ICE on this
input.


--=20
H.J.