From: "H.J. Lu" <hjl.tools@gmail.com>
To: Lili Cui <lili.cui@intel.com>
Cc: Uros Bizjak <ubizjak@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Hongtao Liu <hongtao.liu@intel.com>
Subject: Re: [PATCH 4/4] [PATCH 4/4] x86: Add TARGET_SSE_PARTIAL_REG_[FP_]CONVERTS_DEPENDENCY
Date: Wed, 15 Sep 2021 07:13:59 -0700 [thread overview]
Message-ID: <CAMe9rOra_SCyW9VzDG0fDaFogg9tb5j2dQwLE33oRUUsMVxR4g@mail.gmail.com> (raw)
In-Reply-To: <20210915080951.10362-5-lili.cui@intel.com>
There is no need to add [PATCH N/4] in the first line of the git
commit message. "git format-patch" or "git send-email" will
add them automatically.
On Wed, Sep 15, 2021 at 1:10 AM <lili.cui@intel.com> wrote:
>
> From: "H.J. Lu" <hjl.tools@gmail.com>
>
> 1. Replace TARGET_SSE_PARTIAL_REG_DEPENDENCY with
> TARGET_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY in SSE FP to FP splitters.
> 2. Replace TARGET_SSE_PARTIAL_REG_DEPENDENCY with
> TARGET_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY in SSE INT to FP splitters.
> 3. Also check TARGET_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY and
> TARGET_SSE_PARTIAL_REG_DEPENDENCY when handling avx_partial_xmm_update
> attribute. Don't convert AVX partial XMM register update if there is no
> partial SSE register dependency for SSE conversion.
>
> gcc/
>
> * config/i386/i386-features.c (remove_partial_avx_dependency):
> Also check TARGET_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY and
> and TARGET_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY before generating
> vxorps.
> * config/i386/i386.h (TARGET_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY):
> New.
> (TARGET_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY): Likewise.
> * config/i386/i386.md (SSE FP to FP splitters): Replace
> TARGET_SSE_PARTIAL_REG_DEPENDENCY with
> TARGET_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY.
> (SSE INT to FP splitter): Replace TARGET_SSE_PARTIAL_REG_DEPENDENCY
> with TARGET_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY.
> * config/i386/x86-tune.def
> (X86_TUNE_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY): New.
> (X86_TUNE_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY): Likewise.
>
> gcc/testsuite/
>
> * gcc.target/i386/avx-covert-1.c: New file.
> * gcc.target/i386/avx-fp-covert-1.c: Likewise.
> * gcc.target/i386/avx-int-covert-1.c: Likewise.
> * gcc.target/i386/sse-covert-1.c: Likewise.
> * gcc.target/i386/sse-fp-covert-1.c: Likewise.
> * gcc.target/i386/sse-int-covert-1.c: Likewise.
> ---
> gcc/config/i386/i386-features.c | 6 ++++--
> gcc/config/i386/i386.h | 4 ++++
> gcc/config/i386/i386.md | 9 ++++++---
> gcc/config/i386/x86-tune.def | 15 +++++++++++++++
> gcc/testsuite/gcc.target/i386/avx-covert-1.c | 19 +++++++++++++++++++
> .../gcc.target/i386/avx-fp-covert-1.c | 15 +++++++++++++++
> .../gcc.target/i386/avx-int-covert-1.c | 14 ++++++++++++++
> gcc/testsuite/gcc.target/i386/sse-covert-1.c | 19 +++++++++++++++++++
> .../gcc.target/i386/sse-fp-covert-1.c | 15 +++++++++++++++
> .../gcc.target/i386/sse-int-covert-1.c | 14 ++++++++++++++
> 10 files changed, 125 insertions(+), 5 deletions(-)
> create mode 100644 gcc/testsuite/gcc.target/i386/avx-covert-1.c
> create mode 100644 gcc/testsuite/gcc.target/i386/avx-fp-covert-1.c
> create mode 100644 gcc/testsuite/gcc.target/i386/avx-int-covert-1.c
> create mode 100644 gcc/testsuite/gcc.target/i386/sse-covert-1.c
> create mode 100644 gcc/testsuite/gcc.target/i386/sse-fp-covert-1.c
> create mode 100644 gcc/testsuite/gcc.target/i386/sse-int-covert-1.c
>
> diff --git a/gcc/config/i386/i386-features.c b/gcc/config/i386/i386-features.c
> index ae5ea02a002..91bfa06d4bf 100644
> --- a/gcc/config/i386/i386-features.c
> +++ b/gcc/config/i386/i386-features.c
> @@ -2218,14 +2218,16 @@ remove_partial_avx_dependency (void)
> machine_mode dest_mode = GET_MODE (dest);
> machine_mode src_mode;
>
> - if (TARGET_USE_VECTOR_FP_CONVERTS)
> + if (TARGET_USE_VECTOR_FP_CONVERTS
> + || !TARGET_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY)
> {
> src_mode = GET_MODE (XEXP (src, 0));
> if (src_mode == E_SFmode || src_mode == E_DFmode)
> continue;
> }
>
> - if (TARGET_USE_VECTOR_CONVERTS)
> + if (TARGET_USE_VECTOR_CONVERTS
> + || !TARGET_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY)
> {
> src_mode = GET_MODE (XEXP (src, 0));
> if (src_mode == E_SImode || src_mode == E_DImode)
> diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h
> index e76bb55c080..ec60b89753e 100644
> --- a/gcc/config/i386/i386.h
> +++ b/gcc/config/i386/i386.h
> @@ -334,6 +334,10 @@ extern unsigned char ix86_tune_features[X86_TUNE_LAST];
> ix86_tune_features[X86_TUNE_PARTIAL_REG_DEPENDENCY]
> #define TARGET_SSE_PARTIAL_REG_DEPENDENCY \
> ix86_tune_features[X86_TUNE_SSE_PARTIAL_REG_DEPENDENCY]
> +#define TARGET_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY \
> + ix86_tune_features[X86_TUNE_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY]
> +#define TARGET_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY \
> + ix86_tune_features[X86_TUNE_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY]
> #define TARGET_SSE_UNALIGNED_LOAD_OPTIMAL \
> ix86_tune_features[X86_TUNE_SSE_UNALIGNED_LOAD_OPTIMAL]
> #define TARGET_SSE_UNALIGNED_STORE_OPTIMAL \
> diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
> index 13f6f57cdcc..c82a9dc1f67 100644
> --- a/gcc/config/i386/i386.md
> +++ b/gcc/config/i386/i386.md
> @@ -4535,7 +4535,8 @@
> (float_extend:DF
> (match_operand:SF 1 "nonimmediate_operand")))]
> "!TARGET_AVX
> - && TARGET_SSE_PARTIAL_REG_DEPENDENCY && epilogue_completed
> + && TARGET_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY
> + && epilogue_completed
> && optimize_function_for_speed_p (cfun)
> && (!REG_P (operands[1])
> || (!TARGET_AVX && REGNO (operands[0]) != REGNO (operands[1])))
> @@ -4708,7 +4709,8 @@
> (float_truncate:SF
> (match_operand:DF 1 "nonimmediate_operand")))]
> "!TARGET_AVX
> - && TARGET_SSE_PARTIAL_REG_DEPENDENCY && epilogue_completed
> + && TARGET_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY
> + && epilogue_completed
> && optimize_function_for_speed_p (cfun)
> && (!REG_P (operands[1])
> || (!TARGET_AVX && REGNO (operands[0]) != REGNO (operands[1])))
> @@ -5243,7 +5245,8 @@
> [(set (match_operand:MODEF 0 "sse_reg_operand")
> (float:MODEF (match_operand:SWI48 1 "nonimmediate_operand")))]
> "!TARGET_AVX
> - && TARGET_SSE_PARTIAL_REG_DEPENDENCY && epilogue_completed
> + && TARGET_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY
> + && epilogue_completed
> && optimize_function_for_speed_p (cfun)
> && (!EXT_REX_SSE_REG_P (operands[0])
> || TARGET_AVX512VL)"
> diff --git a/gcc/config/i386/x86-tune.def b/gcc/config/i386/x86-tune.def
> index 088edb6c4ca..58e8ead56b4 100644
> --- a/gcc/config/i386/x86-tune.def
> +++ b/gcc/config/i386/x86-tune.def
> @@ -64,6 +64,21 @@ DEF_TUNE (X86_TUNE_SSE_PARTIAL_REG_DEPENDENCY, "sse_partial_reg_dependency",
> m_PPRO | m_P4_NOCONA | m_CORE_ALL | m_BONNELL | m_AMDFAM10
> | m_BDVER | m_ZNVER | m_TREMONT | m_GENERIC)
>
> +/* X86_TUNE_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY: This knob avoids
> + partial write to the destination in scalar SSE conversion from FP
> + to FP. */
> +DEF_TUNE (X86_TUNE_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY,
> + "sse_partial_reg_fp_converts_dependency",
> + m_PPRO | m_P4_NOCONA | m_CORE_ALL | m_BONNELL | m_AMDFAM10
> + | m_BDVER | m_ZNVER | m_GENERIC)
I thought we wanted to enable this for Tremont.
> +
> +/* X86_TUNE_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY: This knob avoids partial
> + write to the destination in scalar SSE conversion from integer to FP. */
> +DEF_TUNE (X86_TUNE_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY,
> + "sse_partial_reg_converts_dependency",
> + m_PPRO | m_P4_NOCONA | m_CORE_ALL | m_BONNELL | m_AMDFAM10
> + | m_BDVER | m_ZNVER | m_GENERIC)
> +
> /* X86_TUNE_SSE_SPLIT_REGS: Set for machines where the type and dependencies
> are resolved on SSE register parts instead of whole registers, so we may
> maintain just lower part of scalar values in proper format leaving the
--
H.J.
next prev parent reply other threads:[~2021-09-15 14:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 8:09 [PATCH 0/4] Update mtune=tremont lili.cui
2021-09-15 8:09 ` [PATCH 1/4] [PATCH 1/4] x86: Update -mtune=tremont lili.cui
2021-09-16 6:35 ` Uros Bizjak
2021-09-15 8:09 ` [PATCH 2/4] [PATCH 2/4] x86: Update memcpy/memset inline strategies for -mtune=tremont lili.cui
2021-09-16 6:36 ` Uros Bizjak
2021-09-15 8:09 ` [PATCH 3/4] [PATCH 3/4] x86: Properly handle USE_VECTOR_FP_CONVERTS/USE_VECTOR_CONVERTS lili.cui
2021-09-16 6:27 ` Uros Bizjak
2021-09-17 3:15 ` Cui, Lili
2021-09-17 6:35 ` Uros Bizjak
2021-09-17 23:50 ` Jakub Jelinek
2021-09-18 2:25 ` Hongtao Liu
2021-09-15 8:09 ` [PATCH 4/4] [PATCH 4/4] x86: Add TARGET_SSE_PARTIAL_REG_[FP_]CONVERTS_DEPENDENCY lili.cui
2021-09-15 14:13 ` H.J. Lu [this message]
2021-09-15 23:54 ` Cui, Lili
2021-09-16 2:21 ` H.J. Lu
2021-09-16 6:34 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOra_SCyW9VzDG0fDaFogg9tb5j2dQwLE33oRUUsMVxR4g@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=lili.cui@intel.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).