From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jack Howarth <howarth.at.gcc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Mike Stump <mikestump@comcast.net>,
Iain Sandoe <iain@codesourcery.com>,
Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH][Revised] Fix PR66509
Date: Fri, 26 Jun 2015 16:29:00 -0000 [thread overview]
Message-ID: <CAMe9rOrf2OxxSt2w=3vEaH0CZs8ucjeypHyKoqRJ1sZ8DK1-ZQ@mail.gmail.com> (raw)
In-Reply-To: <CAJMcOU-zFx6PcPbLBgdHWxi4swqvM+Ko2FtxXFQFmt=XxcGbuQ@mail.gmail.com>
On Fri, Jun 26, 2015 at 9:09 AM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
> The attached revised patch adjusts the tests for the filds and fists
> mnemonics to use the assembly...
>
> filds (%ebp); fists (%ebp)
>
> and the test for the fildq and fistq mnemonics to use the assembly...
>
> fildq (%ebp); fistpq (%ebp)
>
> which will assemble for both 64-bit and 32-bit mode. This is required
> to avoid "ambiguous instructions require an explicit suffix" errors
> from the clang-based assembler in Xcode 7. The change also has the
> side-benefit of allowing the legacy GNU assembler from Xcode 6.3 or
> earlier to properly detect that the filds, fists, fildq and fistq
> mnemonics are available on x86_64-apple-darwin. Bootstrapped tested on
> x86_64-apple-darwin14 against the Apple Inc version cctools-870, GNU
> assembler version 1.38 and on x86_64-apple-darwin15 against the new
> clang-based assembler.
> Okay for gcc trunk?
> Jack
> ps Also confirmed with 'as -32' and 'as -64' on x86_64 Fedora.
fildq (%ebp); fistpq (%ebp) are valid for GNU assembler.
--
H.J.
next prev parent reply other threads:[~2015-06-26 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 16:15 Jack Howarth
2015-06-26 16:29 ` H.J. Lu [this message]
2015-06-26 16:51 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrf2OxxSt2w=3vEaH0CZs8ucjeypHyKoqRJ1sZ8DK1-ZQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=howarth.at.gcc@gmail.com \
--cc=iain@codesourcery.com \
--cc=mikestump@comcast.net \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).