From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jeff Law <law@redhat.com>, Bernd Schmidt <bschmidt@redhat.com>,
Eric Botcazou <ebotcazou@adacore.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Andrew Pinski <pinskia@gmail.com>,
Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
Subject: Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628)
Date: Tue, 12 Apr 2016 19:11:00 -0000 [thread overview]
Message-ID: <CAMe9rOrfmLh0kpOF=i_9DoOrXykoOOFCE_R82j+yiAu9W9wszQ@mail.gmail.com> (raw)
In-Reply-To: <20160412151011.GW19207@tucnak.redhat.com>
On Tue, Apr 12, 2016 at 8:10 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> Most of simplify-rtx.c attempts hard not to generate any extra instructions,
> just simplify the RTL to something equivalent and let the user try to
> recognize it, or whatever else it wishes.
> This is especially important post-reload, when we can't create new pseudos,
> or e.g. when processing (simplifying) DEBUG_INSNs, where we certainly don't
> want any code around it (not to mention where exactly would it be emitted
> anyway?). E.g. it uses the gen_lowpart_no_emit rtl hook instead of
> gen_lowpart, etc.
> As the following testcase shows, there are two exceptions, for
> POINTER_EXTEND* targets under some very limited conditions it actually
> calls convert_memory_address, which sometimes does what simplify-rtx.c
> normally does, just return equivalent RTL expression, but in another case
> can create a new pseudo (no no after reload, or for debug insns any time)
> and emit some move insns.
>
> This patch arranges for a new argument to
> convert_memory_address_addr_space_1 and calls it with that new argument set
> to true, to make sure it never emits instructions or creates pseudos.
>
> Compared to the previous version of the patch, I've added ATTRIBUTE_UNUSED
> to the new argument, so that bootstrap doesn't fail on targets that don't
> define POINTERS_EXTEND*.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, bootstrapped on
> aarch64-linux (regtest pending).
> I don't have access to aarch64 ilp32 setup though, Andrew or anybody else,
> could you please test it there? Also CCing H.J. just in case it affects
> x86 -mx32.
>
I bootstrapped and tested it on x32. There is no regression.
--
H.J.
next prev parent reply other threads:[~2016-04-12 19:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 15:10 Jakub Jelinek
2016-04-12 19:11 ` H.J. Lu [this message]
2016-04-12 20:02 ` Bernd Schmidt
2016-04-12 20:07 ` Jakub Jelinek
2016-04-12 20:14 ` Bernd Schmidt
2016-04-12 20:34 ` Jakub Jelinek
2016-04-13 8:09 ` Andreas Schwab
2016-04-13 13:48 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrfmLh0kpOF=i_9DoOrXykoOOFCE_R82j+yiAu9W9wszQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=bschmidt@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=law@redhat.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).