From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119069 invoked by alias); 12 Apr 2016 19:11:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119043 invoked by uid 89); 12 Apr 2016 19:11:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*ebotcazou, Hx-languages-length:1798, wishes X-HELO: mail-qk0-f180.google.com Received: from mail-qk0-f180.google.com (HELO mail-qk0-f180.google.com) (209.85.220.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 12 Apr 2016 19:11:41 +0000 Received: by mail-qk0-f180.google.com with SMTP id n130so10481012qke.3 for ; Tue, 12 Apr 2016 12:11:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=BvdSbdBSJ8GiwG2HzOhAroiJ779NYvelGra3xW4Rwng=; b=iO3M9B6zpOVTE/5xi7FR1r0Jsbpy78wzPJ80R4DrOgVLXzsazaLiIqDVu0lZUo+eNS H9h2BJPn2GnnRYGs6C6sh3OeKRQGTxkAsDAcyZ9sJpeD6XHAIHghPI1CFTe8ye08L2Kv uRSECOEo9PHHE/TUvz97cSepD5kdAzookwoDgHCGtTHxMTzjh/GVeanUFb9eP2D/lUaX 2W+00P3VHwDwluUio3/DXFtoquBOAIttpZjiovgKUPdmh+dHXyCl7ppHMjdtDCXXyWK7 Xb1I3E5CfioBANzuymi0EEII6EMF4oprpK894ZoHeIk8+qLbTFFQD6VZYEHu2Jz4l96J kwAA== X-Gm-Message-State: AOPr4FXsatFecyMEpWN4t2/iGxY0Vc35gb73NoZeGr2y1/tZWeZHuNiA3oLMFROzl+YbVfmWhoXeOreHCEpzeA== MIME-Version: 1.0 X-Received: by 10.55.50.136 with SMTP id y130mr5691674qky.79.1460488299357; Tue, 12 Apr 2016 12:11:39 -0700 (PDT) Received: by 10.55.217.134 with HTTP; Tue, 12 Apr 2016 12:11:39 -0700 (PDT) In-Reply-To: <20160412151011.GW19207@tucnak.redhat.com> References: <20160412151011.GW19207@tucnak.redhat.com> Date: Tue, 12 Apr 2016 19:11:00 -0000 Message-ID: Subject: Re: [PATCH] Fix debug ICE on aarch64 due to bad rtl simplification (PR debug/70628) From: "H.J. Lu" To: Jakub Jelinek Cc: Jeff Law , Bernd Schmidt , Eric Botcazou , GCC Patches , Andrew Pinski , Kyrill Tkachov Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00550.txt.bz2 On Tue, Apr 12, 2016 at 8:10 AM, Jakub Jelinek wrote: > Hi! > > Most of simplify-rtx.c attempts hard not to generate any extra instructions, > just simplify the RTL to something equivalent and let the user try to > recognize it, or whatever else it wishes. > This is especially important post-reload, when we can't create new pseudos, > or e.g. when processing (simplifying) DEBUG_INSNs, where we certainly don't > want any code around it (not to mention where exactly would it be emitted > anyway?). E.g. it uses the gen_lowpart_no_emit rtl hook instead of > gen_lowpart, etc. > As the following testcase shows, there are two exceptions, for > POINTER_EXTEND* targets under some very limited conditions it actually > calls convert_memory_address, which sometimes does what simplify-rtx.c > normally does, just return equivalent RTL expression, but in another case > can create a new pseudo (no no after reload, or for debug insns any time) > and emit some move insns. > > This patch arranges for a new argument to > convert_memory_address_addr_space_1 and calls it with that new argument set > to true, to make sure it never emits instructions or creates pseudos. > > Compared to the previous version of the patch, I've added ATTRIBUTE_UNUSED > to the new argument, so that bootstrap doesn't fail on targets that don't > define POINTERS_EXTEND*. > > Bootstrapped/regtested on x86_64-linux and i686-linux, bootstrapped on > aarch64-linux (regtest pending). > I don't have access to aarch64 ilp32 setup though, Andrew or anybody else, > could you please test it there? Also CCing H.J. just in case it affects > x86 -mx32. > I bootstrapped and tested it on x32. There is no regression. -- H.J.