From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5519 invoked by alias); 11 Jun 2012 19:15:41 -0000 Received: (qmail 5489 invoked by uid 22791); 11 Jun 2012 19:15:40 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-qc0-f175.google.com (HELO mail-qc0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jun 2012 19:15:27 +0000 Received: by qcso7 with SMTP id o7so2010857qcs.20 for ; Mon, 11 Jun 2012 12:15:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.185.77 with SMTP id cn13mr10160151qab.38.1339442126713; Mon, 11 Jun 2012 12:15:26 -0700 (PDT) Received: by 10.229.192.129 with HTTP; Mon, 11 Jun 2012 12:15:26 -0700 (PDT) In-Reply-To: <4FD64038.6060609@mentor.com> References: <4FD64038.6060609@mentor.com> Date: Mon, 11 Jun 2012 19:21:00 -0000 Message-ID: Subject: Re: [patch]: move stackalign tests that use dg-options From: "H.J. Lu" To: janisjo@codesourcery.com Cc: "gcc-patches >> \"gcc-patches@gcc.gnu.org\"" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-06/txt/msg00633.txt.bz2 On Mon, Jun 11, 2012 at 12:00 PM, Janis Johnson wrote: > The tests in gcc.dg/torture/stackalign use two sets of torture options: > the usual optimization sets used as default for torture tests, and up to > four sets of options that are specific to stack alignment. =A0The stack > alignment options are passed via an option that is used by the dg-test > option dg_extra_tool_flags, which can be overridden by dg-options. =A0This > means that the seven tests in that test directory that use dg-option do > not use the other alignment options. =A0All seven of these tests are > limited to x86 targets. =A0Four of them use -msse2, and four use different > values for -mpreferred-stack-boundary (one does both), so it doesn't > look as if they are intended to use the four sets of stackalign torture > options. > > This patch moves those seven tests out of the stackalign directory up to > the general gcc.dg/torture directory. =A0With them out of the way I'll be > able to use clean up the remaining stackalign tests to use torture test > support to combine the stack align options with other torture options so > they'll show up in test summary lines, eliminating lots of duplicate > lines in test summaries. > > Tested on i686-pc-linux-gnu and arm-none-eabi. =A0OK for mainline? > > 2012-06-11 =A0Janis Johnson =A0 > > =A0 =A0 =A0 =A0* gcc.dg/torture/stackalign/alloca-2.c: Move to ... > =A0 =A0 =A0 =A0* gcc.dg/torture/alloca-2.c: ... here. > =A0 =A0 =A0 =A0* gcc.dg/torture/stackalign/alloca-3.c: Move to ... > =A0 =A0 =A0 =A0* gcc.dg/torture/alloca-3.c: ... here. > =A0 =A0 =A0 =A0* gcc.dg/torture/stackalign/alloca-4.c: Move to ... > =A0 =A0 =A0 =A0* gcc.dg/torture/alloca-4.c: ... here. > =A0 =A0 =A0 =A0* gcc.dg/torture/stackalign/alloca-5.c: Move to ... > =A0 =A0 =A0 =A0* gcc.dg/torture/alloca-5.c: ... here. > =A0 =A0 =A0 =A0* gcc.dg/torture/stackalign/alloca-6.c: Move to ... > =A0 =A0 =A0 =A0* gcc.dg/torture/alloca-6.c: ... here. > =A0 =A0 =A0 =A0* gcc.dg/torture/stackalign/push-1.c: Move to ... > =A0 =A0 =A0 =A0* gcc.dg/torture/push-1.c: ... here. > =A0 =A0 =A0 =A0* gcc.dg/torture/stackalign/vararg-3.c: Move to ... > =A0 =A0 =A0 =A0* gcc.dg/torture/vararg-3.c: ... here. stackalign.exp has gcc-dg-runtest [lsort [glob $srcdir/$subdir/*.c]] $additional_flags if { [check_effective_target_fpic] } then { set pic_additional_flags $additional_flags lappend pic_additional_flags "-fpic" gcc-dg-runtest [lsort [glob $srcdir/$subdir/*.c]] $pic_additional_flags } It adds PIC tests. Will this change remove PIC tests? --=20 H.J.