From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9370 invoked by alias); 6 Sep 2011 01:39:21 -0000 Received: (qmail 9360 invoked by uid 22791); 6 Sep 2011 01:39:20 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f48.google.com (HELO mail-qw0-f48.google.com) (209.85.216.48) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Sep 2011 01:39:05 +0000 Received: by qwj9 with SMTP id 9so4931243qwj.35 for ; Mon, 05 Sep 2011 18:39:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.221.132 with SMTP id ic4mr1186832qcb.194.1315273144706; Mon, 05 Sep 2011 18:39:04 -0700 (PDT) Received: by 10.229.97.75 with HTTP; Mon, 5 Sep 2011 18:39:04 -0700 (PDT) In-Reply-To: <20110902152437.GD21553@virgil.arch.suse.de> References: <20110902152437.GD21553@virgil.arch.suse.de> Date: Tue, 06 Sep 2011 01:39:00 -0000 Message-ID: Subject: Re: [PATCH] Store jump functions in a VECtor From: "H.J. Lu" To: GCC Patches , Jan Hubicka Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00331.txt.bz2 On Fri, Sep 2, 2011 at 8:24 AM, Martin Jambor wrote: > Hi, > > when I submitted the new IPA-CP a few months ago Honza requested that > I store the jump_functions in a VECtor rather than an array in which > they are now. =A0The patch below does exactly that. > > The last remaining such request is to rename > ipa_check_create_node_params to "something else." =A0I guess I'll leave > this to the next weekend when we'll see each other. > > I hope I got the ggc stuff right and a GTY marker does not need to be > added somewhere. =A0On the other hand, the patch passes bootstrap and > testsuite on x86_64-linux and I have successfully LTO-built Firefox > with it (which was able to display some complicated pages). > > OK for trunk? > > Thanks, > > Martin > > > 2011-09-02 =A0Martin Jambor =A0 > > =A0 =A0 =A0 =A0* ipa-prop.h (ipa_jump_func_t): New typedef. > =A0 =A0 =A0 =A0(struct ipa_edge_args): Removed field argument_count, field > =A0 =A0 =A0 =A0jump_functions turned into a vector. > =A0 =A0 =A0 =A0(ipa_set_cs_argument_count): Removed. > =A0 =A0 =A0 =A0(ipa_get_cs_argument_count): Updated to work on vectors. > =A0 =A0 =A0 =A0(ipa_get_ith_jump_func): Likewise. > =A0 =A0 =A0 =A0* ipa-prop.c (ipa_count_arguments): Removed. > =A0 =A0 =A0 =A0(compute_scalar_jump_functions): Use ipa_get_ith_jump_func= to access > =A0 =A0 =A0 =A0jump functions. =A0Update caller. > =A0 =A0 =A0 =A0(compute_pass_through_member_ptrs): Likewise. > =A0 =A0 =A0 =A0(compute_cst_member_ptr_arguments): Likewise. > =A0 =A0 =A0 =A0(ipa_compute_jump_functions_for_edge): Get number of argum= ents from > =A0 =A0 =A0 =A0the statement, allocate vector. > =A0 =A0 =A0 =A0(ipa_compute_jump_functions): Do not call ipa_count_argume= nts. > =A0 =A0 =A0 =A0(duplicate_ipa_jump_func_array): Removed. > =A0 =A0 =A0 =A0(ipa_edge_duplication_hook): Use VEC_copy, do not copy arg= ument count. > =A0 =A0 =A0 =A0(ipa_read_node_info): Allocate vector. > > This caused: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D50301 --=20 H.J.