From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 43ECF3982C2D for ; Thu, 24 Jun 2021 18:00:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 43ECF3982C2D Received: by mail-pj1-x102f.google.com with SMTP id bb20so3944135pjb.3 for ; Thu, 24 Jun 2021 11:00:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IkrRZsMqfbufNpoBoc5kaQhVgDznPnavdyr50vhGApg=; b=Klgbv9+5nLIEwtgDNMRAzPOmRn9oocygQ1ikapliW3HYn9dVIhPYEHjasPqnpM50HB XL89pz9sDOlpiu3H5nwwsGJ8uXEoLQakdluJ+kgJsa6zQ54MpNyFJ5A07e5QQZuEwPeP 65MdA6rC9VVJdj+GYbctedB+yUclBxPliqV4lN31x8bSGtPKi30qUVb/+5MJybywuCXb nYi3gR0Jq+HZx8u88UmL4bXsbnaKRnARvCReQckN0UhxehLyoxncizsyvcFZ3ePXPh8b vtbuFexxGR+LIjqXc02qYPhavu3/KeJn9B1tpEJ2/iRJeRkfZwzic6phEwZCiQmf0iUB weIw== X-Gm-Message-State: AOAM533IwZAz3/ZX8G3c54MnSoUcdo2Ity5QfqJZ99aVk0et+rEryDgB jG7/7Pt7I//Sv22yWh0N+zG6HPXlLTUhEtrTudE= X-Google-Smtp-Source: ABdhPJzK95/q6nnff6pQIzmmZ4tZ02jxLC5mH8Ux/UoxL5RaEzJ8uNJa8LtaebVBIHcFjlznTK7RPHzwall9fwDT7aA= X-Received: by 2002:a17:902:b095:b029:118:cfad:c536 with SMTP id p21-20020a170902b095b0290118cfadc536mr5290400plr.79.1624557658221; Thu, 24 Jun 2021 11:00:58 -0700 (PDT) MIME-Version: 1.0 References: <20210624121213.3469943-1-hjl.tools@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Thu, 24 Jun 2021 11:00:22 -0700 Message-ID: Subject: Re: [PATCH] x86: Compile CPUID functions with -mgeneral-regs-only To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" , Hongtao Liu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3032.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 18:01:00 -0000 On Thu, Jun 24, 2021 at 9:12 AM Uros Bizjak wrote: > > On Thu, Jun 24, 2021 at 2:12 PM H.J. Lu wrote: > > > > CPUID functions are used to detect CPU features. If vector ISAs > > are enabled, compiler is free to use them in these functions. Add > > __attribute__ ((target("general-regs-only"))) to CPUID functions > > to avoid vector instructions. > > These functions are intended to be inlined, so how does target > attribute affect inlining? CPUID function won't be inlined. Then we need to rewrite x86 tests to put CPUID check in a separate function with target attribute to limit ISAs used. > Uros. > > > > > gcc/ > > > > PR target/101185 > > * config/i386/cpuid.h (__get_cpuid_max): Add > > __attribute__ ((target("general-regs-only"))). > > (__get_cpuid): Likewise. > > (__get_cpuid_count): Likewise. > > (__cpuidex): Likewise. > > > > gcc/testsuite/ > > > > PR target/101185 > > * gcc.target/i386/avx512-check.h (check_osxsave): Add > > __attribute__ ((target("general-regs-only"))). > > (main): Likewise. > > --- > > gcc/config/i386/cpuid.h | 4 ++++ > > gcc/testsuite/gcc.target/i386/avx512-check.h | 2 ++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/gcc/config/i386/cpuid.h b/gcc/config/i386/cpuid.h > > index aebc17c6827..74881ee91e5 100644 > > --- a/gcc/config/i386/cpuid.h > > +++ b/gcc/config/i386/cpuid.h > > @@ -243,6 +243,7 @@ > > pointer is non-null, then first four bytes of the signature > > (as found in ebx register) are returned in location pointed by sig. */ > > > > +__attribute__ ((target("general-regs-only"))) > > static __inline unsigned int > > __get_cpuid_max (unsigned int __ext, unsigned int *__sig) > > { > > @@ -298,6 +299,7 @@ __get_cpuid_max (unsigned int __ext, unsigned int *__sig) > > supported and returns 1 for valid cpuid information or 0 for > > unsupported cpuid leaf. All pointers are required to be non-null. */ > > > > +__attribute__ ((target("general-regs-only"))) > > static __inline int > > __get_cpuid (unsigned int __leaf, > > unsigned int *__eax, unsigned int *__ebx, > > @@ -315,6 +317,7 @@ __get_cpuid (unsigned int __leaf, > > > > /* Same as above, but sub-leaf can be specified. */ > > > > +__attribute__ ((target("general-regs-only"))) > > static __inline int > > __get_cpuid_count (unsigned int __leaf, unsigned int __subleaf, > > unsigned int *__eax, unsigned int *__ebx, > > @@ -330,6 +333,7 @@ __get_cpuid_count (unsigned int __leaf, unsigned int __subleaf, > > return 1; > > } > > > > +__attribute__ ((target("general-regs-only"))) > > static __inline void > > __cpuidex (int __cpuid_info[4], int __leaf, int __subleaf) > > { > > diff --git a/gcc/testsuite/gcc.target/i386/avx512-check.h b/gcc/testsuite/gcc.target/i386/avx512-check.h > > index 0a377dba1d5..406faf8fe03 100644 > > --- a/gcc/testsuite/gcc.target/i386/avx512-check.h > > +++ b/gcc/testsuite/gcc.target/i386/avx512-check.h > > @@ -25,6 +25,7 @@ do_test (void) > > } > > #endif > > > > +__attribute__ ((target("general-regs-only"))) > > static int > > check_osxsave (void) > > { > > @@ -34,6 +35,7 @@ check_osxsave (void) > > return (ecx & bit_OSXSAVE) != 0; > > } > > > > +__attribute__ ((target("general-regs-only"))) > > int > > main () > > { > > -- > > 2.31.1 > > -- H.J.