From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hjl.tools@gmail.com>
Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com
 [IPv6:2607:f8b0:4864:20::430])
 by sourceware.org (Postfix) with ESMTPS id DDF613858437
 for <gcc-patches@gcc.gnu.org>; Tue,  8 Mar 2022 17:49:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDF613858437
Received: by mail-pf1-x430.google.com with SMTP id a5so26053pfv.2
 for <gcc-patches@gcc.gnu.org>; Tue, 08 Mar 2022 09:49:47 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=kMuyb9ZW9k/JxsK77WVUDMi8BzUCiAiCSka+FoqjZf8=;
 b=yOkyQqvY4tj/bt4D2BiwNRu0HRPtJ130T5unit/ZC9TDv47rjUc1YYfxSojuxH8VPl
 xauZlWZaE8hTwhyYZzKRT+C6G+CVaPsfRAKST8ZmnlXnTMNo5BtPWU+LG3RgesBBAFzT
 cG8X0J+kaM6j1Y9qric6VNl9FEUk4m9QO0V0grIuyXZ5Ek9tz+7Y6+ZERxaJ3dBJBb5T
 hmC9lZOWVMUNQn55hRk01ki4SNIDj+W8hjAPaR5djYpQcwCG1d5WdBFXUjvcvEeckboj
 KPDqGduxMiaYSlFfF+X4TnTm2Qgq+GFr0z8Ywx5xiipOpjuYb48DUdPYHdCL4eE5eODs
 jx9Q==
X-Gm-Message-State: AOAM532WjKlBBqlzSMtyGINuDSK+xUL6HkHp5/TFFHKZW05irZySWPYP
 BhbTw5IHSzH5thS+sW7NLGisxjG9XCGIPf6msso=
X-Google-Smtp-Source: ABdhPJwCfUGFAQdMcm3FUloUuO6xpjb/8erU4DhZIsaDYZVrdUTCJg/gEaYHupzfoxOjkTBZPcJL+/iLzSQd5b8bDj4=
X-Received: by 2002:a63:4a44:0:b0:372:db13:5583 with SMTP id
 j4-20020a634a44000000b00372db135583mr15026578pgl.210.1646761786958; Tue, 08
 Mar 2022 09:49:46 -0800 (PST)
MIME-Version: 1.0
References: <20220307150628.68146-1-hjl.tools@gmail.com>
 <YicutzHS7vFn9x5n@tucnak>
 <Yic6wxdaLDVd3/oE@tucnak> <YidMOvVHLWBwgBxz@tucnak>
 <CAMe9rOq=+e1fD7edAwF+XMARCePvbJ-SN1=4BdaX3P=uXYUtLQ@mail.gmail.com>
 <Yid6OgTq8uH+Ze4O@tucnak>
 <CAMe9rOosJO5wz5=ZibD-sL_JL+uAoc+-m4B4BT8AK1g5jc619g@mail.gmail.com>
 <YieT0l9915XwHt7c@tucnak>
In-Reply-To: <YieT0l9915XwHt7c@tucnak>
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 8 Mar 2022 09:49:11 -0800
Message-ID: <CAMe9rOrmJih2TRxd8VkJikRD34TMKGEbd73D+kHQx04ZX5CnbQ@mail.gmail.com>
Subject: Re: [PATCH] x86: Define LIBGCC2_UNWIND_ATTRIBUTE on ia32 [PR104781]
To: Jakub Jelinek <jakub@redhat.com>
Cc: Uros Bizjak <ubizjak@gmail.com>, Richard Biener <rguenther@suse.de>, 
 Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-3020.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2022 17:49:49 -0000

On Tue, Mar 8, 2022 at 9:35 AM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Tue, Mar 08, 2022 at 08:09:25AM -0800, H.J. Lu wrote:
> > > Ok.  So, what do you think about replacing the libgcc/ part of your patch
> > > with that
> > > /* __builtin_eh_return can't handle stack realignment, so disable SSE in
> > >    32-bit libgcc functions that call it.  */
> > > #ifndef __x86_64__
> > > #define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("no-sse")))
> > > #endif
> > > ?
> >
> > Yes, it should work.
>
> So, how do we move on with this?
> I can't self-approve my own patch, so can anyone please ack the following
> provided it passes bootstraps/regtests ({x86_64,i686}-linux) that are
> currently pending?
>
> That can go in independently from your patch, and if it is committed,
> your V3 patch with the libgcc/ hunks removed is preapproved for trunk.
>
> 2022-03-08  Jakub Jelinek  <jakub@redhat.com>
>
>         PR target/104781
>         * config/i386/i386.h (LIBGCC2_UNWIND_ATTRIBUTE): Define for ia32.
>
> --- gcc/config/i386/i386.h.jj   2022-02-25 12:06:45.535493490 +0100
> +++ gcc/config/i386/i386.h      2022-03-08 11:20:43.207043370 +0100
> @@ -2848,6 +2848,12 @@ extern enum attr_cpu ix86_schedule;
>  #define NUM_X86_64_MS_CLOBBERED_REGS 12
>  #endif
>
> +/* __builtin_eh_return can't handle stack realignment, so disable SSE in
> +   32-bit libgcc functions that call it.  */
> +#ifndef __x86_64__
> +#define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("no-sse")))
> +#endif
> +
>  /*
>  Local variables:
>  version-control: t
>
>
>         Jakub
>

LGTM.

Thanks.

-- 
H.J.